From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D05EFC77B7A for ; Sat, 20 May 2023 04:09:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 45ED8900005; Sat, 20 May 2023 00:09:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C10D900003; Sat, 20 May 2023 00:09:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 261FA900005; Sat, 20 May 2023 00:09:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 12813900003 for ; Sat, 20 May 2023 00:09:05 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D30A9120AB3 for ; Sat, 20 May 2023 04:09:04 +0000 (UTC) X-FDA: 80809303008.03.28A4F4E Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf28.hostedemail.com (Postfix) with ESMTP id 34FF1C0003 for ; Sat, 20 May 2023 04:09:02 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=e77ULArP; spf=none (imf28.hostedemail.com: domain of BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684555743; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yZFhIbzIAbDjOjqaC2gJ41t0fKFRC84t5Mh0oNaInpA=; b=B81cnyQSFRxsGNs2CpcOXJQkrIIl506/fJgbfRmXnfioXgjJW2+G+/0Yv97qP87GCuuzFj P0cQ3s5+QWv98DHnPq6dhPY0Y0w39CNfr/4A6nhMGwHiworphPk4jQeXjR5u0is7qDP3fa ALBfK1Nj6DHag9NdAK2/FiOON7ZFL6k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684555743; a=rsa-sha256; cv=none; b=iiFXwfcRdamAL5vK5r9ce6n2+Z5MQPFZJu0xK6YQJH6qsQZdJGLB7vpVfD8jZJ/MbkBQVc QSI3bpK3ZKgnSsvjUL+hACOaJFJKDBQmiir09kKxGU0R4GGwfJ+Qe+O1D6+aNqzM/Sf8xU 0zac7ZNqeNprAL/h5TJuw/44sIK1qXc= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=e77ULArP; spf=none (imf28.hostedemail.com: domain of BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yZFhIbzIAbDjOjqaC2gJ41t0fKFRC84t5Mh0oNaInpA=; b=e77ULArPyamKj4X1q2fKH4IGp5 pa6kfWTPi4lk6IAfUa6PsdL/5Re8RhOUZk2CYGko/0Yp581+AC8tQ3wrPatKpNvBA8mQojnq183V0 zLcqArXwF5YPc/A7iK/U9M6I+Me9xXwUz7tROq8AMOcwckuARm3kuIiyMMYDP/8u9C7uU4zx8y7Cn +8SbMmz8hoWiF3/II5+VKBk1cs6+3i5hGsBJ/dVShUhpxNsXiFTcG+wFaSTXQhb19SC0ybOpUK+qV VrPMepu3ZEqYvCfsBwAO0QvJo8xc3RU3GQlA8cc3lBKRIx4bLp1F4c/tZ95M114zjVxWuRqYN7fP5 0vmnNY0w==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q0Dtf-000cqF-0G; Sat, 20 May 2023 04:08:47 +0000 Date: Fri, 19 May 2023 21:08:47 -0700 From: Christoph Hellwig To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Steve French , John Hubbard Subject: Re: [PATCH v21 01/30] splice: Fix filemap of a blockdev Message-ID: References: <20230520000049.2226926-1-dhowells@redhat.com> <20230520000049.2226926-2-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230520000049.2226926-2-dhowells@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: 3ei77n1g13a6s3dxbkzawfssmi47dm6j X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 34FF1C0003 X-Rspam-User: X-HE-Tag: 1684555742-567784 X-HE-Meta: U2FsdGVkX18NVVioqDy6wyqnK44Gxa1vAVtIJlx02AJqvm8VQ5t6LLu3bX1hKOQMgPy9RT6GnmP0fWiOdxhATXcoSlaUAq1NPN/F4y9k2RkUbjTQ72nMYmj8+yyd26TiItWM20z6N2BT6JuptSp9PEB+0zurVt95hC/FYrCC7hYP7Hqa4eU+CfWDkewCrNB2ZkMAc7YC9RfwP94AkhUCmznpKClJz3266dol0XTv/iSxTK13NUDierzbRBZAH/ELMf10ZmR5v+/OAOT93DKsJvhinQmBgMOA0hdcsW6ydfsItC5asSDEnf1L9S7npkYur1PJ6qIl9HG1Y17Y6GzLMQg+M+olEH7283Z+7Ytk4cKppPkn4LgPaJlf8cc4PMnyDFixVIFNMhwuFBaNCiv+W1CYeq5z7ZfqVjqkhfxKlQEMrxlb2eI+cq0lvH85QEsqfl1+hPvnNlzqyDslPndjxfWf+snd9gCiwn/lhlvsrIYva/6Vado3glu6vphV7x2bBu3CndocfX4cbbkFvZS5CO+1yStl9p4JLj06T0xTPjPPsI9bKW/SuT6AkXMtR9jHhY7wada/Nkbo2JQN67z7Ptp4DdIckf9wpQ/3/yx+QsPfpyx37efanYXtzVRv4b/cNIgbpqoWCDPg7MHZkpHJIUBmhpEjfffKiImse3Is9F3xWBtEEiN658c20QhLvS1dZGe8QNQvD6B2vxRoKdaeatjq32k7We11GbspJz59qc9WJfwE2ov9FNoiYvExdRZWA/Nx3fxgnCJpQfqUvJqvmL0V5SMtHsPW/wFRqJOVHmtP4TmKza3GNjr2Jrg6ju74Kv62/51S7h72s0o8QIrBfeEn1oypwWiJkZRi/IKTU1a4y2aYPXpDPXiK777xqcmxjGlUiesta5FK9v80bjh98By+irEedJQeaWHn7i9tgvlJxwDpQIrJaA9I1fGYyv95zLQEdDAiXIvdnOcQg5K 35voGkmz 7BQaqxCgUAnJ4s4+V2A8Q7Ld74WleS0q2ZGE9meSXXEFk1lLKIWUMGuBlNvAkl2Chy/CfmmI+yKwE3BnIEyvxYqwIX+K8O+GeCWsHPx57TWeAHKDQZ5yHzPtIRihf/338RDIbpiOQtRvHNZlinmMqkqWUFJ2sDbYpgJqKegJ7ZjB8wHeJPksfPzPaQ4E2v2tEDwK2qN/JuNVP0hEu7FAMD9MRCZyNSlKFFEhwuz0Zyjp5pXW9ruXGwSIvTK5VTA5peDSy1dUBOwE0mzv4vNICJv3Ut3I1es9OPI3A2ohletjkJVAvQu8UCzgdxriC2z9Lyoadl3mLPEPnzMAhBIq+0erXKQvW3WVMkf6/ZbkLBBDcgoYg+Al84uPHpZyzXZQRupnwGDKcMneIj1Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Just noticed this now, but filemap of a blockdev sounds weird. Maybe something like: splice: use the correct inode in filemap_splice_read might be better.