From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E919C77B7F for ; Sat, 20 May 2023 03:57:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF103280002; Fri, 19 May 2023 23:57:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C9F8B900003; Fri, 19 May 2023 23:57:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8E44280002; Fri, 19 May 2023 23:57:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AB18C900003 for ; Fri, 19 May 2023 23:57:14 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 80751120ABF for ; Sat, 20 May 2023 03:57:14 +0000 (UTC) X-FDA: 80809273188.15.B1696B7 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf28.hostedemail.com (Postfix) with ESMTP id B2F56C0005 for ; Sat, 20 May 2023 03:57:12 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=JabwUtm1; spf=none (imf28.hostedemail.com: domain of BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684555032; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mEJo2AvtRRBovcYEODKkZg/Om1DBMDjK4oNyeFteRYQ=; b=c6rLOZNM0JmuFkWwqF/gLeYfi+2WXp6citUaoaiDkn6aiOxxoa3SfZQtljgt0/xMHvRdUR TlPLuhWvJ1E4udrqK66tNg0gcIrGUoNPF5cDhHHijPrG32tXlb1/+8EWDTEz+RbH/Kw3v6 E90A8ctrqPcs+bWntoKnLw6q3F6UiwI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684555032; a=rsa-sha256; cv=none; b=fxtIMP0F3X5s7jhk/wexg1vQ+mw4XRZp1ITbVuQBB49sFL09FinMy2YNTEmMRUUs9ahg5t ItDNPQKGkj4MBh5wTRZwmQMK+RFIr1QJ7cFJDARzUfS83ARVk4kNOCDMlvu4OPEfYx16Z0 yzRh/L4+We1b0zIbgJlNKYGpYL0b5GY= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=JabwUtm1; spf=none (imf28.hostedemail.com: domain of BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mEJo2AvtRRBovcYEODKkZg/Om1DBMDjK4oNyeFteRYQ=; b=JabwUtm18vAo7f2bgHXyFZnkFF q5JhN8/xdLb/wI6GZwYTcOQB8abF4Kb0j/AvXGoh84sVTx64pNxcNof0P/Px5/BSHMGvpQSfIca68 1k/2bLDxuS2Otnmtw8EgQD0c9fkqjzTD5/vSLcC2d4pSBhExO5zjs9I7oVlc5NABX954qDvdMMH5Q BFdBBYsPSsif/58t79XnO0CP3PucPeFr2SXDKH7Tbm6hftKEOYcnAkpNCnfA3oZZGFAkLDDlHDTkB bnBm9Fmai18RFKosJO4ZIqA9/rL9sme62hpRkm7QDdFfV0kWHa6U/yOHXHZnzVfTOsD7JvPAktybM Ket+sh6Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q0DiC-000bY9-2i; Sat, 20 May 2023 03:56:56 +0000 Date: Fri, 19 May 2023 20:56:56 -0700 From: Christoph Hellwig To: Kent Overstreet Cc: David Howells , Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard Subject: Re: [PATCH v20 29/32] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic Message-ID: References: <20230519074047.1739879-1-dhowells@redhat.com> <20230519074047.1739879-30-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: 35eccwwdub1cpzqzdnuo447xntgdyq8a X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: B2F56C0005 X-Rspam-User: X-HE-Tag: 1684555032-866957 X-HE-Meta: U2FsdGVkX1+liuYUz0NKwTtrfVs/5b7U2DmWI7pRxejikvMcCI0KNTr2iUwp0j2EY4EicNg+Mytx3yg2ix0Ge5YhZQtpjHAEmpgB6V2FhZxemnUDkkLkFFSRFNR7XbN/26Hqhr9bL0M7ibi+0RfLOheJgHA5wBmy6/WtSYHpyODyPHMrrDMTETyXNVGccEyRTE0r+CWUi10+OPq2FMd6/K6nhGmhW03GD0xJhcDj0MPYPKMOMpncC2UzesIpuPZL1w3ZcF93ijKiCM0MzFhIy/qhGZiVSbxvybuffh5Um6fMExm2ZABypAb/vjf0myYcH1L8yNBC+ggBE1KQezc+90ljmSbbsGyaH/UQiQxoZ247TVnANUlF1DevEgbtUi1PVyjVF/r2YNhN82slOFrs+Rz1U9QX221xYsTiaVzXvb7BdUUvY2T+/GoFmPmD+LfaFUgyHQBiNqrv1X+SIi7z5tYHmsEbM53SrpAQ+ss68ygXQmuimZV3nC01ony6oRHy3i8ZZ7Kc+MpA+25P4l8X/1KitteOvFgMdQ242akpoEkp/44fuCn9Gc7uUColYPzVL302zNRlE0vmBOtXeGRQ0YG44gkeklB3eVOH/Z/XxeFjMSJdJxvTVEeESGGrh8VCi1if1xQg5gmMRjWm5QcDRs5UWmM6l8DYVTxdYgwNd88z2odJUersEQEoF6kc1birfr6b5qj9nlecX4bgWAM0H1eWutIpjdEuQyPKrMTyaBqTJlTKPSuqXuX7maSBvP/mmxYj41rBxZMHYA8z7iSeGCqyCJAe+2jciXeZTb8yYuuv3SRVYg1EJIkNyZ8MhwvisvzZv7IpkQ6kNkZDmxkIyBmEej8o6ccFM5UGZvE+4XndfeECzwy6u5YTbf4ypNfoThvYzwAqM1ijABa4JW61nrXTks/YIo2TW18RCSp9oDktCKKlbsyiOL4fq1KoU/Lr32b6TmAJ8XFoTMHvEhU iKY4eGAD d0zYYdxdIpdkmS0Tjrra29RCgXwT495xCTiz4RcAbp2LqSTTzEyBymGBw8fHu6KVgwQf7pNLXm7sXuIvB1va1zgaNesRX5/NDzUe7J59nrW++N5WtnqsayF4dCwhY4/btSBT69lW0s6dR5Xb0QZpgXe730LfAPoS6iuUtqTiyNtiDSvjktZRlU+UcpD7nvQLhasmYvliFOf+iINDBsPPf2H6rlct5WnyUKitdjmDVeHHiWs56BSZFhHhOphFcujKmBFVTAkqzm+fPinx6QhX8ycd/2XiJlhVkRMUVZhSiolK9L21ixIC/sU8oeeXqrL3ctUlQQB27Pfw87pzyOY4cqOi0KgqEDNpHB82lhOmt9Fr26Dsj6Jc7TrwzfCTqOuTI8hrqL2a1ddJs+YELA1WBUPy4/jtU6uW7zz0dCrZWbKKqJgq+tu9XqtE4Ng== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 19, 2023 at 09:26:07PM -0400, Kent Overstreet wrote: > On Fri, May 19, 2023 at 08:40:44AM +0100, David Howells wrote: > > From: Christoph Hellwig > > > > Replace BIO_NO_PAGE_REF with a BIO_PAGE_REFFED flag that has the inverted > > meaning is only set when a page reference has been acquired that needs to > > be released by bio_release_pages(). > > What was the motivation for this patch? So that is only is set when we need to release a page, instead telling code to not release it when it otherwise would, where otherwise would is implicit and undocumented and changes in this series.