From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA81BC77B7D for ; Sat, 20 May 2023 03:31:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 494E7900005; Fri, 19 May 2023 23:31:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 41DC0900003; Fri, 19 May 2023 23:31:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BDE7900005; Fri, 19 May 2023 23:31:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 17886900003 for ; Fri, 19 May 2023 23:31:18 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DD1CA140636 for ; Sat, 20 May 2023 03:31:17 +0000 (UTC) X-FDA: 80809207794.27.89A13E4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 1AE8740005 for ; Sat, 20 May 2023 03:31:15 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BoXocbwq; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684553476; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xVZv6T/wRHC8aZPmUbolnwWkjCu5MdbG+ni9RcvouEs=; b=X4S5nimOLFRaun7V3P5FKp5HElZVYE3XLBf1Ub59ACxw1Peat7YbA7fPitKyqpJuMvRpK4 407ADr5V95l+kT69ESe6wSBgmO2Ai3xlPBTzgA7WeN0L8IcY0Ryvw2wmx8LyAv8iYDXjGo rq2n2RABW7JSHokl1Oo0G8NAxJZzx5o= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BoXocbwq; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684553476; a=rsa-sha256; cv=none; b=tT2GYrjNJj12PDuFLR9NEgDFe3HCgM9MWJ+m23r5imLfHNoXDJ/5TeYPDayTu4TP8F0DYx l6Ho+DoDr+04KGGNovKiNoPSy8ZVLqqOgpaSW4GaBO5s3cZvWxBghDwDFCVYPSu6NdkAZj NcNM9d49o5JTHajpvLvH8AIBSv82PGA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684553475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xVZv6T/wRHC8aZPmUbolnwWkjCu5MdbG+ni9RcvouEs=; b=BoXocbwqkD9ztGZWNpaz6CG763tHvcm3fBLTkMBrvrQqvF/9/26o1UWq0McSiEPBaJv090 FpHhR3Iqo/UbjAbo5yTfupE1b+v6vP8EVSRkOj6ojJ4hzJ17JKFjPh3PPVEN/lN5TsLKXy cak9p/+K/dLxv5n1C39fD7RGAmu0rB4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-574-vOufUwP5MSmvd1hYjrJ7nQ-1; Fri, 19 May 2023 23:31:10 -0400 X-MC-Unique: vOufUwP5MSmvd1hYjrJ7nQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1520F8007D9; Sat, 20 May 2023 03:31:10 +0000 (UTC) Received: from localhost (ovpn-12-79.pek2.redhat.com [10.72.12.79]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3F537492B0A; Sat, 20 May 2023 03:31:08 +0000 (UTC) Date: Sat, 20 May 2023 11:31:04 +0800 From: Baoquan He To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de Subject: Re: [PATCH v5 RESEND 14/17] mm/ioremap: Consider IOREMAP space in generic ioremap Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-15-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Rspamd-Queue-Id: 1AE8740005 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: hi3eicodmgnwrhsa5fdipqbyc3bopm3s X-HE-Tag: 1684553475-864673 X-HE-Meta: U2FsdGVkX18A7OOlz8QVHxW16/1MuQxTRSWDlb4i4/HBeWY1NBBaYG8F3rv1jbZfn+DUaGOwY0ncnqwUR1YRHZzace9HLUaoPxDLLJEw8v7slUG8aSgWwxNMME7rKuzjarbNlvyqqg1TsIcAQT3NWRz0+bJC/myS7WbFWOSI7Xt3YFMbAlsmJcy6q/qOqOIlvGQDNyG11qM9yjI6YyE5iFceHGgO5iJh0Vqdte7FTHDN22yeBXuBqmJW9jgro4T9xrMQtqF+SErEKWetn0h+N7x/yVOOQ8O+2n+AjkdRJxnqcrv4uVaR51nZoOiwQCW7P+Jll/CeO4i7GAfsWERoFdbQGZ7GC72IbGn2WBI+qZ4KJatSarvYEDF+HyO8HJ7Hubuq6e/1WsNi0DFCeEU6FTh50w0/emW7a+XzstZ6scedxLJhGjePIHtlYiKeYUJ9+wOYFG83Qfm0oX1x1nmpGSBUlJkuz5FB8EdFdRe//WgFWCzaZYlhjrl+eUJBX5Afvjg+nRRk3zfzsWw0aXvc7Z4jbCeSrMprCBocj9hDuuc2e08WIl1jeSfFbZPeQjpcTq++fTh592x7I/ulXuxelBOma/xKamJXDMtSMmJ0JghChqGKNaFnbHw4WsvBgBwlhakIuj8+/5Lzb4WDBCOEB2kQu/Xb9TJUEYZWL/J75mLMjeL+CxANc45dPaeEF2ulzY8I/ekWCfQzmFH0+jeOPUfvwEqNfzQhyvjLtHa8HbrIS8stRFu4mD0mNKChppCioUV2tp1TNkblKqWrKS3DxLvPw9hTQjvzi67vGsG8kGl28RL5ylDolZha8XKBVu9ky2ih9RO+RMFxrUmJIJYuAoohblBFbPVsZWJiXbY45qyQBAmcatTVRkTeeh1GV/3IEmRbMA2vmS40tLuAH4tOSHW3VqcTR2LXd7c2Ec4RSEZH3c/A1l4Gpb7XDxGBZipEOCTIsBwhOC26XUnGbj3 JP5ZXTUT UOkppjhJwBbUEsiJAO08Gs6Ewx9ghrJH5mvl/Hmdru4RI7BFwJeGsda7fieHU/2fBmNwFM0Ob7OC/HdjkevqapTJc+1m+izM4HygK1wmjl41bBxw+N6fa0LzvBWnqScblxDerz45+pVFaPS7UkpXJe3KSxJimzZtMKnxt+E7UboDnzErstrWR2TnpaK14OtGXvZNm+ai6NPOdbJs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05/16/23 at 11:44pm, Christoph Hellwig wrote: > On Tue, May 16, 2023 at 11:41:26PM -0700, Christoph Hellwig wrote: > > I think this would be cleaner if we'd just always use > > __get_vm_area_caller and at the top of the file add a: > > > > #ifndef IOREMAP_START > > #define IOREMAP_START VMALLOC_START > > #define IOREMAP_END VMALLOC_END > > #endif > > > > Together with a little comment that ioremap often, but not always > > uses the generic vmalloc area. > > .. and with that we can also simply is_ioremap_addr by moving it > to ioremap.c and making it always operate on the IOREMAP constants. Great idea too, will do. Put this into a separate patch?