From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB180C7EE29 for ; Fri, 19 May 2023 16:39:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4EC4B900004; Fri, 19 May 2023 12:39:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 49CAF900003; Fri, 19 May 2023 12:39:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38B77900004; Fri, 19 May 2023 12:39:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2A5BC900003 for ; Fri, 19 May 2023 12:39:26 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DD1971C7A5A for ; Fri, 19 May 2023 16:39:25 +0000 (UTC) X-FDA: 80807565090.14.A001186 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 2FD40140012 for ; Fri, 19 May 2023 16:39:22 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf09.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684514363; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tm5yWitQFobo7XTUh5Htl9d+/ov6l57MkDLyYMRoUF8=; b=RDL3sfIHi6zTrYzWbqOz9GrF9jjnP/F5BqMBRYWfHiW9QCCSMasuY5uC0Dx+qAiijzOew0 JdRrO1jYsVPYpFJfz1vfwWP+ALX5MAD9/a2NOsuNLesr+XLXvmOROnb+95YfzyCB1cChN7 HGb1sAHbOOa5JjzEiYBL0zgJ/xPs82A= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf09.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684514363; a=rsa-sha256; cv=none; b=buMRAXd040XObYp/gkzQlyc3IrMQXXdMUZQj6GCdKiBHLG0Rqx7ZhxPZk4b2HM/mQp1UO9 cMr2fLAQvygDoRC3xqSy0ga7ncrixd2iS0nMm+7q1neVKUqiLYw38WTgOn3Zsm014Zy5fB PXTSKq1ULYYoejuAj4gdG77A+wm8OQo= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E6824616E2; Fri, 19 May 2023 16:39:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75B3DC433A4; Fri, 19 May 2023 16:39:18 +0000 (UTC) Date: Fri, 19 May 2023 17:39:15 +0100 From: Catalin Marinas To: Peter Collingbourne Cc: Qun-wei Lin =?utf-8?B?KOael+e+pOW0tCk=?= , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, "surenb@google.com" , "david@redhat.com" , Chinwen Chang =?utf-8?B?KOW8temMpuaWhyk=?= , "kasan-dev@googlegroups.com" , Kuan-Ying Lee =?utf-8?B?KOadjuWGoOepjik=?= , Casper Li =?utf-8?B?KOadjuS4reamrik=?= , "gregkh@linuxfoundation.org" , vincenzo.frascino@arm.com, Alexandru Elisei , will@kernel.org, eugenis@google.com, Steven Price , stable@vger.kernel.org Subject: Re: [PATCH v3 1/3] mm: Call arch_swap_restore() from do_swap_page() Message-ID: References: <20230517022115.3033604-1-pcc@google.com> <20230517022115.3033604-2-pcc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230517022115.3033604-2-pcc@google.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2FD40140012 X-Stat-Signature: ud8yay6fpjusgsziazbj4cqwhn7eg5hc X-HE-Tag: 1684514362-693594 X-HE-Meta: U2FsdGVkX18vWFA5CA3rwQzrOldVwCGZZ3jmUJyxCUASpte7jBIQlf8jaMmgU7RAHEjF2bFjgrTAfBQBEbvac5xQzApaVHr021PaTKQuhhhSUCFwZXF0/Azc7jMykn+/Ai/hoA9XVIpPidAPQEYDpZvzFJNd7JD4tlqKbNT22YxheHtZWnmC5WH+pD7iclEYlaFJjVLZTtrfeAsUMC6UIIYNcg8wpn6dlgH5ekLxp06bq6R0Z2SYVy07QHeKOKvqhrQ/FN1Z04eBH2dn0XVXKDKA6xyNCehVSUeMNhKcc5rLsbJUiWIIw3dppgUWsJJvfRccxYqNUbsUezYRxXlCCQ9oA1OMSkRrmhegtRY2l8eAidaGbWWL/HWojl9x0utwYklkAmpNKAAbaOYxB64Z5mZZvMYxSQvlikTgWP2Ty+GXOk1xP64wZwdZ9mEyHGu32Inq/khumlJ+TIRaWiN+XmGGKRDfD2S4opXCRWMcznqTzHeIS0Mg5MNKKxWB3n4q2OWxBC5OZigUGbSrDpo5PqeHoieAQZHGKR6ufI5/RjMpaotFEILN/jhfHOctxhDtbO1SMW6Vdr2U4do2tA080VJQvfRVqdPbYMHtesFflU8J4tK8MC3qquwRLD+vfoo1XQO27XgVPyN6MqlvXsiG38COOhs1b/jSJV7vOcY38mEp/sPtmq3CXEhRE3Onl8h51LhS4680SbUGNUKk23dE+DPLOogk+obYoVpN3SN9Cyf+xk1ngvnVUOglzGGFz0YXJMlwShc8VkpV4TBBAKMhZmSCZK3/QDp8kn3k59+NmIRCP6pckqM9imtKuV38CWnV+BLoptJcHs++2wKf4S1huqTV0MPyAjd1dnhwxjegYWzOhiwxHrweKv+1ZGOu2gnBLH2V1Gfy4TEcyoBVutVktP/1wwpwwU1uLuAsh+bFwjdwC01eU2TSD44uztNzmvCr8tUVQ1ZYig+8De12SIf hAyguKNU NfNpB+zlUOXZEmhCipP7ec+oZNHU3U+I9woJcEBwMdfOIomTYrn3XjhAiqd9FwRdOQ6zSAue1oPP/OSJcOWWE6dc8qgSWBEwJtHCfba3eV5eqOGmSoQ8naej+xdNpdMc8hgxrMdgAa38l63aAb/Cpq79by+ADCTME4jiKEB7zODEdTu/TQTP4hig4CJM3Vzo+PBBuQXgx0WlaOilWg9TltSOlUJze4Cy8Y+P04sjKxQVMHlZ8DPCaYoWPX7GDavEf8BHdM9he/0N2hnGo+rC341VISvLqoGD11qaUn1oEiOE5wxNLULHBqC19/tgKnbVHiJtxQ89aOVk8D5TjRZbh8ZHPzyFxpV2CzHrdfHl+1bb9REZOQgcAA+sRUPZW1Y5lG9eDT/rJnTIKDCOGmuRuYlhP0H0aYYERRKnTzsrIP2abUQ3WbxUYl/kYkyyMGJPxfArLqGDNcUGYs63S3F7yHFvAwdo3tOD5OM4hPu+xfCrNGMaR4ffKwrIZQViZgIsiCD5ls4ysAz/0Gylr+q9R4dj+BApVcJgdoxtVi254hBXINc34DtTraPMXGlfk1FTd2P+ZjQuC/7DZ/Mzq63oAtI21/OamT3gzs2A1A5byMCr6uYqZOVYaBEsfBbL0Ds+uzoH+841UrZft+UsiM7Ad/DcefVBPdHy8fxXuWs8oLPMw7qSi/8ukAmcgZ7+OBuEfHWopceXyQXd1nwCxO43qZR7LeCT8e1NLq3+4ZE2yGNyWMsbYiahL2UpRURxKHFUllT8K X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 16, 2023 at 07:21:11PM -0700, Peter Collingbourne wrote: > Commit c145e0b47c77 ("mm: streamline COW logic in do_swap_page()") moved > the call to swap_free() before the call to set_pte_at(), which meant that > the MTE tags could end up being freed before set_pte_at() had a chance > to restore them. Fix it by adding a call to the arch_swap_restore() hook > before the call to swap_free(). > > Signed-off-by: Peter Collingbourne > Link: https://linux-review.googlesource.com/id/I6470efa669e8bd2f841049b8c61020c510678965 > Cc: # 6.1 > Fixes: c145e0b47c77 ("mm: streamline COW logic in do_swap_page()") > Reported-by: Qun-wei Lin (林群崴) > Closes: https://lore.kernel.org/all/5050805753ac469e8d727c797c2218a9d780d434.camel@mediatek.com/ Acked-by: Catalin Marinas