From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D5A5C77B7A for ; Fri, 19 May 2023 16:42:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 64B05900004; Fri, 19 May 2023 12:42:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FB65900003; Fri, 19 May 2023 12:42:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51068900004; Fri, 19 May 2023 12:42:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4606D900003 for ; Fri, 19 May 2023 12:42:23 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CE05540A8D for ; Fri, 19 May 2023 16:42:22 +0000 (UTC) X-FDA: 80807572524.08.C220744 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id E3CFC4000E for ; Fri, 19 May 2023 16:42:20 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf04.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684514541; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tI3pILZ/sb+GuKG+RKppCAv6vko4emUSZ7mWrZSZD4s=; b=2WRYPFEDcc8ncfeVhtDon1+SlGOsWFjZEHmJmGR7R4DQLEaUnxZnOLZYdRrbH3FHKO8d8B XKHLXERaV1m9Xl2HxDvWmAgX1L62aJdOeiq/munieDfZ9FJ+bR1eiGz8/J71xREDfm16Nb sLWOkMuxXFPnK12RR03lgXqUyBhW/3g= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf04.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684514541; a=rsa-sha256; cv=none; b=EHjZU0eUUE2hPLMuQn+nIYffttIlEj60gSnXTzo1qR6dBzhsWhci//z3n3ji6Y1pVF29AI lP+oYj6mMzdoihfWwftbDkurIU8+7HAtJ7XlUy4M++JfzdQbi3jjmQCOrp+ihbRebxjOLz OQ6cy/i9Y3mvmYj9OtvUXsTfzMJnK0A= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EC4E16592F; Fri, 19 May 2023 16:42:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 921D1C433EF; Fri, 19 May 2023 16:42:16 +0000 (UTC) Date: Fri, 19 May 2023 17:42:13 +0100 From: Catalin Marinas To: Peter Collingbourne Cc: Qun-wei Lin =?utf-8?B?KOael+e+pOW0tCk=?= , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, "surenb@google.com" , "david@redhat.com" , Chinwen Chang =?utf-8?B?KOW8temMpuaWhyk=?= , "kasan-dev@googlegroups.com" , Kuan-Ying Lee =?utf-8?B?KOadjuWGoOepjik=?= , Casper Li =?utf-8?B?KOadjuS4reamrik=?= , "gregkh@linuxfoundation.org" , vincenzo.frascino@arm.com, Alexandru Elisei , will@kernel.org, eugenis@google.com, Steven Price Subject: Re: [PATCH v3 2/3] mm: Call arch_swap_restore() from unuse_pte() Message-ID: References: <20230517022115.3033604-1-pcc@google.com> <20230517022115.3033604-3-pcc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230517022115.3033604-3-pcc@google.com> X-Rspamd-Queue-Id: E3CFC4000E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: pfsn3kzydgy5i1y7h3k88q6tmopdodmw X-HE-Tag: 1684514540-646486 X-HE-Meta: U2FsdGVkX19ZLoiIlh9OnwCYwRPCOIGzGhGrDIR041ryuQcP/0nIx2szz7hZjanBVKnUxOGLXVIzqJB26pgLxO+C+z/g/mFc5cSCFhP66KXG6yYNfAJR1ENcYMThA+4QVQ7o/0SauQAeDw0pVFgvqkrUkxZ0d3tSvU4zmOTDLE4ijteIIcsbwkkOhzq4N6uwXK0Nvm3Lc7Ny/yOZxHtnSLEz4sh/EyBtP+UAn41h2qWupRp1wUzpXbTdBJ/UoQn6rQ2v/4sH7MMFKKC4TipyWPxtkdn+KSK0hd+LqkXfnuGy8QkGrtto0g8JtyCWEj3t9Xxvo9QjbAWr/bp46zbV/wyXYor17InaT0sVP4cRS+AtQ4xBENuFgzbgMCSuyhIhxmca1P6hbbwQxS9aiyGmQKTqWLEWR+AfZGrGNSnEnJhF3ElODJns53tV8l7WPkQEdRnTIr85gzd8RHdKviN9InPBMO5wEnKRosVyUdAdGstQ1ugwNMuzGwbXz9+sheTL00EhYjtgUIv3fMfw1m7J/wrO2Z6C6Ibjqutpi48A6u3EZrTh8UDviA9ZqZbMWcMSSnWwlzLTrsiNnIb1sQiWVFhHuvFuweOY+QEGP4GKR0rn+m+sLCPzhWdiwBXQy84tfzcsJzwALyLdX7Nx5LVP0KtyMWs9RV2L8HFw7AGhx5Uccyrx+7Nrnq4+9zTXbX8GFcTSV7Z0ezWT2ga9aumBOGzrWwi6e2HYCGGxkU915AVEDRfLNY1j8MCi5aUnOpR9meq1MERgeT3eH5sP+gTiE7H4/xyGyaiFiLOj1cDNmiTtS408nR6Kit6LYq95/jCTuoXK9ZepK52jExG4N3L3nsjT7EdcvTd+AyYGOZ3Dfyz4YR32H2nFSq6oTsjOW4bgRvw9r6uL/R3wSkkXby5Xf24cKMuJDUKwNXF1Z+mIHl1zVCbgtVCoisC7U7t1X5CXNRY7Bfmvf0zc40v/arO vQHs0qL7 iCHFp0XA1TAywW3xHuQYWTGmjAN07mRa2oJZITV8dpZA3GESu4C33jp1ZoDcYsIuuV/mfvsKfGH5J67MpR0N9elviK0iWW069jR1r1Ue8bIfhEKyY0qc2r3PYq7KPeMQgdPj3HZg4UcFxMqxSmwxFT8S1ggQUSwcN1hkBzg07Ca12XPLQvPgalfGl3kLzfpUxTeuuwBz8dYPA+jp41n52604K2XM0UGeWXfktS+nMbtELXu8ehC0S4oVlFiacrDoh9Cv42s+AnaGlQpt+jMzoJWpsDPehZq5z0fPQVPSFFhWlpaC5huRhmYNvIm85ckhO64y1I4Kee55037HgkWWlyUgHSuQpBj8FgnD0LJgstIT0LgOYMh9MnjdETfzk30RxHPNjR1cMgE6D9gqarSX9Ejzvfkq3xkMQmSJohv3LNk/eSY6cYHznGErbGX90l40U1OvsyBM0V2qi4ZGAca1TMqLc1yQUWgNqIGg0Jkdx2KKfQQAS+E45bk5ESYONYp+TfmUY2EmBQS6q0NWhZhH6WR5J9w5M2sbsaa+5M4NTXjT6YX27AzBUFRM3ws/lKo7TcR+9FTzG+SOOCiPFO47qx4d1lAkDhCowinoAh0cKbP142Ur9GZIIKD/89871hCWVo+9Qmg0bf+rVWsw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 16, 2023 at 07:21:12PM -0700, Peter Collingbourne wrote: > We would like to move away from requiring architectures to restore > metadata from swap in the set_pte_at() implementation, as this is not only > error-prone but adds complexity to the arch-specific code. This requires > us to call arch_swap_restore() before calling swap_free() whenever pages > are restored from swap. We are currently doing so everywhere except in > unuse_pte(); do so there as well. > > Signed-off-by: Peter Collingbourne > Link: https://linux-review.googlesource.com/id/I68276653e612d64cde271ce1b5a99ae05d6bbc4f Acked-by: Catalin Marinas