From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3C47C77B7F for ; Fri, 19 May 2023 15:47:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F703900004; Fri, 19 May 2023 11:47:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A778900003; Fri, 19 May 2023 11:47:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79754900004; Fri, 19 May 2023 11:47:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6A6A4900003 for ; Fri, 19 May 2023 11:47:52 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 550ADC0A3E for ; Fri, 19 May 2023 15:47:51 +0000 (UTC) X-FDA: 80807435142.14.514F8C8 Received: from out-61.mta1.migadu.com (out-61.mta1.migadu.com [95.215.58.61]) by imf30.hostedemail.com (Postfix) with ESMTP id 56B7C8000D for ; Fri, 19 May 2023 15:47:48 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=AxFce45L; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf30.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.61 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684511269; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fasz5CKzUC1yAWqOA9RyNvs+D0MVd+kzXi06AjZXfzk=; b=GWQHgifIOZgRckO4t+sfVmzBIgd8EnUpzyurLdCXEqOmPB2VHktikzYRACtgz49A2Y6Kor n4NZk9YClmluP972dES9fYDxW+6553jX8mIBGQWJGdCvRqTvhfxDcbc/l85byhG6fDhSIE qTcHssixlRH1yyAjJ9V5vpAaO9PODjk= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=AxFce45L; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf30.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.61 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684511269; a=rsa-sha256; cv=none; b=WoYt+g9w45c08Dm92LZR19b9g0yAWpMnYnBUNMHuHHdpfUMdSfutdFsnHz1cuPufuNA1t4 G6O3dSKeb/NVPgAsKcr8sFhtrcD7GrFC3/SbSepx+gxUhcY5z+iecWIPFu5oU82E/HBYka ZBRbT+qo7lDhqECIagVQQqr0BPw/9fw= Date: Fri, 19 May 2023 11:47:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1684511266; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fasz5CKzUC1yAWqOA9RyNvs+D0MVd+kzXi06AjZXfzk=; b=AxFce45LR8ceWjWQIf5kqgG5BRwR6+PUEnj0pY00HSyEnOqSZqn0aqvOBCi/BzDY256sHS SW50sek0Ah+C50zdyoyQ/4+nd2YbMLyG7V0mcqlbaV45yfmOyjQZvXihZCH1ptG40sxXVd HA/eg59DOhs6affhHbmvW06YACgdZms= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Mike Rapoport Cc: Song Liu , linux-mm@kvack.org, Andrew Morton , Dave Hansen , Peter Zijlstra , Rick Edgecombe , Thomas Gleixner , Vlastimil Babka , linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [RFC PATCH 1/5] mm: intorduce __GFP_UNMAPPED and unmapped_alloc() Message-ID: References: <20230308094106.227365-1-rppt@kernel.org> <20230308094106.227365-2-rppt@kernel.org> <20230518152354.GD4967@kernel.org> <20230519082945.GE4967@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230519082945.GE4967@kernel.org> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 56B7C8000D X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: pqbrnejah5zqqq5d8hxe8ohiph9bach7 X-HE-Tag: 1684511268-120748 X-HE-Meta: U2FsdGVkX1+QpHPOQk+nLd5IQrMGm9C7+ct+9RO9uG2sbdZUQ/NJ79st68vUWf/eBwH4fojeO/VyFg6PpqBI3+hsso2TfIG1YcK466CZPPcVOkvY/t+LrGgiqqpyTgfeWWgpdR0rsrRDTVlOT/hi6QsAs2a4XgXkYCVoB12NMf4k5pcVkFPFnm750ujbQ8G80JNepNCQoJ8deVL7nqHrLnheDRhw1ZfhzOxgTqjI1+GgnFs/gauxaUvl0GAwzjEL4nkppEaQArC8Od6pmmHr+EBtNbuPTjHRYBxP8yxZ3FyLf3cynVRL3FZaldATjSY3I3bhmFiyl8PkI4Ikf2yGCzOotDoE4Dyutob7rGg6i4KTkMEJ4Nj8doz4UlX+Lav0V016H4XxXv+2SbIaW31W3jkHrGduF59vCR/3Mo0JvTTWuRlBKdGV2PpQlkSdeqnisIksCiC4FJ+cIIoah9MYdq8azsuCzWFhw4fMq37iXN9YbnwNbXPae0Ds5uYqvN/Gh+2O4J0AOwZD7RYyKD4LiwLvxH7hf7rVdjaIM2LMFtgTCUmbEzMgnN7RtV3JWkcUshMZwh/wuluH/MtEPKACA2W0D5eR1fmXDIs0cjQKtImzu2qZCDxzs/6QmqL2Z6s4nm1hVqIAY7XqCCblCYMZItdc+rTX4W0YNoj3oPlR0Ji3s3RPStkkjjbtLH6YtFqjmTtFeRhkYtGugmkxtC2+y9vh+4amviGq4CR7YuulozFcDruZgVQF6L0TRqv6XsVuByahtkJswX1mHabWx15cw0utDiyGiTiRFE96JVghhyMOw+qiNNVyB4zRTfKyEY1hkwiCb7t+z2ipKoliVMjFt5ozRRyD9QC4c/dp9+GFF882v4vwwSWNR/gCeETHUZu5gSPssWzFU0ATimutOvF3Oi5P7VQN+Hg9hOu/1RrDx7vEeuCrzf2fCv6lOJlBNcFRBYs7OP6U0XM0fgHSKUa d8e4bc4h jnum2BZleFWZ8bX271fUUZOGtbGXaM/39HtddTFbHSDWeqKNlaif2lMVJzBKBuL8YcBA5WIDezTSLxTX703+nSbfKrRoHLc1K903Ufn4vE3dB3desS0AF7lCjIw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 19, 2023 at 11:29:45AM +0300, Mike Rapoport wrote: > Your allocator implicitly relies on vmalloc because of module_alloc ;-) > > What I was thinking is that we can replace module_alloc() calls in your > allocator with something based on my unmapped_alloc(). If we make the part > that refills the cache also take care of creating the mapping in the > module address space, that should cover everything. Yeah, that's exactly what I was thinking :) Liam was also just mentioning on IRC vmalloc lock contention came up again at LSF, and that's historically always been an isuse - going with your patchset for the backend nicely avoids that. If I have time (hah! big if :) I'll see if I can cook up a patchset that combines our two approaches over the weekend.