From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85788C77B7F for ; Fri, 19 May 2023 08:13:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B4A228000B; Fri, 19 May 2023 04:13:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 163E3280001; Fri, 19 May 2023 04:13:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 054C428000B; Fri, 19 May 2023 04:13:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EA267280001 for ; Fri, 19 May 2023 04:13:02 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BAB31C0936 for ; Fri, 19 May 2023 08:13:02 +0000 (UTC) X-FDA: 80806289004.12.8C7E7AA Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf07.hostedemail.com (Postfix) with ESMTP id 0D6F540015 for ; Fri, 19 May 2023 08:13:00 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=bTG1MIwM; dmarc=none; spf=none (imf07.hostedemail.com: domain of BATV+aecf67361b95543ec79f+7208+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+aecf67361b95543ec79f+7208+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684483981; a=rsa-sha256; cv=none; b=ygPI53gGm2HGcCuXSARk+sbvDxjkTXePYvKHTS19c0F64c+TH4WqtZ9P1JOJDG3gBK+zi2 lcTbOTNJ4hGufjeULtsl9KEJwCpKQ72TFnOJokZ7strqBm8k1zdbk/i7qZIlETn0scufAe aRXYzIGbt6LQKds/CZ78yZ6x4NIudiI= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=bTG1MIwM; dmarc=none; spf=none (imf07.hostedemail.com: domain of BATV+aecf67361b95543ec79f+7208+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+aecf67361b95543ec79f+7208+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684483981; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uXfl52cQSZRcJnVzUsCXWUNzcDZE3EsN1WwOwGRya88=; b=oQPH8aVnvz7P+AQmycNgWf8cZIHwPCrRqUfLavtkm7t+Mml9ZqHfcKHMIgV1bC+BOfhPuU iKTD3WtEd0fliDdM3ZjGGHuBManQj9QYQ2RkcGXuND+JZBpuB0UrgyA1c8qt1WQ8p0F1ZC 9nLJA7BqG/g1mxB38pwhmpT1rC9V0wE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=uXfl52cQSZRcJnVzUsCXWUNzcDZE3EsN1WwOwGRya88=; b=bTG1MIwMskxn7o3TpI9T21HZo0 x+2ECxKLocV3YID+i8Ap3pdpikQl1Pu3MwIFYPx9IywDmsvnxyNbIfCw5oBpP0CJwwl+AEreP8ByT VUUpR6srOk1ow+MMeZp1ZMfIW9RrmJ06oF9WTIEBSkZjifPAimxus5iR4eL2imIRlwSxh+h0LUyFO VBUUINYPvlm3IOwMN2rLgd2X3n7UjLslvRoy/MKjSTBRBFhxRIrSW4WKKHK6ZdonjpmlSUjWbg+uT yJayBsH0fwqibNE7Pf5RcupMcCJJYrFOyItkPhuIBQcSnYcqgLh4YBmrNo0Rr5QkdK3x9lz5RM3em PfZOe5Ag==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pzvEC-00FTsc-2P; Fri, 19 May 2023 08:12:44 +0000 Date: Fri, 19 May 2023 01:12:44 -0700 From: Christoph Hellwig To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Greg Kroah-Hartman , Christoph Hellwig , John Hubbard , Miklos Szeredi , Arnd Bergmann Subject: Re: [PATCH v20 09/32] tty, proc, kernfs, random: Use direct_splice_read() Message-ID: References: <20230519074047.1739879-1-dhowells@redhat.com> <20230519074047.1739879-10-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230519074047.1739879-10-dhowells@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0D6F540015 X-Stat-Signature: crkarb3tm59j4kqzmsbphjkhgfxutj1e X-HE-Tag: 1684483980-405995 X-HE-Meta: U2FsdGVkX18F2gRQZVdWynPYolK/a4lCdJ4U/G84Wz/cjTobv0QGxYuCyzD2hxMrXU1wNw7GY7ldRrQy6VXml1VNGHQMC3SfmsBU1xTI1NqUIQXWPXXoQ14ZsxVyKtdXK5dz7kPwnTlgv+0M7lw4kTBYwZOZ6HS4OD7zSz03CYGt9080r/oCPinPC5wizAo0NQ2q9j83prB17UxvzlXglwlkwLuGqcCterYGCPasF9wkYYBNCiKeEBe7TtVzoYnBIfbBK2MVLvG9wX9BwtYZFi78tKUCJrqXVacpsO1kjUrupQUcf7EPaTkbaqa4iGTBpYNNn6TT6RblO3zjB+pINAqk2u5awq5qUGRjPzEy/F1cOIKGVo7czAfDUaYudeFiUE7GQmfvn/AQegIdm/+c5Ga7oAE93GUOp0bUqLKxHetT35yvxNodXU081WnpGFATjT6O3KV7ORo2x4K5HJ8SpKjFY4DA+clzIL3iKlfpip+GY5WYvQ4nXPmM3ZBqvtmrrvTZvc+1ToMoiB61TY+2t5wjSSpFdMLgew3aJAGHYsmvFsJeihgGztP/HdvJ6peBjnD8sr+21/YkAkc++59b7lqptFjKRvNw4BSPUXtwnur9nnEm+LXhSXs/5WSJJV1bJdJXhlIG6ZWMdrusV/aqMQIJPubLxKxfWCTrVBn/QniJXxXPHTZUkHl/uUsAbR/4dQR5Ti/Fb3g+vQQLQuuRSAyBX53qVTwN068FvwOrSwASo+kJSU/XuEsNXYg1HgBy7/0F5zptUnrMG2AsIb3NfwV2JS+iRRoKDiLW2ezcya+wjYiCDDt4mZrxF130zdC/SS+sCmfMIwX+fAb40HRRqBJxmFci6+v6LoG0w9LEYkt6AECVxVTexIjvAMak/JW6e/1APIrDHGKVgrP0c1gW4T5G2hd5EaYqZPPz8YwX77QjtWiwdlCahh4odBYHpyU/8+WgNIVm/x7dUYCetLa ICN4bbWI 9SQp6rOvl1CSbjfBFCy7V4qJEFGBylAhm2FHKf4cnzyz/4mSmQiVTcgKE5UooaGrzhar08J0G+nXEtZE3l8++X1P9M7mAaFQNMhRoNTvbgSSVqhVGb6kW1V51fitEQNhBrOYKoQFL/QFC0dilPuKG/MpCb+f8XSS0h80aPXJ4fVBb5iBOcBLROUeAGfhKV5gafTI9npWcykYCyfqgPKi2xQinGhFKAm+r6nH5IryEZ38H9IEaTAtApvjvu7FwDGQCcgmeq6d8XhIV0VtwZxCJIozRI35wTw7ECF3oTnUjWLu3l5yA+sP+V9Ha8f8snbGvBbiTvrzdKrx93OgitSPcWEwDoAmkNBJsfusZ8l/v1qCxprkZSYPGERT8CGm2Z+HmmOAvhIBnpHupjpuBoaSEpamfd/oTAVA6wx6icjtTNGnERDjfh/PhB38gJw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 19, 2023 at 08:40:24AM +0100, David Howells wrote: > .fasync = random_fasync, > .llseek = noop_llseek, > - .splice_read = generic_file_splice_read, > + .splice_read = direct_splice_read, Pinging Al (and maybe Linus): is there any good reason to not simply default to direct_splice_read if ->read_iter is implemented and ->splice_read is not once you remove ITER_PIPE? As long as we assure direct_splice_read is simply a ->read_iter into newly allocated pages I can't think of anything that would go wrong there.