From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DA41C7EE2E for ; Fri, 19 May 2023 08:10:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 29F2228000B; Fri, 19 May 2023 04:10:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 24F17280001; Fri, 19 May 2023 04:10:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F2E228000B; Fri, 19 May 2023 04:10:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F132D280001 for ; Fri, 19 May 2023 04:10:29 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id ABF40C0940 for ; Fri, 19 May 2023 08:10:29 +0000 (UTC) X-FDA: 80806282578.08.F4D8675 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf21.hostedemail.com (Postfix) with ESMTP id E5F7B1C0006 for ; Fri, 19 May 2023 08:10:27 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="EILKCF4/"; spf=none (imf21.hostedemail.com: domain of BATV+aecf67361b95543ec79f+7208+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+aecf67361b95543ec79f+7208+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684483828; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+KcNj38ck2QF6TY7QpJyCILaVWe/y++Y4IGZh5WM6/M=; b=Myy/lO0F4g9Eo62d2sSj/DuEDM6GtsQZWjvevhFUIBlfkDUQMDB3izHrmX9ArfzpvHJKn5 lxh2fbi5Pw3WmN+BFtFD+Mknrm7bsNL5r/UPvFcKuxkHWMoFTiNauZIrjdFxcAjo3zgCKw K5V39x+iPdhqfGaOYZxLqK3UMLz7hSI= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="EILKCF4/"; spf=none (imf21.hostedemail.com: domain of BATV+aecf67361b95543ec79f+7208+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+aecf67361b95543ec79f+7208+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684483828; a=rsa-sha256; cv=none; b=KfKcAAAiWJNXAjbOWt+qvgs/bTexql62Vc09B29Adv5vvxqvxSlt1PMqFuTbLi2VLsxVdf 9SwbihXHPi3ipjqff4zWm4qKzY8niONxSMK+H0EdYNABikW3pWtr6fl0i4NX53uM+HV6/F tBhMNMxxsNyNDa1Vf5jQBok+KjLCsWk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+KcNj38ck2QF6TY7QpJyCILaVWe/y++Y4IGZh5WM6/M=; b=EILKCF4/UqHDv9mi6SKDXcFyKo cdPd47QMCzDlG6o53QlCOZOe346y4W9Qkf482gpqYE3gnzht4wtpO8bPsKhN88Z1V7bA3Db8afI+a AXjbJoheJOfgmY3ClNKdB5NG+SAihzQ8ygcip1mTQa3a/yMSlFdtlOaI+inmDt9/rX3/Iq+SUWh43 5b8SVHjGlgO1c8NDzCG7QO5EWTniG17r2GqzTzSNFMw9WRcUSC2GDnliQsbXHRSbqOefid93BsSYs nNdZ7yByE7x/DcRlMKe5+ZP/35erKJjLRwgXmEqguAL2yYFof6koWpAEd8a4I+5kO2VK19jNow573 Gz8nMSDg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pzvBo-00FTbc-0R; Fri, 19 May 2023 08:10:16 +0000 Date: Fri, 19 May 2023 01:10:16 -0700 From: Christoph Hellwig To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v20 05/32] splice: Make splice from a DAX file use direct_splice_read() Message-ID: References: <20230519074047.1739879-1-dhowells@redhat.com> <20230519074047.1739879-6-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230519074047.1739879-6-dhowells@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: E5F7B1C0006 X-Rspam-User: X-Stat-Signature: 8ispbhusxe8ed94mgaer3yrhr91p9uaf X-Rspamd-Server: rspam01 X-HE-Tag: 1684483827-425901 X-HE-Meta: U2FsdGVkX1+UfB2rNmDFU1tBtZ72tTbjiixvNUgGqqPmAhAHdY6Mc3BvD3U52BrHv5YmtqIvcA1KmX13whgHXeHg7cSHRWfyNvMlHI8qYDpiuE6DEp0S0wXlZPR3Fpc/whexjzU+0H3P7rWABYUWSB8A7fSJD4RF77OudBZA1XAUPt8fv9m5GRAxWUe4RMpF/mZbNtEVFWY9YMb8K0D2ZyhSdFh8AS4aBqmvo4HZpBId1M0nuABDTVCdB4E8oOfxlb+i4bc83Mo2twua5nmvHCqggoUKwvgXRWOQ0sypahkx0I9CR27UVoRMzwyKCp9y+mhWmr90tAsEcq6WubGj6DWFTJwLTNM3xeVp8XrDhwNLl50aG5Hpqqn+as7P9PBGIMt1bv4tfbMWBjfEwG+UXFFZeBNhpARvfPM9EHcUKVMPGQyxMQ+dT3IN9HGyibY3GbCZ61ecXNRW+ETg0ICPLqAfalFf0CxkbtOU7OvaL5xDoTzePs9kD904Pmjlh5PW+H7qyA+qWS4DgrxqOCHsMvFdUbwafTCj956U8ZTSX+UjO14Ry8rFLy4Lk6RsuAZPNK7BNn6NWpc6JMSI1IEmB40opdn+VwrqUOF1z6/6TLbvGNiHMA8vVR48q0C13vROiy5YKfNu2huAT6kEaF+qZ0mc4AgzccMQBIye0Ee5Imsheif0ouU/39vAo14jDrsN0zAPa7KWkmEIUb57vuV7QTc2zRm1GzOYRXuHFTjRLiN4JKxW74LGu7tCn4GylxuNxzGsIBw/RBiFxEMwNeTf1dh5JtwxMs8vtVcNYkAlvJz7iB70ehiEI99EGQ6eeVZryzcVbgTjJVBSg7F6qbWhAFkKayIssOs8ePRiyMm7tUFfqnPxiujNHq8nPeqOhVS06fpWY/4Z5MpDpcA1JW7wuWpvfng73DdXSeyStAvW7ETnBhEKpkuSdPCHZkQzZTHACyLTaI5/9SDopWq4JQi UGpFVVTx nFGWf2TKpLWOje5EogY1Cb1pqHpJxRhL9wZPKyo0+KQZM1S+a6TOjq/AiB1Tlgn1sgYreT9B7AELty7JTfZfzw5GkPSDE+EdXC8Qzlf9TzKKyLWE7u20uIZGjUK62g+0bJwyF/gbSptA6biEppR/PgqDy585TXo1p88t1nAuGgKSF/srcotw+DtImgOGZeyu/TR6cT09mXoCscVp2/uS2dROCA6gAU7vC6PhBYppp1mOnKGWUbyHV4xXPetthLGmWv8NVIu9WbsrbVOp0kcuDFXcA701ROmHKzzYLL9w6JPOqPa0G9Ok35nJc6gXGjLA7e3Q4IlEH4XIYmlTHu0bO+pwmF+bMqllHQmbeFNcKRlvlJRY4izEYIY2BM0RRxkcXGpGPuRIzJwog8BQFytNjwXo5r8azJbGm/zCohz/j1PjO0cipy4UmpGhbgg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 19, 2023 at 08:40:20AM +0100, David Howells wrote: > +#ifdef CONFIG_FS_DAX > + if (IS_DAX(in->f_mapping->host)) No need for the ifdef. IS_DAX is compile-time false if CONFIG_FS_DAX is not set. A comment on why we're doing this in the code would probably be useful as well.