From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 911AFC77B7A for ; Thu, 18 May 2023 18:50:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 26930900005; Thu, 18 May 2023 14:50:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 240B6900003; Thu, 18 May 2023 14:50:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E188900005; Thu, 18 May 2023 14:50:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F38D7900003 for ; Thu, 18 May 2023 14:50:39 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B42D7140878 for ; Thu, 18 May 2023 18:50:39 +0000 (UTC) X-FDA: 80804266998.17.46A5406 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 048D1C0010 for ; Thu, 18 May 2023 18:50:37 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf10.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684435838; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6Pih+1jDcFz918wY3btwxKfM1EYRrSVXnCnseu6TX54=; b=H1OOWhBhl+UkLx5K+X7dRSTCzZcKpziBsuIDSQFY4ugH6UPv28doY5dYjRmSQbIB9Twuhf vFArTTcZ2D8s/SVJgiFR3BTq9HzZdjiRgjPJDWKQbyHYnf23pLzxged0ja+E7n6FtTBts+ QD6dHklF35kifGby2rJKebxE/O1hssE= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf10.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684435838; a=rsa-sha256; cv=none; b=kfj5SoZ7sgVhp1OKXZXyDOK1YhVo32LCVfrs+7jlR1CMmtABYrBptxznCr76UdJeUJY3m3 sBCb1VF8Z5SHKASyPFwSNjuu7P019AmoYSoUwj0TI6KkA1b/6BSYsO66o2V92A9bjX70Os A5vtAHij4ixlJLig+siEXPwt1m7MU64= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2EAA961554; Thu, 18 May 2023 18:50:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26AFEC433D2; Thu, 18 May 2023 18:50:32 +0000 (UTC) Date: Thu, 18 May 2023 19:50:30 +0100 From: Catalin Marinas To: Ard Biesheuvel Cc: Linus Torvalds , Arnd Bergmann , Christoph Hellwig , Greg Kroah-Hartman , Will Deacon , Marc Zyngier , Andrew Morton , Herbert Xu , Isaac Manjarres , Saravana Kannan , Alasdair Kergon , Daniel Vetter , Joerg Roedel , Mark Brown , Mike Snitzer , "Rafael J. Wysocki" , Robin Murphy , linux-mm@kvack.org, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 00/15] mm, dma, arm64: Reduce ARCH_KMALLOC_MINALIGN to 8 Message-ID: References: <20230518173403.1150549-1-catalin.marinas@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Stat-Signature: 9eu4wq5okfkp3f7xxhq71wdwennu4st6 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 048D1C0010 X-HE-Tag: 1684435837-140700 X-HE-Meta: U2FsdGVkX1/NIBMutB+oZmBcBbb+t45dHnalUMj6d82ywwN4LxRGc48eGri8tUJy0ci++O9d0BjjwJWrS65Fj3e592dlhgKJkYkIIZQWPgTQNhuBP6nLZraSC6auiQ6nnLsrdwrQt3Ta7uI0VY3VLljbK5BUjjESQVVy90NYGOD3uno63FjoHbNzxPc3PoKtDSPmWfVk5HIJIVWgLeu7tPAeDE8MtoZNmZseCvRlhXu5hVSQiOcIzw6l05W6W1e8VZPvE1N8PEsoN6VqA9NIRtDFIo5ZhN+7LxmqU4jzPN/98pqwLUlyXn3iYjj1AR5rE3bxCVHjRrR3blMLz1XR18cuFYM1FwETtvKeTp/n31vTtqfa309B5pKUzrSUfcVEjlVHCnKE1kDBekYL4Lv8rNoHwbY8/IO6CUdLWge9ca/L46C2jgqMmM7TOGHry0E+DKUU7Xasop5Aw3Ae3dnpppreDAj0F2JjQHytX2Kva81rm7coRqO9vkr9HNk+TSpkiRhw5MnG7abOsru8AG6fpvfYgjJeIpU4wRwfV+t8BkAIkUE0dB1s2C3FVTYzljwCv3MayzJQmRtjWZtMeWsYLU0vBXfRI6ytlPuh+VgQGj9hXhPZ5eqgpeFRRAEO+aK08vVUitdqCJNQfOw5W+0zzJ7cFde31AD/A8qfaAXP7TXf6nmSEEw1dI882kP9pO40njomgku33p0bP89jxLU72jkcbkOXuoFS++xhGgpgSZUejSBqMZ53jVzEqNNdMyq7DZF0QETGRixTt4MCneGzLiJl+CQAJNsZTRuJaJ1rEtMmT2YpuFOmoa72vdnZGV0PfJTWfpsuXeI5OJAY8GQeZYUyxAq0lybZQvNtgsBjApGN3gSroFOXnY6jTA90TISnxlFcHX9+D15IP0xW7gf7fVDpjXy03KaadFoDsl7TdYIk9Q9qPDJdaFMx6vFSeWsYxxriEtpQo3SzND85OLs 90Y+SiX+ O/+INWyW7BmdQWEYEzAibSOB64fOVmPMvyzeBBaithWXcDwBRMEM/ZA/ZYiOCYsdgOQ2Cdask/6XjEdjRDNuUUFElSgKQ3BNwO13htJd3+J9IT/vvhgzD8bdJImcz8+P4JCYOt72C1V+kiXY/mBLyH+mQYKWZqu2H7IiaGKr9zaphgJEYLYPoDEHavlxYzCklFauEnQal4FDSKQULM9IXwJajiiK+gKbPu39tj0MwaQ8M1pyXkdoCOVfnPGousZV7A/+qSAIf+vMhZaNk0zOrdjiefuCbkfD3GOeHQd6fisIPE9QQ0dmRjPSm4pckhOLnrrI2W/K7CdmZaknqb8BIDO1lsDELCdCIs0x54dzmGWWRsMUUJq1AE/ov1cqK7swH88/tk6LdOTpllKW0L3HwUfqyHTwSlg3yIb1YKZB6Z+SMdRtm/VtDiVmaTt8HkMVs5Cjvsv1txEiflp1cKmwwYF5H78dC1hIKVqlIVJOmcHgCVi+fVwSUD9qwqQq3XPCkji+3yWBiDV8rYZmSKlrX8UHpnL5j76DuahEdpmo0H81Y7y+a2ATM+zhBYKlc4h8XgSzt0I2wvhvEUwx8sc5egFhqtd22OnrHnRQwAxuBXQP9WqfVzgEYy+Va4ymjT6mzeaQEVn+paVoTD6s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 18, 2023 at 08:13:08PM +0200, Ard Biesheuvel wrote: > On Thu, 18 May 2023 at 19:56, Linus Torvalds > wrote: > > > > On Thu, May 18, 2023 at 10:34 AM Catalin Marinas > > wrote: > > > > > > That's the fourth version of the series reducing the kmalloc() minimum > > > alignment on arm64 to 8 (from 128). > > For the series: > > Tested-by: Ard Biesheuvel # tx2 [...] > The box is fully DMA coherent, of course, so this doesn't really tell > us whether the swiotlb DMA bouncing stuff works or not. Thanks. On TX2, I forced the bouncing with: diff --git a/include/linux/dma-map-ops.h b/include/linux/dma-map-ops.h index 43bf50c35e14..9006bf680db0 100644 --- a/include/linux/dma-map-ops.h +++ b/include/linux/dma-map-ops.h @@ -296,7 +296,7 @@ static inline bool dma_kmalloc_safe(struct device *dev, * is coherent or the direction is DMA_TO_DEVICE (non-desctructive * cache maintenance and benign cache line evictions). */ - if (dev_is_dma_coherent(dev) || dir == DMA_TO_DEVICE) + if (/*dev_is_dma_coherent(dev) || */dir == DMA_TO_DEVICE) return true; return false; -- Catalin