From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FAABC7EE23 for ; Thu, 18 May 2023 17:25:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10294900006; Thu, 18 May 2023 13:25:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B377900003; Thu, 18 May 2023 13:25:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EBFF2900006; Thu, 18 May 2023 13:25:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DD417900003 for ; Thu, 18 May 2023 13:25:23 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id ABD551607A3 for ; Thu, 18 May 2023 17:25:23 +0000 (UTC) X-FDA: 80804052126.08.AA19573 Received: from out-14.mta0.migadu.com (out-14.mta0.migadu.com [91.218.175.14]) by imf11.hostedemail.com (Postfix) with ESMTP id 3DFFD4000A for ; Thu, 18 May 2023 17:25:20 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=NlHdP7pv; spf=pass (imf11.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.14 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684430721; a=rsa-sha256; cv=none; b=MU6fUYhhZykvmIcwI9eAbHn2izzodWwK13oJOoyEsfnbe87LQ5dn9PK9U6/S4AWqd2TzWF dEDRGWP2uZ6DpxICQWfjR0Aq1dsQS2IrsVWFDpRJaP5Bs45jr31heVnuAyQ3hA9yG0SluC EZis/IX2iaiXxfYxWJ4cSC5jIv0NXeU= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=NlHdP7pv; spf=pass (imf11.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.14 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684430721; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mKqBpaoltAO/ajrBPZAlORTTSmqeZGbRlc1Dj+Ak9FQ=; b=elcOKY3rBuSLlsBxSqDOTGvqIynKOJbbxmDZpdqUwjQ3LwWLSKi0imxeSJg9FjO/B+riqd NGRDvt0RNan1mZ01KxezyHAsABuW0aZPvTnHc+JyrlFnBMBmQ4XJaVQpMkVNZincNajz8z oKzNdPS/YZX348POBwU1b0F5GbBzJHw= Date: Thu, 18 May 2023 13:25:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1684430719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mKqBpaoltAO/ajrBPZAlORTTSmqeZGbRlc1Dj+Ak9FQ=; b=NlHdP7pvitZ3Unyi3tJqwD9jSc6oHRWYCiWz1dHu+mowncFLvy+eVV7dBvr4kRI1yv9R1a U4mYOUkAZgQeYRNwANPI8pv4VmrJQmazZk57dwQRetD27qbOsn0DJDzy6/odivs5V/hp3U d7zGBr/P30iyQ6pnf1AgvRGyll5+3Co= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Song Liu Cc: Mike Rapoport , linux-mm@kvack.org, Andrew Morton , Dave Hansen , Peter Zijlstra , Rick Edgecombe , Thomas Gleixner , Vlastimil Babka , linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [RFC PATCH 1/5] mm: intorduce __GFP_UNMAPPED and unmapped_alloc() Message-ID: References: <20230308094106.227365-1-rppt@kernel.org> <20230308094106.227365-2-rppt@kernel.org> <20230518152354.GD4967@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 3DFFD4000A X-Stat-Signature: upjemagjtzqujbqtte6jfpgutozdwgqb X-Rspam-User: X-HE-Tag: 1684430720-874671 X-HE-Meta: U2FsdGVkX18jF/+6lFkctQXRNEGTPsp5pTXpDiW+O6WcGoWd2i1+n63VNXjra31OG+sX4Nl9Xh71Vj1q4hxCbhuem7KCdaWS7meM6MsXd/C3MuL/6D1Wo1tqs8vH/RLIn7LEkvdYpNKT8LloE/o/C0r5TnSVsCIktMf0pVf4KqOefhsGgzWaHWQHRIApp3i8UKiqIA5oVZDgIy++FG3TrQ9It2Y23MUHLWiiXhMI27dnvZs8aZH7dNpH+VljhFA/czddUsBURT4hqhQs/5ciAGoScGHfu1UPIjTP3kbYfKCMB2RQ1+9/Ot2gXYhZWDISSJvMUlGrrx9j6y092NQ67IHkTMKgJ03kJLeuDwzx+5gg8MRLSjYssQh9VvTqylFCn3QJ4NLbtbZ/ScnhmMPda2v9hYm63R78+PEcLV9v5azpoCV2ALHS28jpQ76V/QmNVHC2hIZU0brsv0IAnAea9oK6nb98WVtsTu0qQcOtohXWcClZ/BtWOHMBgBOqiRqNY4tH9vC4PJtl+GvV+qg80Qri18N3bOX4sIvDLLmsjgIxy7fmhI+4plRfwtkfB8y9wygUPR7cUJEqdFjSScJAt7dha98J9xSZ/4YoQJOnZahAxQtMpj4CBzBQet0OjydFnw06ejiN5qrRB1CjHAjXB7VyohhSvT+YIYUE49/PtP36zQa/Llijv8GNhiKHpwUdYzdiK4KDUHjq9QA13EkCGLNFDCki8yEvc5XLp3sutj6PTRkiIaz/LgK7wAjwQSJIdkhwi9hLCg3R743e67i1KJ8XmSOPNyhgah6nvjDJZ2kJSYRcvl04c2iGASNaQf+dlPgP5ULq8ST32tK8vSWhyPEPGXsoj0IzQLbGdZPvfseVzGTTjMfDdUbB470s+TjxwZ5lXehCK0u47TdTKKI394uyWYz6CCc5/TME0hSsJsENU4MTqzAgosCcv4/1ssiLHctuolus5rU6FuT+zdh ZsCn6whT IDfOp/ibfYGOnzntPIK0hp8DdiEGdCGzAEQEX6PM3oFfp5kwrMh4pBZJtH/ISJJDwi67ziLdLTqw/15TjKJ0QRIubHn6/A2sfD2sa X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 18, 2023 at 10:15:59AM -0700, Song Liu wrote: > On Thu, May 18, 2023 at 9:58 AM Kent Overstreet > wrote: > > > > On Thu, May 18, 2023 at 09:33:20AM -0700, Song Liu wrote: > > > I am working on patches based on the discussion in [1]. I am planning to > > > send v1 for review in a week or so. > > > > For reference, here's my own (early, but functioning :) slab allocator: > > > > Look forward to comparing! > > This looks similar to the bpf_prog_pack allocator we use for BPF at the > moment. (search for bpf_prog_pack in kernel/bpf/core.c). I guess we > can also use bpf_prog_pack for bcachefs for now. The code in bpf/core.c does a _lot_, my preference would be to split that up and refactor the bpf code to use something generic :)