From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DA84C77B7A for ; Thu, 18 May 2023 12:08:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8AB4C900005; Thu, 18 May 2023 08:08:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8342F900003; Thu, 18 May 2023 08:08:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6ADDF900005; Thu, 18 May 2023 08:08:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 57F95900003 for ; Thu, 18 May 2023 08:08:21 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 22273AE1CB for ; Thu, 18 May 2023 12:08:21 +0000 (UTC) X-FDA: 80803253202.04.793F66B Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) by imf12.hostedemail.com (Postfix) with ESMTP id 3C30C40019 for ; Thu, 18 May 2023 12:08:19 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=jXhbGwJY; spf=pass (imf12.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.219.52 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684411699; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vlSicM60M4dOjJmxLJdTJyVXpqMpmrkkdEYFA1QkhPE=; b=0FgYhjV+hnF8/thgQXoGKwDz3mC0AshZb4n19TiJ90YqcVJqxMUhFlZL4q1aMEgS+cPikC 4F2b//5BFLb6HFuFOFVe+Pl0Dkip7qavQ7D2eZbuR9nVGnY+NsvUfC+T+qV4q3wtskvfeq 4+dmwLspXHD7XdVotIwVTt72IZLqnxs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684411699; a=rsa-sha256; cv=none; b=PWmFSl/AV95oERRa5nk/O1b/uLBKTJ2O8zZ7c4/1k152xyIxa6Gdq22W21UOmlQSYm17za XTHOZw3nA28/3427Vko5bKoPI2eIlPfMAVS0bma59BXe69U6cwuSwFbBwG0PWaUB9yLZDf Hy6YShK4m2lrrbtFTBR4WFwlfr943mg= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=jXhbGwJY; spf=pass (imf12.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.219.52 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-61a4e03ccbcso17196546d6.2 for ; Thu, 18 May 2023 05:08:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1684411698; x=1687003698; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vlSicM60M4dOjJmxLJdTJyVXpqMpmrkkdEYFA1QkhPE=; b=jXhbGwJYk+ucvKbOBXk9WSgeJcL3XBMB2oa3nevNUqtzUVeZ8g0iTX2cviMuUPVK95 BQihpwuuJEweV2yyrM4IL8PBMZvQBL0c3xq2CZieXROU8/pAIGkzt7Du9V84OKSqWVa2 Fmaup6LyQllNdQhTLl6BDsdSt4uKUWNmqAZYSGgsy0Ig9WrRRVwSYBI2WdO+rbDcX6dP ZHDkZsrwBLEfGkdL77B/DNN8d0hrQ0AB06V2qRbzdl6gVkrx1QZ9lhG4j5FVzlai9Vdo CwWrJuIH+r4avhI/j4oqn22bBWtZGlopVE5yl+AqPepXDxbBFyz4orMZqXgaamG+erIA Wopg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684411698; x=1687003698; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vlSicM60M4dOjJmxLJdTJyVXpqMpmrkkdEYFA1QkhPE=; b=in53RAcWy2ZRP0a1xSyAuy/UMs6c9s/Vb6ZR8brkPK80BalXHGzXStfmg1Rl4jJ4XY yUFjSjqQfQx7lctW8wJpQjpOxs0GwhphOEHGw+su0Xx+s/e227t33wEqH2EWTyQNXWfl HUte3Y7R9KlgOswwmWLFNAK6HvBK846kVvwusSOliDPpQFSX+sZOaJMJ0EK0VCybcDh6 VULgboQjhS1PA8OWZ0LkQxCTP8XI13Uh0vVlMvMsG0SXdYLtP7M5AOpae0/dgoJ8YB/Z iYp19MrpIfJC/Wn6fugq2uPeXkxzNdjSGJa0c+vIgCMXaWrPuq5sO4tD6DPyP9KGrSX1 5Rfg== X-Gm-Message-State: AC+VfDyY+GmDw2nlqvvIG4/xk3rozfGRnkFA0jCZSrjJRltvZzf6IhwK 3y+Vp9MPsVp+LJVlnt6Fn0i73Q== X-Google-Smtp-Source: ACHHUZ5mv2MO2EtoWMDVdFMmwyMdsVIazSj3Ntt0VpmSdM56xlcT74f7C5fr+MIKywX+lt8aPIbl3w== X-Received: by 2002:a05:6214:5296:b0:5c1:fa35:fe6 with SMTP id kj22-20020a056214529600b005c1fa350fe6mr5510734qvb.24.1684411698376; Thu, 18 May 2023 05:08:18 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-25-194.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.25.194]) by smtp.gmail.com with ESMTPSA id jy17-20020a0562142b5100b0061b2a2f949bsm469563qvb.61.2023.05.18.05.08.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 05:08:17 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1pzcQa-0055S6-P5; Thu, 18 May 2023 09:08:16 -0300 Date: Thu, 18 May 2023 09:08:16 -0300 From: Jason Gunthorpe To: Ryan Roberts Cc: Andrew Morton , SeongJae Park , Christoph Hellwig , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , Lorenzo Stoakes , Uladzislau Rezki , Zi Yan , linux-kernel@vger.kernel.org, linux-mm@kvack.org, damon@lists.linux.dev, kernel test robot Subject: Re: [PATCH v2 5/5] mm: ptep_deref() conversion Message-ID: References: <20230518110727.2106156-1-ryan.roberts@arm.com> <20230518110727.2106156-6-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230518110727.2106156-6-ryan.roberts@arm.com> X-Stat-Signature: m6fi1xj53qnu49sqzgwsaksi7obycmf5 X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 3C30C40019 X-HE-Tag: 1684411699-642586 X-HE-Meta: U2FsdGVkX18/ZkZXFSP7cCbkpMsati0zJpK7KG/K101R7U20gQ2a9fDTsC4hQ+IsmxpPos9Znhyjt3k7gA5TgQ/e9VJ9MPGJTTDMDtIU2TpzZ9P6hmwJQp5/NOfQCVapQ+FcGbsGbsXh0bjO2TjKgv5tWD7tybhKY2kMg3pl1K2uprAEQ3iEgtuOHEf8ySUTWcY5iB0phGlYuEMElEPf5rsQRwgmt3/9a4DJWHgLabVelc1xhEXWKketTwAkxxGE0ZmtlJTTHwKmf32CkGA1l5xFxqmxMd/atXit43HlAzwwz+OPLBz0P2fLFI0WRNB6fpiRd1oviGJgo61wGEc4H6TKqfAElrQ74oohPKDqKybFCX01Kotji4uZV7ysBDy7JyQWff3ddMi7ikTHP9LbmWnzBNcaJuy0vJPP7aY+WXLbu8cjDUwcpFzEH1k49dkNyoAUjmy93W9iKoix7nXpH2MRJaRCGx2eT0WdabM8c7ykEopiNIe08hNOT/VWKUfkr/uq8xbNctV3bUZHwrd3X9Visv7DoC8ejrM7U5VILlcUbJ8ysT59cjV0UMtQReK/9BAhlNhixf/GRsRykB9XJZI63deL7ujvS6e0/Jjte6Hp9FZqfAVUqxsffpSQxGDMj4vCPYtFa/3Q+f7+9TqZbcCXMaaIYnxSE/NnSR1swSPySIqGTXs9XsKQZzEqDw4eYiNT1He8xoFyQezbCSHXfqYNL0m5NNFj5oXf8pCPUtLIRb5TFzEcEyIvvLFtf7trfflESdRnHG2ZsuBkgpiQRGiMkmrXdL0KKKvvPLof1IH+hI9Y59UVjLmdZ+36nOtsBP0sqLRkAKyToHyFIMkyTDjnV9KyaI/f+wa02pxSAEl+bD2jas8x015/U9I5NM/8YGl+ZJk9ejs0kv2G7u7w7EW6oxU/IkCR7/66YRSuIN7iOXJj4OgRwC+B/EG9doDhFoRz1LZMQNTtDFR++HR YpZburue /rp4ux4snMWvDdQXKrzF/YLnJ6gwne9rQ6Z3yNaIqmJS/9HrSoZUJ6CUDhE9xSHtkzF51lcklzwiACGjU25EGeKYcIJEuc0ae0WR+rnbIhRqFYgAdCZ4b0cPBQtW6Na2AVTWabeZsdvmF3aXOtjPzql8DDIpTMWDd+1wy0YuDXkN4HXf18eMrcVES2GzwEmXDsR37V4IGsThv21o6qWw7TuESXSr0muDov86FoV7oM8+IOjkV4Ydq6lJ7oa3FJFOZjCxNO7FxSCYkao0hQoiXNEDSRXePPreWrPCv3htdNFfihQVFaajyTNNvX4CdvbxCcIEA8CcuM0Oa7e28y7JIE9Lc1HSrHYtAAQUYahAygNE6YxaLm2tcvk0DRjbdGXyCz94mu91y/8aNan8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 18, 2023 at 12:07:27PM +0100, Ryan Roberts wrote: > diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c > index 3d4dd9420c30..5680542f744f 100644 > --- a/drivers/vfio/vfio_iommu_type1.c > +++ b/drivers/vfio/vfio_iommu_type1.c > @@ -514,6 +514,7 @@ static int follow_fault_pfn(struct vm_area_struct *vma, struct mm_struct *mm, > bool write_fault) > { > pte_t *ptep; > + pte_t pte; > spinlock_t *ptl; > int ret; > > @@ -536,10 +537,12 @@ static int follow_fault_pfn(struct vm_area_struct *vma, struct mm_struct *mm, > return ret; > } > > - if (write_fault && !pte_write(*ptep)) > + pte = ptep_deref(ptep); > + > + if (write_fault && !pte_write(pte)) > ret = -EFAULT; > else > - *pfn = pte_pfn(*ptep); > + *pfn = pte_pfn(pte); > > pte_unmap_unlock(ptep, ptl); > return ret; This hunk looks Ok Reviewed-by: Jason Gunthorpe Jason