From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B5DFC77B7D for ; Thu, 18 May 2023 03:46:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D97B900008; Wed, 17 May 2023 23:46:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 98A0A900004; Wed, 17 May 2023 23:46:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8519F900008; Wed, 17 May 2023 23:46:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6D98B900004 for ; Wed, 17 May 2023 23:46:14 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3E2221C716D for ; Thu, 18 May 2023 03:46:14 +0000 (UTC) X-FDA: 80801987868.22.C9CFFCB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 734681C0006 for ; Thu, 18 May 2023 03:46:12 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="IT8xCs/Q"; spf=pass (imf21.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684381572; a=rsa-sha256; cv=none; b=3M3GBbMX7/RVpiUbyyaOGfctGqtYwT3QC0kd7KMo8XI+iuCprbrHOV+vDUl/VjhBw53ebp Kb46z2+spGeuYZ67gs8BVEEx/NJdskzRri6aq1UotAIZWd//iUyj8ksXCMkYPM7OwUHEFG S4FGJEXg39em7fAaJTvQLIr8s5koF+0= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="IT8xCs/Q"; spf=pass (imf21.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684381572; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Rb5WmlFpGhegcLzMxPINZKl6stSgxTh3qbMWfHpqSrc=; b=wwK5pyQimncKg/qc1IH5J6LKaiArClREY1cFFbcVy+ozIanrfGirskc3F+DsAf5g3oHyVm g7is6RUoAqIRkswU5kmD0SM75yR+YOOfSUV6WYIkdYISyRXps3tYLk2qRWTG9BkM4Zd2oy DIrqgmmxlROk8z9IlZD5H3WFMrVutk0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684381571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Rb5WmlFpGhegcLzMxPINZKl6stSgxTh3qbMWfHpqSrc=; b=IT8xCs/QpydRE9PDQRMlRKEfhsxyMv8Y8Bw46JcMXd2v7CdZccnjJ9B5T4uC7V+hXJTrRZ IPy82HJC5bfeYe+Gk61an7SzIVAsIB+XyMuuVisoNAISAd2m/h1ndhUJ8n9Ldxyv9cMhao WUknTIJp+sPaGsfkdyoCTAICeRQXpms= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-252-1CtSCAzqMoCBrsca4AJsrw-1; Wed, 17 May 2023 23:46:05 -0400 X-MC-Unique: 1CtSCAzqMoCBrsca4AJsrw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E1F5A296A603; Thu, 18 May 2023 03:46:04 +0000 (UTC) Received: from localhost (ovpn-12-79.pek2.redhat.com [10.72.12.79]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3D6D24078908; Thu, 18 May 2023 03:46:01 +0000 (UTC) Date: Thu, 18 May 2023 11:45:55 +0800 From: Baoquan He To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de, Yoshinori Sato , Rich Felker , linux-sh@vger.kernel.org Subject: Re: [PATCH v5 RESEND 11/17] sh: mm: Convert to GENERIC_IOREMAP Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-12-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 734681C0006 X-Stat-Signature: n3g453w1ch6rdar58arjor6uhkksm4rb X-HE-Tag: 1684381572-995827 X-HE-Meta: U2FsdGVkX19+ecF7F0bwr3LoVQFT5A4JCSrxg2R7yFN8AtFqXLGZDz/au55nXeXYhOP85EFL5nQCkwpB8tos4/njGDXLnfi6z6TVoR2PGIJqwL1MTRFNtxbS7FljGX1z7HD04+ypctmtajstMf48mrN1cl1qRcI7xcSczWdI0Mrawa3IM5O8Pu8g0ceq9yvxAffmKaqqOTpheuKAPhbGP8GDOmjGHhc/DC1/7Q8o065hJ+Z6J/koyE18ikrx/o3Be+2qWKXYh6MyjdltmJreMMZDSILh++0NAlMnPnoWcxtAloKphmYwAP7uxE0o2C3U77oNgqxJ8+fxGYaxuFeLTyKm8lRv/2zVfnUgHHLaAl8kujpwkFoQWjqdAbQ8PFuq7lNbaC+VWTeKQprBRLytG0tyKyiv8XsOR3dhXw+J6zxz8YFX+40AnWHRUjkNZCxQ0+huHA1zGPxBbUPVVn72mC7z2O8zSWuy1DLFN5v9Kqa3nZNMJ/IvCTD+d4P4exwW1flxSU9lM7g37CbhZ1yF07IvcYnTwZrwKkq0OBsAwgkQlQTZtYDVb6sB7asxsq37gV+29gfEJp3lFCnWWDx4Aw0jTP9fdFCtkskj3qP0NGOzFK9+8/eF0H8qQYTv8aHr9k3Yh6j19/lvL3iFVaLrsf7kE7iDoNNYIHXxFS6qUR9tC0Rbnb79kzErmUzgTJjZIh6L9yneGEID0Gc11bVafBMCql0er6SqwFxOYsCTNEPcGwHbDw69BHOYUlGdG9i3z6odVJYMR9etQdCBt7c8eNtX10ApVWnxLDYB24je/6bZBcO+fgb4jQV3DHotdpX52VlqEZm7CneKNbvtwAnIpNGUBO2R/0EnDnM4oBNO437jVFUEeULeBp0FZUxePENqQPIfobcCPDn8q3oMhbsKYMM4rvKVJTJupfgaZRz+Wglr3b+p75/4fYxt/X+ld+a8CP/HRAzSbuPviN4TsvC F28Q0o25 nzqdZ+MKw0IXbj6rB0p2ocGIoQujzZ5ryS7vMhp7UMm4by1V1N7m18u8IhofEib4r3RMWyuXO4bba9atwOeiy4t41go5PBObVJLw/QokcbFOP/VBQG1xpeLFTdQbD+rXqAhyyVLPexVWcsqX/+7eND4xj01WchuPfCYd6R13QAqMfFosUpE4vC0/GS4uL8BEsiQDtLRaD+W5VJ16DEcUe7TH+/BFqvkXO2FQsGqcRZpAI6uZeVas5+kTWKw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05/16/23 at 11:37pm, Christoph Hellwig wrote: > On Mon, May 15, 2023 at 05:08:42PM +0800, Baoquan He wrote: > > Meanwhile, add macro definitions for port|mm io functions since SuperH > > has its own implementation in arch/sh/kernel/iomap.c and > > arch/sh/include/asm/io_noioport.h. These will conflict with the port|mm io > > function definitions in include/asm-generic/io.h to cause compiling > > errors like below: > > Please split that inclusion of include/asm-generic/io.h and redefining > of the helpers into a separate prep patch. Will do. > > Otherwise looks good: > > Reviewed-by: Christoph Hellwig >