From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B66CAC77B7D for ; Thu, 18 May 2023 03:44:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48442900008; Wed, 17 May 2023 23:44:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 40B9C900004; Wed, 17 May 2023 23:44:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2AE3C900008; Wed, 17 May 2023 23:44:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 17C2F900004 for ; Wed, 17 May 2023 23:44:48 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C6ADC120308 for ; Thu, 18 May 2023 03:44:47 +0000 (UTC) X-FDA: 80801984214.08.98084F4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id BD38640007 for ; Thu, 18 May 2023 03:44:45 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FrQ8+VK4; spf=pass (imf27.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684381486; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Mk8aG1TtznZuxqSznasGxarw6oe6FuitdljoVkFwpdQ=; b=eFaAtcvPasgSDN47UJWHQDQA8SJYWgXQsMH/plbGVdRaWBFApxTRpEGj3lKF4dUcjW6Boa /dq5wm/6mJgC4Q7cqg6bUtgBniwfW8IxNL5hJhwZngyIA4kZSR0893V5o42tXLMoNcyteU wNQNrqIP23g/Kyr0BeJgk435pzb2m/I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684381486; a=rsa-sha256; cv=none; b=sMWtX6EhcKJTHuFm1XFknp7IRBBSV+oW4IJtt9/Ct+GN9uRmOp4w++ENjj9IlGyCVYEsBr 5UuUMGBgUmlzfnxPE0kVtXJMVKXXLw6bZgeUpDCxXyzY5WcoPbI8Adhs6mbWuVLgbrGagZ 6O2f/k/ABZlHPBPDUNyTZCktPMnvf+g= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FrQ8+VK4; spf=pass (imf27.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684381485; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Mk8aG1TtznZuxqSznasGxarw6oe6FuitdljoVkFwpdQ=; b=FrQ8+VK4GZxWgbDIYUJfKN1QAbZ3PDUT8O6HxnpugCTGXGieRKoBB/DEGUHzAqeuDQDFJj OQ0/SIGB+rs/7/seK+JwG+gChmZ3SEm3SvQ4cvpS9gQPUPOn7/43c9eGJkgT5+V4jrIMwn P4D4QjluuZAbPBOMlNhKI6Mf6iaIpTk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-187--pcPYFQaOZeXkiw7BBvOeg-1; Wed, 17 May 2023 23:44:41 -0400 X-MC-Unique: -pcPYFQaOZeXkiw7BBvOeg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2E3B9185A78B; Thu, 18 May 2023 03:44:41 +0000 (UTC) Received: from localhost (ovpn-12-79.pek2.redhat.com [10.72.12.79]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 50773492B00; Thu, 18 May 2023 03:44:39 +0000 (UTC) Date: Thu, 18 May 2023 11:44:32 +0800 From: Baoquan He To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de, linux-ia64@vger.kernel.org Subject: Re: [PATCH v5 RESEND 08/17] ia64: mm: Convert to GENERIC_IOREMAP Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-9-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Stat-Signature: tpzgkcxtcgdqsbg4ok5fpfs7qpf1ssyd X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: BD38640007 X-HE-Tag: 1684381485-132202 X-HE-Meta: U2FsdGVkX1+dmEte8L9SdAOsHOaQx0aNeIKR70agb7yquh0RbWPouU0Ck0SS7/H0pHj8d6EffllNzJsrpJK6FjJ34hsrTKKThubziZ+63zd4ECaggpEu0WuLHXL4u7CLDTUoOs0PKj/sPDP0SBzKqE8CRpp6IpmWH4+2gHRk/jWlG6kQInsmS05nPbUN2b3Y0P4WChWUyHFPy211jIBqMUdzecrnBgR4p31XnyRmoZoZ7vpOJrr/n7AbDmK1hUtO/g+ZBc1F4pkSn9J3SYfecw2FqgyOTMUjo+31QZQPP4Bkde2b1qlOTfDyY7WSO3D57yGyhZZBfJ1liRZZQqYV2wk7CHISFpxHT+451yfBQdT5Zi/y/AG6R38JTyXahW0N9BnRNYG/SEO5QbO0tpsqow+WRWUbK1LgbCtk9pzJn/8f7r7oRL34oFxRZRwucxO9JNWh9bxd6nLCISMK2GjSeoB0JjCy2ZjKtktRXHp573CjrvR/NysC14eHJJCUWC/GpUv/QmopOCn2er2FzcrOnwS1IXmFPA1QU4Vod21UiQF8SIgh2RwgWfr7pULs2GTLosC0ftbR48TQA6Wr8+RaM/NJm5QYJ5BFKo95aUG83Glg01dFBSolANY8MpKAqPCTQz+pqJ6+lTl1+vBbLERTfUqG8qP/h2XwD3ktwxQVMxzz3HKnjSDHEix8cRr5NqJcBcISty21KG1SCgZwhf5/9nSCn353BMONUfNj0UoIsra8UO8GQ4WTZ+MYe9+YabfD5seaNWUJsAsNWbDoeMP6OOG33TkbLtnZhtKxfkyNjrGTPM0OF+6n5MbO0zkbsPluwoTpTFhUT1870R9aoU7+u4Ocue7bYDV5uX8mqCQH5PzuJb58EaGTGs+CiJWlCoRCZk5znqXTyThhPQl4cJWlcrrZ8IiVeEgFu+P4rRP3SaSTRs059IiA6Z4Ga7XfVjxnN8vt84qMn1LeY6ceoW/ pqZ4JNRW mRtWUf1JYFH9HMhuIt1YnfpWvT83Nq5VwWM4VRhbn3ZTEa0JPtonwR6yviNkNQUNK9UnUreARyTD7fDIK62pQj90Ge3/hy+DGE6wKLH0AtLaRFUhb66CJs4wGWxxFAcOnbJIhq9t9qgdTKLtKlnhZ4k2pXgawoyfxcyIkbOUnZKtvVDepm8bnBU6DIdtxIXWm8C1r00qGJX7F4dNEaWCk4ze+mqRLXf7h2StEh8lqN1OLwlSTvz1XV2L1JQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05/16/23 at 11:33pm, Christoph Hellwig wrote: > > +#define ioremap_prot ioremap_prot > > +#define ioremap_cache ioremap > > #define ioremap_uc ioremap_uc > > #define iounmap iounmap > > Same comment about the placement here, I'm not going to repeat it if > it shows up in more patches. Sure, Will check all of them and change, thanks. > > Otherwise looks good: > > Reviewed-by: Christoph Hellwig >