From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3965C77B7A for ; Thu, 18 May 2023 03:43:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63163900006; Wed, 17 May 2023 23:43:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E0D9900004; Wed, 17 May 2023 23:43:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CFB9900006; Wed, 17 May 2023 23:43:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3CE50900004 for ; Wed, 17 May 2023 23:43:16 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1DA7180747 for ; Thu, 18 May 2023 03:43:15 +0000 (UTC) X-FDA: 80801980350.01.66DB551 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 100A680010 for ; Thu, 18 May 2023 03:43:12 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NMAaN3tm; spf=pass (imf30.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684381393; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I3ysGB9JuC72T1aDtCFkPNC5a/f2mcf/75CpRKANTR0=; b=v25A5raJOyi7uT5Wf90Btlgsd22D45iWxilgbhGyM7/RIDq/xnuvpSkx8SZJ/u/Mn2uWIq Ci8w2piQvn6e0n8OfnZb6BAExVlWT43Q152Ym7kACLOlFQgYS1iKsad706R4ZRKU5O3YX0 H8OAQE3+lphQu8seyx5YiLKmpjjIg7I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684381393; a=rsa-sha256; cv=none; b=ZJojKVqefiZSzwVPWZHDoL3OO4Bu29o8fz5DrO+/3vnS7WUwu5Rktjj3Y7Nu/d3y5W+hcA Qtx+oF3zQ+BVxUg36xVZ0oHcoDVVjxfX/nOkkwkhZ1kLkjYZ8Ffd+Y6WARlzQ3ZLgVfNLG KjpDOfNlw+KTsGBkzQjK37HfwzwDx9U= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NMAaN3tm; spf=pass (imf30.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684381391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I3ysGB9JuC72T1aDtCFkPNC5a/f2mcf/75CpRKANTR0=; b=NMAaN3tmivzBSmVt9yVv3haCatSzFnhofQIqrb5LRBh4IJzzmu3YlhVS28HIgN55/2TG5u 6AEKZGDnrrLdDBXWGYL6sx2A5Y5EcOqXXoTBROx5yrXKDH+p/fhTh7VapBXjTcfiLWOOnQ 09EcBkShHCZqt9CjS3SIsbrNt3f5Qxc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-191-rQ2DqjWxP1SY7-nQyd_h8w-1; Wed, 17 May 2023 23:43:07 -0400 X-MC-Unique: rQ2DqjWxP1SY7-nQyd_h8w-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 727DC88CC40; Thu, 18 May 2023 03:43:06 +0000 (UTC) Received: from localhost (ovpn-12-79.pek2.redhat.com [10.72.12.79]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B0F1C2166B31; Thu, 18 May 2023 03:43:05 +0000 (UTC) Date: Thu, 18 May 2023 11:43:02 +0800 From: Baoquan He To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de Subject: Re: [PATCH v5 RESEND 06/17] mm/ioremap: add slab availability checking in ioremap_prot Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-7-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Rspamd-Queue-Id: 100A680010 X-Stat-Signature: tgf1sy8d3wnisek8b7rnrfjwyx93hcct X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1684381392-420639 X-HE-Meta: U2FsdGVkX18TDQ5Z7ER3Gp/l3TukjrBcqAv6cpFanuFO+MzU+fYo0s+Up03Z0zHYGSKoCpIfYAHvUHkyiTswYF07lFJnhnq6wzzcTTM0jfH6kd/4fm/xuCavnAIzHeDXf+3DUOOmwU27DwQOX+ie+EZDs9u1jIXCjmn6ckAjY7a9fcuSi8EECAnIUTyw/qIFCwk9MS5SflcYtK/+bmco+lNuupJjlEQ/8MFVwn9mwkr/TYsvuL6xtZFLvlEyHxzMbcLkF6NNvxVqpPNwMvGJgtYhHRJB/bSjjo6BsUReudGkrdmYm5P8+qOBbteYmKA83YIQRT3pilOwe3JCdB58hnN4P4VjZupC65/1MHyibK1eg/z/zSEyFzI6yGlllhYHPRuPB29EO69m9Bko8kDndkCJ7w/qrt0JjAXh6fBNchC9RiXRPTOiPQXjISYUxsceBvS8CjrRRFbBrtzxGqLbZwbV/l1AvtzdARXwreW2qML+XE1oJxDhUdnNDP9m2vp0hao8sXEyUbg+NtqYIzbSmqMlPw0MX+QRV79RVs3TnCs5kt8OUHZXtaBPCkeW7bj49EZldM5wb5pccww162pwEoNZ04crZIpoY2UNTipBVa54kRPpNtaoO1gBh/+8aL6oNmdRCWzXfHGvExTE4bBseYU0t7JDi0TmnkFW9N1pi51zbHMr9CIU5OKtKcyUjMmcOghSXkCBfA5CRPbvFyPxSY3IC9j6WaZ1Xdy29+ZlxQOBXiAlyXJ2eJG1PCwnq3iy2/FpJO3xVlDRx5+2813w1kGvAd4mAud/ZoiF9vdvYoh352kPUAPC9r6vPwIeCRnNjX/+P5E7XmvwhT8x1AB6oj0swounM4/+i7+3GsTtx4kRe8L7psZ34hce69YJzp/6hE6q5n7GT6g/ubmvVJjNI3jxO2jCgVgJD/PhfjmOyW4ZxvGfZiktAQXFrUya9nk0Ebutgg9zQ07Eq/KzjZH G1kvkwQ0 ZVX/n6iVj3ysfH3ChguskWFAnOet5JrMrm2F6PHxf1AQTDmhuACM4rgledl1mI4NOyvOn4IziOwa0xW+G0PHW4vvmDkX7Cz/dr1vSewGStN8dpHGWqxKO9Ys2md9JmilONutfR8DSn9+c/t/L6NkpuZfvOlBKK2jiOxb0/q/K1Rw0KVTESIDypN2xXaOom7Zxq3E/8RHA70zD/0wAVZXpExDQx20vmIhdsGqAxpuVqtCHXKWooj7zZ/zR7nQ+XRIv2cROeEFebNWYRog= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05/16/23 at 11:30pm, Christoph Hellwig wrote: > On Mon, May 15, 2023 at 05:08:37PM +0800, Baoquan He wrote: > > Several architectures has done checking if slab if available in > > ioremap_prot(). In fact it should be done in generic ioremap_prot() > > since on any architecutre, slab allocator must be available before > > get_vm_area_caller() and vunmap() are used. > > > > Add the checking into generic_ioremap_prot(). > > Should we add a WARN_ON/WARN_ON_ONCE to aid debugging? Sounds like a great idea, will add WARN_ON_ONCE as below. Thanks. if (WARN_ON_ONCE(!slab_is_available())) return NULL;