From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57B2EC77B7D for ; Thu, 18 May 2023 03:43:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E95A2900007; Wed, 17 May 2023 23:43:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E1E65900004; Wed, 17 May 2023 23:43:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CBF4B900007; Wed, 17 May 2023 23:43:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B3F10900004 for ; Wed, 17 May 2023 23:43:50 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 921541406ED for ; Thu, 18 May 2023 03:43:50 +0000 (UTC) X-FDA: 80801981820.21.DB9216E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id C5D511C0007 for ; Thu, 18 May 2023 03:43:47 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CYKQnkRm; spf=pass (imf21.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684381427; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0pWi321j2dJQo9PWbhq50nZ1UrZDSkUZuy7jm8koH04=; b=mWn7M2II2gPFRTzBwaCpV8GpNAeQR6nKPsDtrVusFd0+QQDnX4Te9t90k51UdWxBNI6t8f mYciKbJ24cYaI33Z+EoVZAFkBTpYqfA+mz0jqpTEKTvLnRn2J408gH7KA//pmhEknxalHq a+Eu+hwRvXvL7lRW89BIXs5EciFiDfA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684381427; a=rsa-sha256; cv=none; b=77lyklIa3ex24cmGxRvBhHWGazayEas7tL+QygFWT9YTs1uoUhFv66gC/AyL/mYCkwn62D efzaTDbtr34iiK5rmuAZwR4eY1UsA4UCqjtYK8EkZWzkCd6TsK5wnqSZ9FHJsYMRQ4Epj2 TGE5l5GzBl7T1M3i6D0Q2V/1T9XMt84= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CYKQnkRm; spf=pass (imf21.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684381427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0pWi321j2dJQo9PWbhq50nZ1UrZDSkUZuy7jm8koH04=; b=CYKQnkRm4FP++MDqKNWCwXoXS4qtweYnsNLJRY4gjmfRf/ZDYByPD/VI80jFGYFol82DIC vEpRjThDm0Ig8c11k0q8A1oKBrmPhxcsIeVJWtSUZqJ/edrFCCqNlxYL+kymvYU193cZau st0nE/NS3XwOmgQA1rfuteRtDik7+jk= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-593-Oce8fByhNdGoyCfh1R4fzQ-1; Wed, 17 May 2023 23:43:43 -0400 X-MC-Unique: Oce8fByhNdGoyCfh1R4fzQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DD38D296A602; Thu, 18 May 2023 03:43:42 +0000 (UTC) Received: from localhost (ovpn-12-79.pek2.redhat.com [10.72.12.79]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 12FA9492B00; Thu, 18 May 2023 03:43:41 +0000 (UTC) Date: Thu, 18 May 2023 11:43:37 +0800 From: Baoquan He To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de, Vineet Gupta , linux-snps-arc@lists.infradead.org Subject: Re: [PATCH v5 RESEND 07/17] arc: mm: Convert to GENERIC_IOREMAP Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-8-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Stat-Signature: 1ztagdo8bkywpgusy989ntitfkx7m73t X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C5D511C0007 X-Rspam-User: X-HE-Tag: 1684381427-589234 X-HE-Meta: U2FsdGVkX1+SET7i1OX7ADnHQsJbQnwMOKLuOAmXFtLfvbqs2uEAjzOdeZYKA01Gt1LhxC7At+WhczKV3TV9t4qa2wfV3CcbjIuKmSLSEt3sEsdOM8rF7yfcBR6NEvwqe+/98mCMXWQU5PVVCi3UVfSYy/lFZ6pTNmrEozARfa+vqnbZrhtaw4DN3PhvjnFiZORdDRa+nMCJcKb9M2EAQ57gHCpa2Ld82YTW36/WQsuOiwBs+PQswjvGZL8NfTZ122E5e/BRL/Psjf0fhM5+ITt7kazJt7ImJE8A1Ef/kL9lblGiQxV3mq00hIWi7wifofv3qB18du6RG13okeDKo2OWaWantYNmtAmtXaBsINMOUns+Kg/TkuYLE5eW5V2L/b8rq9v1+2NNSQ2cRurz0sRB9Y60/ICpuPH/UEiVS3WGIXbJwJ3LjAIwcIeyyrx+hYu1hjUx8kCsLPyVM78DxtdtjH1s4sN0sqqKen3mHRZFNVslFKxCwcWtYjbzRDzibme8ZNLJPrAvZcjVypqw7UE7PNnHs6OUTNPbQ8WDFb62WkMh1s5KliyHVUMYWeiDxDRbNodgTeeSqg9O3lg7BvDpJFTWidTtJx1t6gSrXp1lDY3Jx589KWZdEeDfzVZR5o9kyA4NEENW53mjBFI/iLZ7p2dkL4lVOoaglGaDBc0Or8zl6+i23IwlQAg/1u3DBtUEhwegCxkOl6+JOg58Xo2tn6K2s9KoRhX5Hlzy/0KqJny1Z5mkwiSZ/6jemURTNSXfNqo13k5XP1BDg3UiNvWgGXNpYCDTk/cgprWl2t8W4ifYAzkmhbcqI6tr8JRdDsZEjDqlYNz2XPRAU1xAUxLCcy1WJ8zwvxjewYpwX2xw7X7uV9J4U/GHOhgJmyq7ZX9jXDWFZF9TD3JmjU2ue7TJ43GiS2z9hBAeH7QSrX+6FayujNxLbmKF/mCfBpg8VULfhf53b0X7s2Dz3Sh cv0lh/eu mgv2mkq3tbL/2180cLZmX7Jo+264fmWCCoNw3ujMIWqRAQ+7F4oRPewGZsc9/TZUoMkcz0jrlZ2AdOXAAe+kRymdseosnXNV9ZapOvYZ5DzPoftejh4fddhzrFU0xap4IrkoaPzjVnU+jb2Dpcl58VWwIBkGs2FFDFaMRjkGqMW9M9x8j/UkHDN0EREjF7P40ankBnYb7NnB0+gWfxE4XZRxeOoDhHYyLRAvwOaWZqzeNgLIfpRIPGrxcAg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05/16/23 at 11:31pm, Christoph Hellwig wrote: > > +#define ioremap ioremap > > +#define ioremap_prot ioremap_prot > > +#define iounmap iounmap > > Nit: I think it's cleaner to have these #defines right next to the > function declaration. Makes sense, will do. > > Otherwise looks good: > > Reviewed-by: Christoph Hellwig >