From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBF49C77B7A for ; Wed, 17 May 2023 22:20:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 65832900006; Wed, 17 May 2023 18:20:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E163900003; Wed, 17 May 2023 18:20:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 45AE9900006; Wed, 17 May 2023 18:20:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 349BE900003 for ; Wed, 17 May 2023 18:20:42 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E8A0D1A05BD for ; Wed, 17 May 2023 22:20:41 +0000 (UTC) X-FDA: 80801167482.03.C1FBBF3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf17.hostedemail.com (Postfix) with ESMTP id C5AD640011 for ; Wed, 17 May 2023 22:20:39 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gJOd+IdV; spf=pass (imf17.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684362039; a=rsa-sha256; cv=none; b=OE8XYHqvMQZOtaMFreKH3q51lJLPeag/4OCHqlgmyza1yh2/93MGLUdgkAi5A3RBOWsITu j/1Vu072LQqIJz0wkFlUlrHyNuFfcZlDtUvYPwg/TahQXO2VxDLkgXftebeszwpFYAlYQ0 Jya/M8r/ljZH3RwRMkE03h4Q0H+AS/k= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gJOd+IdV; spf=pass (imf17.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684362039; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VcaEZoDJHfgt+J9YnbNiKZBp9/Lub2+teMXBeGVG5MA=; b=qf09UIeFbJnGEZPrK5D1WJqQEN034TDeUXil8a2ZYkXp+C9ZPdxH6b8pmbXHRePpGCI1xn s650v0HTvuqe3eZk2EMRtZzhrTF2SLVCROYF26hDfVLUFVaqW75Vo0yAvXnSidS1e8J2w8 qHU0RUDre4+D+eWmJphAEJFT/y/FldU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684362039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VcaEZoDJHfgt+J9YnbNiKZBp9/Lub2+teMXBeGVG5MA=; b=gJOd+IdVD+amk7U9R8iJm3+8K5LL1gA0pRsTkmIWQZyls35d+zkw07ZKwVfpIM1qYyzPBk C6vAoITgNpCKfWHQ+8auOOT+L1H9E/EqNjsQ2JhM4aYCVNAQOIYfwYXHfjCx8JvSLohN4G IKxpViZ2vqzdQJbAQZ1fd6IUfzUS+Ww= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-640-zSj7O62NN4y6R_2iF7Pb7A-1; Wed, 17 May 2023 18:20:38 -0400 X-MC-Unique: zSj7O62NN4y6R_2iF7Pb7A-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-61b6f717b6eso2534466d6.0 for ; Wed, 17 May 2023 15:20:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684362037; x=1686954037; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VcaEZoDJHfgt+J9YnbNiKZBp9/Lub2+teMXBeGVG5MA=; b=a2AS+j7+dlBZ8mZZav1BsjfwpTef2FpNfcvmjEHGiGxsrxr3QegP2q8Gl5/+KIeMaF HSxA87pEYZvRFZZjTFKpuZaLbzQfffNrOySVL1/4uma/pyfm3xAo0DD3HWlxRbWT66Xw nVMc2oKhmqQhZ3a1IEVC3vVFYkE3Sbnx895x5ogfgPtKD9VouWvkRFh0XOALFctUA3Qu WtwSt2ZpqXpw26DAN03sG59rGXtO4LQLXCb7vCkvhmoINhQxJENCeVHm8QGWAAJ+IqEp 6hI3mDs7aRsin70OvNTFNhEh3xeMlHR1F2ZI+OYgO2w2ZWtobMh8nHn7VBaihH+//Mi8 cahw== X-Gm-Message-State: AC+VfDxUPi34ipqs5KHmbJHeJ5VD44RDuHw+LWL2jZPY5wxQqDDtAOai nOw+TExXBzB/l20gylT/vhW/bCBJSYPcDgXbXtsmjgCaJ1vaVgbl/JA1M2zXwLclFeHPhzIdqgU E4/c111L2Dd8= X-Received: by 2002:a05:622a:1a27:b0:3f3:9680:c51d with SMTP id f39-20020a05622a1a2700b003f39680c51dmr8042888qtb.0.1684362037294; Wed, 17 May 2023 15:20:37 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ51qVMVRnjdvCvS7y5TEkZzxFBB4mc/MDlORK64EYFltlS9Fb1BPgf2+NDqPVLOw0qxDZ9JXw== X-Received: by 2002:a05:622a:1a27:b0:3f3:9680:c51d with SMTP id f39-20020a05622a1a2700b003f39680c51dmr8042857qtb.0.1684362037020; Wed, 17 May 2023 15:20:37 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-62-70-24-86-62.dsl.bell.ca. [70.24.86.62]) by smtp.gmail.com with ESMTPSA id o15-20020a05620a15cf00b0075784a8f13csm937274qkm.96.2023.05.17.15.20.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 15:20:36 -0700 (PDT) Date: Wed, 17 May 2023 18:20:34 -0400 From: Peter Xu To: James Houghton Cc: Axel Rasmussen , Alexander Viro , Andrew Morton , Christian Brauner , David Hildenbrand , Hongchen Zhang , Huang Ying , "Liam R. Howlett" , Miaohe Lin , "Mike Rapoport (IBM)" , Nadav Amit , Naoya Horiguchi , Shuah Khan , ZhangPeng , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Anish Moorthy Subject: Re: [PATCH 1/3] mm: userfaultfd: add new UFFDIO_SIGBUS ioctl Message-ID: References: <20230511182426.1898675-1-axelrasmussen@google.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: hoka4hmbqjxyfrr8o1ygeixfytyzs7ui X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: C5AD640011 X-HE-Tag: 1684362039-485394 X-HE-Meta: U2FsdGVkX1+Exm77KkVi1F3UnXFI+a4MnEUpeHOuo0DjouTp3Q8O5PqtBzZMVDEZ+LZoVuMcutAKHyysVlkKejN2Ame7nLx82vdQB0SIj2ijrpw4wbe+/0fIBSLMlC6VMbhM9JJvLcqaP8rmXDjDdfU7/gfo798NnwghtNuhEEeNJzFr7edn5NELS7SaLLaa5vVnGU52g/NnbsqVEXl+m3+QAH8RlwElSm+cxquPplFsOW2DaWEm2rVUP+e27T+rGY862DT4VZ1mM7pxYFJnnrLVwDsL+Edy3lAKjdcaoJWq6IUzHglUmR+XE2RqzF9VSeWdRMtU3wpA97mTR97ZpE/6erg/2c7BQBAsNCJTyq326Ci3Mog7klgPb/cAvexGlsEozTXJHQX+1fpC0eQwAzhWuhWxckkWZuW5MAIomumAGLoHTFs3sf+pjLAwXmU//rzWAYBXl2xw/xMbXwmADN7qrrmYOqGsFcF3gdphmdYF+d3YjGOkykcWK9wzaQrMbFHGWOWTH5Noj7tnRuka4mnzCgH9TDly/HscTP63v2yMzZNY+lBs27nQIMVu1/jDpd+voXNL0AOWyJ0Q5cbKkKzIC0URoMTWhqCGQpyzzr3NKLhOS0WGY2/alIDvWgP/g/IOnJS6rgAQtfknoZSRzx1t4y1XBtugftYyB1Pd+I0KhEnBTG3QiYXdPUxRk85556DQSTmi4vt+k9O0t0RLdy4Oq48eIbHEedX6HjXcp6VMi3p/Vo/v6RfV+czGOEle12GNHY0nX3OekmZn88WjVPplJ9Wbeh34F/LxsNxi0QJ1ctvsGXABB1tVC4/ctGYRGqvHfdUlDBLTo7wVJPVJlE4U22s8F31GbR9mp3vYV6G+TqpOiRxmiUUYDmlZgaor9/5SP/TwIAUdq+Xq2MuSBZVaCvdpWlUR1Sm63f6b87qfX0duPxklRwiu1es3iF4S8wOgcVZfw0mbTIikpgP GMSegx0l SC8mF+bAk+NH491lChZGQUqyjG6XFSoMpN8SPYV8SpKQGzecgrPmRqM2g5VvNM2z3Kbzn8zM8288BEENj0XzNGqPVKXr/pG4w9aa23mGYrWnq1ZLP+ke0WohYhu/U04rIIVtPL5r754jleE35Eunt69bJL7kSA4UMwWCY55ROasE89hCEMU+9kWqJnTkgZUyNEDUwFHoPILejFqlCxCxL9Ko3CM46IGAGufv3n7NCwfsyINdeRbR7FZUWa2ztuZB+wOeAtx1yaybxPMYjdjxyL+TukDpB5gA2PlWItLSI78gELZ918ttRWmdlxr0jIeg17p1qpjhJQPhpt21NMDdm/mm+l3ApEUhr3d1eTnO6k48ZnLWGrUuaN8sbOeWlvVancgJUw8Vl06I0uIj3+KDNDYlSFsx1KoQUH5F/u0tslwItJHhi4ZAQrOgmkQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000017, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 17, 2023 at 06:12:33PM -0400, Peter Xu wrote: > On Thu, May 11, 2023 at 03:00:09PM -0700, James Houghton wrote: > > On Thu, May 11, 2023 at 11:24 AM Axel Rasmussen > > wrote: > > > > > > So the basic way to use this new feature is: > > > > > > - On the new host, the guest's memory is registered with userfaultfd, in > > > either MISSING or MINOR mode (doesn't really matter for this purpose). > > > - On any first access, we get a userfaultfd event. At this point we can > > > communicate with the old host to find out if the page was poisoned. > > > - If so, we can respond with a UFFDIO_SIGBUS - this places a swap marker > > > so any future accesses will SIGBUS. Because the pte is now "present", > > > future accesses won't generate more userfaultfd events, they'll just > > > SIGBUS directly. > > > > I want to clarify the SIGBUS mechanism here when KVM is involved, > > keeping in mind that we need to be able to inject an MCE into the > > guest for this to be useful. > > > > 1. vCPU gets an EPT violation --> KVM attempts GUP. > > 2. GUP finds a PTE_MARKER_UFFD_SIGBUS and returns VM_FAULT_SIGBUS. > > 3. KVM finds that GUP failed and returns -EFAULT. > > > > This is different than if GUP found poison, in which case KVM will > > actually queue up a SIGBUS *containing the address of the fault*, and > > userspace can use it to inject an appropriate MCE into the guest. With > > UFFDIO_SIGBUS, we are missing the address! > > > > I see three options: > > 1. Make KVM_RUN queue up a signal for any VM_FAULT_SIGBUS. I think > > this is pointless. > > 2. Don't have UFFDIO_SIGBUS install a PTE entry, but instead have a > > UFFDIO_WAKE_MODE_SIGBUS, where upon waking, we return VM_FAULT_SIGBUS > > instead of VM_FAULT_RETRY. We will keep getting userfaults on repeated > > accesses, just like how we get repeated signals for real poison. > > 3. Use this in conjunction with the additional KVM EFAULT info that > > Anish proposed (the first part of [1]). > > > > I think option 3 is fine. :) > > Or... option 4) just to use either MADV_HWPOISON or hwpoison-inject? :) I just remember Axel mentioned this in the commit message, and just in case this is why option 4) was ruled out: They expect that once poisoned, pages can never become "un-poisoned". So, when we live migrate the VM, we need to preserve the poisoned status of these pages. Just to supplement on this point: we do have unpoison (echoing to "debug/hwpoison/hwpoison_unpoison"), or am I wrong? > > Besides what James mentioned on "missing addr", I didn't quickly see what's > the major difference comparing to the old hwpoison injection methods even > without the addr requirement. If we want the addr for MCE then it's more of > a question to ask. > > I also didn't quickly see why for whatever new way to inject a pte error we > need to have it registered with uffd. Could it be something like > MADV_PGERR (even if MADV_HWPOISON won't suffice) so you can inject even > without an userfault context (but still usable when uffd registered)? > > And it'll be alawys nice to have a cover letter too (if there'll be a new > version) explaining the bits. > > Thanks, > > -- > Peter Xu -- Peter Xu