From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8E3AC77B7D for ; Wed, 17 May 2023 13:44:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2FF16900005; Wed, 17 May 2023 09:44:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2AE97900004; Wed, 17 May 2023 09:44:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19E33900005; Wed, 17 May 2023 09:44:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 07EE1900004 for ; Wed, 17 May 2023 09:44:00 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C3C654055B for ; Wed, 17 May 2023 13:43:59 +0000 (UTC) X-FDA: 80799865398.18.B984839 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 091021C000E for ; Wed, 17 May 2023 13:43:57 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gL7FAHfr; spf=pass (imf21.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684331038; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H43xtUiZrz/zt1C3G5ouh5iDSF7mMChsQqyrFh5tLek=; b=SgeEBSfRaLnWiUzvp9ESjH/19smj+8WxUVHjlPet4mMfjH4V12wIE+vQthUzGZIMz4boIO 8KfrOdcwI/0bjuQF7kxE5v/hydYSYPQxsuIXHgX6S/zRttTQIrX+ByWOWGrV0+KYaamlhX CT68rCSfO6Lt2jH1YUcMTWoK8pWFXBY= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gL7FAHfr; spf=pass (imf21.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684331038; a=rsa-sha256; cv=none; b=mQMzaVMqvcX6IWXtm+Y7sHUbzZAMF+mebn6Bu5Fu6xn9aJ8aJJACvbq8cTBCPmrdY91HtE IIXTbSK2m790E9ljHnwK8tlCXP6ZYNl02dMpIgtb1DVRLqIYSVfMZSEviMR6cXCk68vyQo KDCIiRDij7nMQy60SPvlar+MAIZ+xws= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 32CC46397D; Wed, 17 May 2023 13:43:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23FDBC433D2; Wed, 17 May 2023 13:43:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684331036; bh=30NDGJJUQ2ngQiq5TLIVzfaqaVwEFe2VeoyqyahSpjU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gL7FAHfrNE/7yRDcy9u+56Cueii95xAEu6aeJEtdwuWYMhLII9uXwi5FZzPPcT1ur cia6QH1+vq2F5deS56R7lQAGrWI5ZuCUCXXbZpmJVyKJ5bJ7qWDEWp//sVr3x+Wey8 2rC15gjTD44yj80TMpAoHXikCC7QvMwK9i5H2kHbkfIOHVBBdb0TXWQRnmf0PFk1at 1UhgK+KMcXAqna39+1zsxWMKtGoYDgIQM75TfkL5KPt2TCXUFGrsgl2VfHHGDlbLjw DPPYKYyUpG4rWQm0CrxNLtt9hJ4obhz4VW5efoWBLO7zFfchPKrF63h9awhU0L5bW3 LK5E3g3VWNeAQ== Date: Wed, 17 May 2023 16:43:51 +0300 From: Mike Rapoport To: Yuwei Guan Cc: akpm@linux-foundation.org, tsahu@linux.ibm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] memblock: Add flags and nid info in memblock debugfs Message-ID: References: <20230517025747.230-1-ssawgyw@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230517025747.230-1-ssawgyw@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 091021C000E X-Stat-Signature: tr7k6kktfodtd5j3aqpkqs7qwa36d81e X-HE-Tag: 1684331037-412231 X-HE-Meta: U2FsdGVkX19kXMRXdgJSD1EgQNgOXcx2cG30po9tQM/tKwNfzfs8S4xJwmH/wzVkT94Lg32bLk4DAwJLsZ0FAxh8GMoxSwxXL+VgJt+MofCUFAuipTQlJTUR58FhSce1xXhaqI8ci25t9TmWkKwZpCz2Q91yeHVAk4K9A9vF9iMUKeVgKdB7Qim5KqBypH2vkf+SKAiMnPgkquvrEzoEqLYctOe61eZjuYFO0S62PZmTkdhPye0LgdZtcxse5KlwD6o719yh9h8MmetwAZqpyOVHD2ESMGWrsGkylvw7ox++88Y3Cb2j+skcVXUuTWeIhpy3KOh1/X59sgYlN8QUExW0o4ldJgsTLqIbTm3b+lpIkbH52hfWbpmXHteGJ22UxHGtSbKKjzrXXbKw5uf1YQVsqI7HKCsyzjUC6f78qmEIUyzMOQI8CP1SZiajwb+XX48xnrCAVPv1fyzDe2oi04yzmFFAI8WtptF66/K0hP0BuyFSg2ziHYcm5khGeY9ri72A8Za5DNXTlo5FgqqDqEZFXZYtbSx5Ax9U/rcm/+SmIojQBN6jDrUsfIw1WLSq39HMKUkIU0WtWnhBxvesIr3xqd9X+CEt7tNQ9++/WwxvW7U6rvM8hZBN+vRVtIOL8xhjMzRv++cLAMjbjOD76GKxpZkL1yt0hLeWZyV5cmd4YAXJInMe7zB1zkNnKleKtmIXn8a/5ZeITAwSEOr17/hfY/THVLVz/GLmlYdPEpNjCj4YyE1zmPDVAH0XWWxqxs7lORq68gHPzetzb4EhN4flsWgNR1uTiuiyj4Tmoa01MRGYGwA4spE9GQI73OqnQY89HhYHY17VD4y3TeDINNtQFxmIqyvidRhSQrIbH1bMDeWZ+9hOKxkK/ofI0T5v1pSfSFVwYmip2ILekj/pNVGbG+x92KnstGDCGM0CNC2/8p9QvnXJsOh4FvDNAYjV6H/CX9ptXOaA5ZOQ4lN cpGNfa3K Bmr7aKGfZLx9t1JSmEcYH8fmbOH95MB1lSZWekAPT3g70BQFHGZaER138byIPYyM0TunQ3kkNOxQHQRhloYZPtXlWPlPfyzbei/09bItMvadoXyw1Cq7oiZ6t8+R/gh9FInGCHlXidrdg7IuuuihPchh/jP0bTP6IN69lUVsg+/3z5lSyp9rYRfK2TOLaJdXN0GR7kNpa57PEW6imHlgvPuzUPvDBruUeTK5ZnlPKMN+mvLYr13bKyplS1Je/Q8rEHifvIkKg9lERWLX8UHz4bvU40z5aSa4KQlTy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 17, 2023 at 10:57:47AM +0800, Yuwei Guan wrote: > Currently, the memblock debugfs can display the count of memblock_type and > the base and end of the reg. However, when the following scenario occurs, > the information in the existing debugfs cannot make it clear why the > address is not consecutive. ... > diff --git a/mm/memblock.c b/mm/memblock.c > index 511d4783dcf1..b36fb6b31e0f 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -2144,12 +2144,16 @@ static int memblock_debug_show(struct seq_file *m, void *private) > int i; > phys_addr_t end; > > + seq_puts(m, "cnt\tbase..end\tflags\tnid\n"); > + > for (i = 0; i < type->cnt; i++) { > reg = &type->regions[i]; > end = reg->base + reg->size - 1; > > - seq_printf(m, "%4d: ", i); > - seq_printf(m, "%pa..%pa\n", ®->base, &end); > + seq_printf(m, "%d:\t", i); > + seq_printf(m, "%pa..%pa\t", ®->base, &end); > + seq_printf(m, "0x%x\t", reg->flags); > + seq_printf(m, "0x%x\n", memblock_get_region_node(reg)); Please use "%4d" for nid. > } > return 0; > } > -- > 2.34.1 > -- Sincerely yours, Mike.