From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FC9FC77B75 for ; Wed, 17 May 2023 16:00:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C4369900004; Wed, 17 May 2023 12:00:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BCAD1900003; Wed, 17 May 2023 12:00:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9284900004; Wed, 17 May 2023 12:00:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9397C900003 for ; Wed, 17 May 2023 12:00:10 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6C8874060F for ; Wed, 17 May 2023 16:00:10 +0000 (UTC) X-FDA: 80800208580.09.6954286 Received: from out-32.mta1.migadu.com (out-32.mta1.migadu.com [95.215.58.32]) by imf07.hostedemail.com (Postfix) with ESMTP id 8970B4000A for ; Wed, 17 May 2023 16:00:05 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=DKzUV2fM; spf=pass (imf07.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.32 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684339206; a=rsa-sha256; cv=none; b=NAZeTD4VBidpU2R0CIPSXxWDBheB6BYQ0CvW+EMfhEp1j4lD3NO3+xnVWhrzQ8fZV5nb9o SmoVRhUK7BXFRUTMCDDHdpw9h14Lp5a39G0hvkSFHnHqDIJbMBHDyuIV+09thMbLmGE11j dTbsBeDPn2Dami51ZDZiYgsyyPBGr70= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=DKzUV2fM; spf=pass (imf07.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.32 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684339206; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Uj5Rjh+AN0r/Ht1trw7qzyL7wBHUsoOZQ8wgW5hbJew=; b=mZhES2Fl8abgaTQgPb5XnIAqA+tS6s8l1LwLOP54LF3Dij/I80ImYRnHBWyLA0x5N3OLab XubOwjeEXn2p5IuAORWTfkKRiOF3A8YI9oztpT1Fau3PB0+gXToq4uBVjIPyITq6M5PVGN Eku++3XyLlpJhk15VtqQkGXXIKaSbJE= Date: Wed, 17 May 2023 11:59:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1684339203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Uj5Rjh+AN0r/Ht1trw7qzyL7wBHUsoOZQ8wgW5hbJew=; b=DKzUV2fMhLT8gizPcUiaWKOzbYxc5ECoXth7Jg+gW5iquDVvCug3k6eHhkGXh2VnHvbXsh WF7yrhikG1PJYZw7Vgi2IvcQJXxvUN+yQTvVEiCRi+ldsou1jQ5un2NZgJyqsC8Ff95uqE +hOLNw5zcm0cdTCRdL7KgsuYii08Ng8= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Mike Rapoport Cc: Matthew Wilcox , Kees Cook , Johannes Thumshirn , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-bcachefs@vger.kernel.org" , Kent Overstreet , Andrew Morton , Uladzislau Rezki , "hch@infradead.org" , "linux-mm@kvack.org" , "linux-hardening@vger.kernel.org" , song@kernel.org Subject: Re: [PATCH 07/32] mm: Bring back vmalloc_exec Message-ID: References: <3508afc0-6f03-a971-e716-999a7373951f@wdc.com> <202305111525.67001E5C4@keescook> <202305161401.F1E3ACFAC@keescook> <20230517154412.GC4967@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230517154412.GC4967@kernel.org> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: u3i1ibxisak4umdheinrwfqjwj56nrfm X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 8970B4000A X-HE-Tag: 1684339205-137733 X-HE-Meta: U2FsdGVkX18VRKO66hduNVkAmqoFWCPtOOEXcWrNP5+DpSrQL11lOYwF/6xLNo1FQgVNFU0t1oKed8OEHaQtCFzyVVTqWwV1zG5ysPPjtnsX3pY5iAYGIYIADI01gdqifKMCVqniyJgcaszYIAl0kZrAoQ4tKOi/N54jZb0t8BBnUxqhVx8DbpnkMvsGHDjOBea/tDFlXkz4H8pHfo856j/H5R7YkdvMagSYNRxK4gQ/yoK5usfTa80FnXPxVykC1VtuD2TAgA/tq1pgQi8d1z0ivM6+9xJwjhpNKYijIRIImwc0dWowoFL23EJZue6W5vuYYigbkBMcK7IsCMzvUaVJuwJohipUkwYLUmwRwZqg7FRbQDfmMKjGDE03rnFlnGvHXYbKUFIQdsCHVkLxZK8nhlKCj7WfDzk/G9Q6Nm/8B5xS+EDcqDzMv0reoyvHUQi0Cd3JLCWSHm8paKK+zAek7VlZ2lV4me21wlKPlecbV3L201SRvvXUvpnkK+ahXjdaTZi6ujUWXhWvJ/K2SFsxe/YSeBu8x0grrtuZrV109bmFtYFimIoM0l3csw51pXCLhE18u3JX6jbBZBdPutyf2ga7dNUU/EoZ+zbdVZ0shvIiAnAx1QWZzwDGCUSGWLA4pmiuYDZ+ZnH8k2vOwWg8ZefuWlqbDGTiKd+gQq0k/wxMAQ57+sdExb2syDQMWYtHsggnL7qbm14eFN+Gq8ggf2suj9w7eKlVGFsltPiiAqZ7f8FwpqqW2o+PfRpypmolS7HhlOj4NsQwLdeeOTnBwdzEh9kjZLNfhPc4rFrz/KeVV0iBaMKYy2EWqWQJ0rOuYG4C5oX1ztO36zZA05EYoCS0XTbH08KvRGMltqqs93wNFz2uvWdUjlv7UJnbpq9/8xXVEq05fC+1xLaw5eLN0Ie4ydKngNMIA6aAfui3YtBDSCL90DbiubgXoBKpjvFRVsqz7Zvfixy0OXU FBp0C1y7 C7FmQGP3fEkTDV9HtKa46Vc2FrrXMRxFY2NYGMtkblPUWR5FNkCzmnwu9qrUW4Y6/lKCYUZafly4gjhvO1red7tk7vURbGxpANSfQpQ3W4/AKS8uTTFbyymbhgMflftsoCuUKj1hMbMAJKph4a3j6igRHMb79Qm0rZnqdlHeNsKCkviwYzg4t2hjQAt8Ur6uz6LMm+/6jC28FFYI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 17, 2023 at 06:44:12PM +0300, Mike Rapoport wrote: > On Wed, May 17, 2023 at 10:18:11AM -0400, Kent Overstreet wrote: > > On Wed, May 17, 2023 at 05:04:27PM +0300, Mike Rapoport wrote: > > > > And I'm really curious why text_poke() is needed at all. Seems like we > > could just use kmap_local() to create a temporary writeable mapping, > > On 64 bit kmap_local_page() is aliased to page_address() and does not map > anything. text_poke() is needed to actually create a temporary writable > mapping without touching page tables in vmalloc and/or direct map. Duh - thanks!