From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46258C7EE23 for ; Wed, 17 May 2023 08:08:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B4791900005; Wed, 17 May 2023 04:08:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF619900003; Wed, 17 May 2023 04:08:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E46A900005; Wed, 17 May 2023 04:08:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8F904900003 for ; Wed, 17 May 2023 04:08:23 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 63B8916047F for ; Wed, 17 May 2023 08:08:23 +0000 (UTC) X-FDA: 80799019686.05.5E528FF Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf20.hostedemail.com (Postfix) with ESMTP id 9AA9E1C000F for ; Wed, 17 May 2023 08:08:20 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=FnoH+cpg; spf=none (imf20.hostedemail.com: domain of BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684310901; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MYYEfQ7vzuqCApSKZNujoQFgvRYxeJUWWx069C/3rJE=; b=f48J2IYJ0QfTyZlQeXXVb6ic9Jk3IQYc88cc41OaVxl/cS6BcPhInrDVQm5ISFScKyVd6h ecxK4LDug7l84w7+TUCCgBoZb61eY+fiWsDtMXdd9Qnb9zHHGsiVSuaMHGy+du9zEn5VNd iev4oAj2MS92AoA7QyOEsnTzwnSqTPc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684310901; a=rsa-sha256; cv=none; b=ri9Ix/IiQsN1G/3dBQyrXK7aW74ctWouHJYdPcGPdH0kbJBzC1LqfQp3mCZR+bu9wYmXzl KyvwppKqpB/HflLLv9A3td124rXFccvSr/ofyrv7oUAE0RxnjlleBHQxNriNcFXwfLUZ8Z qgncsBcg18ovaUXMy4Jx8WSuZ60jDkE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=FnoH+cpg; spf=none (imf20.hostedemail.com: domain of BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MYYEfQ7vzuqCApSKZNujoQFgvRYxeJUWWx069C/3rJE=; b=FnoH+cpgQsF1pchwLsW21vr4yq rfGG5f0tyOZwvmSMI5RyYHyRKIcn/5VvaTBInEHEdxo/1FxUq81ni93lqeXYeDx+qq7x0a01FVAPo 0ozgqxiGnypQ6GkAoTaTosBZHVJMymNQLhfGSekd/hn+aRYYFGfqZ54Qr4XgmuetWL2h0F9zGpRX+ Xhm57JDouW8VZbNg8g1f8K02HbDsqBpIazBHMHWWQykH3UsM+JutLWQ1QWyeaNOdFH0HUGi6R9KZ6 4iBmFAZeNfFYiQA8b1rQU/Jk2ehGWyS5GcZACHZmquFPcEM9I1wTlTTGv3mePU8PxuvW7s+YwkIIR D+aGP5pw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pzCCi-008nDb-0c; Wed, 17 May 2023 08:08:12 +0000 Date: Wed, 17 May 2023 01:08:12 -0700 From: Christoph Hellwig To: Niklas Schnelle Cc: Christoph Hellwig , Baoquan He , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de, Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , linux-s390@vger.kernel.org Subject: Re: [PATCH v5 RESEND 10/17] s390: mm: Convert to GENERIC_IOREMAP Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-11-bhe@redhat.com> <6a6f5552fac1427eafbca1288fe5d5cb0cb6a333.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6a6f5552fac1427eafbca1288fe5d5cb0cb6a333.camel@linux.ibm.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: 79dha9rqzpd1gd8zpeg9jbqkjw9nokmm X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 9AA9E1C000F X-HE-Tag: 1684310900-922424 X-HE-Meta: U2FsdGVkX194rjd8oRgUqu1nFyqJsAgdgVjHmx6UJzO7Sa/nCSkRZJeUBNjJ5gu8796/nfY+pVYl38jpgeK91sWderlT9E7+dlOA0EW11CDVRVFpPN7ses7hdIqdIkxm0sjYjdSwzNfJusZlZMBJrdnIsSInNUb4HL2Pveiz15lKRmwfwpH2YOXywEgaOXe3kP969PGjiXEZk0A+yV5CmHQQwsTWTzQGmWsHF5lMAJTqf7URvxMTR5v+z+nqdOA0yN1/1JeMN1Z1aJhl6zEhOqR7MHVMz1XeHqr86x8hldjAoWOyUueeyic2NyfeK7OyNhxksXDor+wdG7v/4sO1oXP6KhrPGEfSvw42vFFYo6zLfGn2EJ0kszsjg8qZnsp94qog0aaN/dQvQ5Q/1a1BqNv5duZJPuqhHKQa/Il5TQOnxh/4MUA/GMzJlQ7KwXqYFzU6vDy9Dk1Dz4T/IVVnRkpx9mdsNXIqZo/gLGs7H3YXU31/CDWUh/S5qg9Ppbfe0vkdIB5RNtnFuQKhOryI/2eT9VbfS9ENQFJj2DRxfLCHGcCVdKFAPNA/4oo4i9vXr4QTBDaijVep/ZkciYN0mVV5dZ9l9ZP5LxG6PVA+khh9GsjDfTXuNuU4/38Ne7y7Ksc6cXIWRuB+TmP28sgc+wfaj1e9FbjNo7CiwNT+Dv5RYFtgBiaoVcBo+N0Nokb355UQDmgxCetL1WY5Fu1myJB+AKMlplOFGoSrRCRFgiP7KD1Rd1bWXeK7ba9GoPpGSqjAcWmLOY/00BUj7Z9HzBT5llGFZiTFubFnRYTDq3FOaaN79J4y1HI2z15wKlmw/u0Ic2WOpJLUQKF5ZViNHk25SS1UUkPwptyE9rcWUK3LRGOFuN0jTeUNbEJWYo0QecdtL+fqdBjRfxe4iCUes0+HJScKI5riqBTfjCDGldDbb5VTZp10jgO8XknSs2ie/uLFOSEX9vnCwSTYKxf DXBaAajj vVEknW3yhiz2Z7D9q6kJvRqF20nTQB0yPXj4CyBkUrwyK21F6kK/d2TP7MjZag/oQmx84gCfhUGAtC1J9ml3IME1Uj6k5XsVYTAc55gj2Se9eFUwD7pOUAQaCiXyPO7quz5ZlMwq1O8eLbLYxXZzM4D9cSGlcXn/Ie3ehfg2561u6B2TP4up7jPwjBNZMI45EickdxezTbXdi1aK/Xkj7sk8xb/739YT92intiruM8e1xjjUQ/4cc6cxSulwA7Sf2iqHxERI9lfRoeKqGwLKz2577TDBbZi6/V3CqEnG+NaR3e/5ZD/kA99++8Pim3wBPLXbVxSffwbxzPiwqYftHoZRLk7+TElEZryBktV/9ft83ggHoqWaxy8IBkOvLPbe3hBjvC6jdQw2zKzY5VE4m052IVT1Ji0Je8QeSwCrRxxFpZc9EC9NBNmSo+A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.003463, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 17, 2023 at 09:58:26AM +0200, Niklas Schnelle wrote: > > and just define this to ioremap_wc. Note that defining _wt to _wc is > > very odd and seems wrong, but comes from the existing code. Maybe the > > s390 maintainers can chime on on the background and we can add a comment > > while we're at it. > > I'm a bit confused where you see ioremap_wt() defined to ioremap_wc() > in the existing code? Our current definitions are: No, it's me wo is confused. They clearly are different. But the same comment about just moving ioremap_wc applies to ioremap_wt based on how pgprot_writethrough is implemented then.