From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F260AC77B7A for ; Wed, 17 May 2023 07:35:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5104C900004; Wed, 17 May 2023 03:35:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 49936900003; Wed, 17 May 2023 03:35:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33A1B900004; Wed, 17 May 2023 03:35:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1F6AD900003 for ; Wed, 17 May 2023 03:35:11 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D38FB1A0491 for ; Wed, 17 May 2023 07:35:10 +0000 (UTC) X-FDA: 80798935980.02.B747BA9 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf02.hostedemail.com (Postfix) with ESMTP id 37A588000C for ; Wed, 17 May 2023 07:35:06 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=fqgCRcaF; spf=none (imf02.hostedemail.com: domain of BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684308907; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hcKgMqBaVIqZoOwjyxizzLY6i35d7PAbT8GtOYflIfk=; b=kpLTRii0kWtnLVNEmVMOw85aq4g7cbw/z2emQTCKKprCbn2hqpiWaultLbijV/kdNO8OWU FCMgIQMkz8FHPG6uP8aOTgKtIgC28/ikN98Y7FaprkjCJA/Rg4z8pq7xh8tdP0rK6uB6LI cmtmUD8u/cHAow9Il6k/p2hqXAgpg5c= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=fqgCRcaF; spf=none (imf02.hostedemail.com: domain of BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684308907; a=rsa-sha256; cv=none; b=BsyTb7lL7wYkwPF08cW77nvRPFcZdZMMFs45f7LUenhcXjFhLBoFyZ2Xn7PgIqV3HNA0jg m7yCyvvCqvQRoWDF/f+bGd6tP/yNw6cSfcenz8GbBCTj6QlQ48SqW4S11NjqHt7OWTEA8A Vmwfq2I7F++p3Z9ZYPvF5XcCzJDDhYg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hcKgMqBaVIqZoOwjyxizzLY6i35d7PAbT8GtOYflIfk=; b=fqgCRcaFzw3/J6P9X/XIEYB7c/ m4m1SzOzwxAy+e0MN7AfudrnRjsla5m3WrVZuhFLh/kE8QAsriNEh2qXwYMAehf1+bCbOHNPIvQgz BhdZ6GvATpmwGEnRx0jwHXvYm0NUrg+sd0MCJ5sWMaW5OpY/dbubDOX1o/tTa/QcYd/SFyF2gm4yJ 3HbXkNE1Qkthwx+tpCOTdM2Ldfbewcy/jTAp/HJJ2DRw7Jn3cSg3eVSTruRbmS1Evl/bZ3/Q79U7O duNkcsRIqalJfa2J0wStc9PGKv3ZT62ZgcwkbXFc6lY3NYDB0eiqxwYdRLKTAsToiJp9tBO4+Myil bNUZI2Vw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pzBgY-008gi7-04; Wed, 17 May 2023 07:34:58 +0000 Date: Wed, 17 May 2023 00:34:57 -0700 From: Christoph Hellwig To: Xiaoming Ding Cc: Jens Wiklander , Sumit Garg , Matthias Brugger , AngeloGioacchino Del Regno , op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, fei.xu@mediatek.com, srv_heupstream@mediatek.com, linux-mm@kvack.org Subject: Re: [PATCH] tee: add FOLL_LONGTERM for CMA case when alloc shm Message-ID: References: <20230517031856.19660-1-xiaoming.ding@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230517031856.19660-1-xiaoming.ding@mediatek.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 37A588000C X-Stat-Signature: 7aqrj6617m5edozou7xmmhgdkifb93m9 X-HE-Tag: 1684308906-159337 X-HE-Meta: U2FsdGVkX1/rs/Rwal0yY/F+qvFNsGsr4cJVSWbnYErDHbTxIYeAQp/EfSmP69Jh48fAtLU+g+nTO2DhAwl+Pf6G9QWEOSVPDKb/wkyjTQBsW/ZYtOp1QlOcrOTMvzfFPWVezGQ8+1gc8xD1f4CS8ME0GrlGfiLTeOhGMeoMZfqP4YkHEwEP0d775EpxKtj1JJcf4EcGgRq9LD6kjEt3GnAA5YMz5ekNJOxehjIHxQnhGziRk5UwzobCP+oCUZ4MKuHG1E4YBnY3SDnjoXmUL2fOq9FQb0qZB1yBTaZeRCY95aJC7KHN/uAO2pR9yLYmmDHN5hg0Tn0Q5Xq50rJH7NmNO9wsGAXcccYMBx2+dMSn2LKZyQhQTlgd5bManteFDdzT8FEk3Hz/cBlDoXu+8fiS/8x3gn6RQnZaIym49vWrwYg62BGSSPeE/OLjt+CQG+YKHAQYzdRhedJ/XLmoQ9jTe77B2nlY562cWDrMV1cRmy8RquKS3R/6z+DWkH+0wDrlTJaMMQZAwKj0GcPDsCR6Z5knKlgoCzQpAZXUQQEWtirhgNmVVBzXrBIUelkL2R0iChD+56iIbSaDOIgOOB+n7FlXGHH56rEOaGNtL5ZkT6N+ORlcCEHsFGWv4knvRp2QjnsFQ7RS5/5ZdQq8uOyWEY2xUEN2TKDlzt32I9vPWoJc5mdToGFupn6R+XcKezXcFTa53KhBF7CS8lib6xuQCTnL9k7uEtTsXgHubONr7wyHovGuMHcRrlRc+BbD44sioaICXq0pYs5TS7x/j6ID7Q4tut5RjqYjll8Cj6X6ATr/bcLexTEBzlXnoChb1iYL9DN+iGttFxd6zZca2dcr2+nkg25LcQn2Xk00EEk6tYA2+WpKbKznVu00sk77/mcbbDF4pduogydc+7JZ6bKOVSYAe2ysod/adE+CvMg35pA2hcwvaeleOWbmoQFkahsIgxUPAzGsSZqjIZW 0BlDa95w C++XYjfSf4lf3P964Lj8Qwo/CYWDtzRS+JXZPo9HmdFZirRs72X7lIKSqSNuN4LXMEFUNzqevJhb2JvAsWc/egmzxcGHW2wG7dYn6haZvwuOEYAawQdx+eVzm0n4OdzOX4KyRVg87hRiHqCUv7FmayA9xM4JR/Ei7sr3pygDC97xzd/LH1+UukLgWxNSLCvN3vAvCnjkmDhmQv9Stbog8Ko63c5mx/JaJ0Cq+B/v4B7JnLfYE800v+YmNblUWJ88IUHcnq+r6BvnywbFKN6sPp/UgSYAQhLEdUiY+ZMC4Qyjmi7WWtwafelRBdSMkUC+bl3GWHusT1sj+ZjiOhnt0HV9qwdY8zuzAtduYWGbvNyOkyIetWFT2mcjkmZRZQLBL/EanEtZq34RS3LFhWg8dUFv37YFhZ+qg1wC9emStsNNT7b3YKbf9xJQxobV43NU7yCqBxnY/Ny8oZgN2J8iX8ks1AXYVmxIUM7o0+yg19YAicgE+XiAVCv+7RJesnAp0tyO8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > + u32 page_flag = FOLL_WRITE; > > if (!tee_device_get(teedev)) > return ERR_PTR(-EINVAL); > @@ -255,9 +256,11 @@ register_shm_helper(struct tee_context *ctx, unsigned long addr, > ret = ERR_PTR(-ENOMEM); > goto err_free_shm; > } > - > +#if IS_ENABLED(CONFIG_CMA) > + page_flag |= FOLL_LONGTERM; > +#endif > if (flags & TEE_SHM_USER_MAPPED) If this mapping is long live it should always use FOLL_LONGTERM. The ifdef does not make sense.