From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C3E6C77B75 for ; Wed, 17 May 2023 11:29:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70192900004; Wed, 17 May 2023 07:29:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B19C900003; Wed, 17 May 2023 07:29:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55248900004; Wed, 17 May 2023 07:29:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 45D70900003 for ; Wed, 17 May 2023 07:29:04 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 16C051A052A for ; Wed, 17 May 2023 11:29:04 +0000 (UTC) X-FDA: 80799525408.06.4AE2BD2 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf20.hostedemail.com (Postfix) with ESMTP id B2EFC1C0011 for ; Wed, 17 May 2023 11:29:00 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=VRtGkAfl; spf=pass (imf20.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684322941; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NDNDo483NWCxuBgC62EmEkRd88RyM/bkMdaCrqWiEjU=; b=uu6difOFn58WqSlCDDj8sRZm3eqVZTbmE6O9W367odjXzm7iSLkNPm9T7p2V4DJb++wUUt dsyXNsPeZpbRP5iH12kusVYfSs+Go3MkXk+T1//1+ehmwEDiIEl1axtgpGT68ek/K98tB7 Ez9C5WzepmDNPrEOhlrLuzER5C1ie3o= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=VRtGkAfl; spf=pass (imf20.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684322941; a=rsa-sha256; cv=none; b=zIR7X3H1tjp/G6js+nR7UBFY9dPbBHcYizXUjTfPd0dd9JdIyTeJMNiz2Ppr9belL/9PSr FN8aDRyjrI3DR/KiQuuNTN33G/39CuFKruQy88r6CQPZOt7CphY0hIi8PUMtLy5L+Z3COx 7wB8mFxvLSMk0DWSXTItxu6ZxklFeZw= Received: from pps.filterd (m0353726.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34HB7BJC023902; Wed, 17 May 2023 11:28:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=NDNDo483NWCxuBgC62EmEkRd88RyM/bkMdaCrqWiEjU=; b=VRtGkAflt6Ne1p93gyowlWX7j5boLIQ7h0nC9VIo7uX3bwTrUs3t4FOkk1lJTYXqc25V 9FamFmiSWFwwyWa1DKrOu9DcxLjGAv2i0jSAymPQgGQf5P0M1OluYrFgT26OhkCmT/su BOKQtACZlOM4qdl7albr+SCOM7HzolGHsX5OPk132gsH5r9G7psINiKU8nGXVgkrlm0G JFTSinpEe96JQbyAanKB2Lfpy9cfYcMtNW6I0KolKOl1iMwgb7HevQZDAfJyxXafubsX 7gBNmSwaGFu7ct5RonhF3KWLIHQEwZVWECGZeI9L5VSTs6GPXqMDDHdOU4895qB3OFQc 4w== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3qmw5v1gq1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 May 2023 11:28:14 +0000 Received: from m0353726.ppops.net (m0353726.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 34HB7Pi6025529; Wed, 17 May 2023 11:28:13 GMT Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3qmw5v1gn6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 May 2023 11:28:12 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 34H2RRIs022653; Wed, 17 May 2023 11:28:09 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma03ams.nl.ibm.com (PPS) with ESMTPS id 3qj264t4u2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 May 2023 11:28:09 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 34HBS6QC63177030 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 May 2023 11:28:06 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 203902004B; Wed, 17 May 2023 11:28:06 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0CE9620040; Wed, 17 May 2023 11:28:05 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.155.204.135]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTPS; Wed, 17 May 2023 11:28:04 +0000 (GMT) Date: Wed, 17 May 2023 13:28:03 +0200 From: Alexander Gordeev To: Hugh Dickins Cc: Andrew Morton , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Russell King , Catalin Marinas , Will Deacon , Geert Uytterhoeven , Greg Ungerer , Michal Simek , Thomas Bogendoerfer , Helge Deller , John David Anglin , "Aneesh Kumar K.V" , Michael Ellerman , Alexandre Ghiti , Palmer Dabbelt , Heiko Carstens , Christian Borntraeger , Claudio Imbrenda , John Paul Adrian Glaubitz , "David S. Miller" , Chris Zankel , Max Filippov , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 16/23] s390: gmap use pte_unmap_unlock() not spin_unlock() Message-ID: References: <77a5d8c-406b-7068-4f17-23b7ac53bc83@google.com> <5579873-d7b-65e-5de0-a2ba8a144e7@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5579873-d7b-65e-5de0-a2ba8a144e7@google.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: tSWvl9C0MlO4O_EzCFOjF_JcbOB8NztS X-Proofpoint-ORIG-GUID: NWm_n_tm0YYcdEmwRmZvkdtWX-DujuzO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-17_02,2023-05-17_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1011 spamscore=0 adultscore=0 lowpriorityscore=0 mlxlogscore=780 priorityscore=1501 mlxscore=0 impostorscore=0 suspectscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305170090 X-Stat-Signature: d1wupy7tjacmczkb3xcsboyq5k67h6g1 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B2EFC1C0011 X-Rspam-User: X-HE-Tag: 1684322940-155877 X-HE-Meta: U2FsdGVkX182nK4qqIfJlrnJnyEUO4xrk+bhKzEGLoa9iwOK3y/M1D6kh4n2s8nVbX5LPq4Leu9fx2smdEWZiPe8EeW8QhumOkGteaLgTPU+EWBm88Hz1rKu2v6n+l4yK5kFuSNKVZuuKpodQLp9AtY/4/sv1hbB11P7bADZv5RzKwAxuS25VLDhsGo7gKDMhr/fi6jRGdC6/x/frCOu0JnrZqo4EqR8PvqSN8OXGvywUT/VYK5wcxEUk+VkqHHModKaN/fGOGLH+YcaVkx3Wwf6g7hx0gn2VX1dHPn+slRzNb76uudL9/y6dp2TBFfOOop6WqwxPUsBkOzpn98XW+L5V+w0GaqY8UmuCnr5b8pBT3AkmtSSYQelyZz+LcpzUv76KbSx3HF0XbCHywRjNDtTVDmzVrTVIRt7MVtH6zz4CTkgiX9RVr1Cq50ZsDSOpIDX93IKnSgyPXWgopAuFgtvZSkiZWyvQpJKB+wLuJ6HzBBedOJfaWVLIoOh3udlFFZNSbFMs+WOrn7nOZzgKqJ9b3LxY957+VM2foId5QUzFhfprWIiQVxOxH8A+iAdsRY85Q8D2vJzs97yLb3ugLcu+OBP/R2XP76g7rbw30lEZ7bYNzr5BinmfrlT0uL1Sp4bzJ0E4W6OsfgzCOpGYBRM4vkchJ4sRnLpDr9/XWEUlSkPzVkZgZ4T/H7Z9LdMgYM0oQnxBydrslpcDSj6pt1iY8elloQ8Hb8EVJjwQkZrrRfmfH1esSlZ6X2/93TkYk1E7hJkZCHGWmnFNmOXdCg7dKau8x9qtpnB2ZwZR1KEQlzIZo2huk+aJopGhwlxGqKIUDvJVtVuuGQ3Ph628IQFXWijpDI1IieKzwnxI4LUVI7P5RTyiL4MOBkjrT5O0EVZ6n7GHZRfkQgIP/KbC1eNcYGjzw5y111GY0RvT0q8O8lsNdlkezoP10XrFiWXMXg+zgf6Xn/gf3uMIcW xiXL/vvk qcM2MwDMCt/BhtgrAeT4R6Giq5NIckstOwQ/dZTwhDqS5T5w8PD+DLvEsiv1irXqRFR61NneJeJfdOVtfRyNzCNuE9kTrLVv1WN1FoKPcQvDCx2n+rGKGVFXedSGuleeHwSdCuhny3MfTgznXyYPSWYF0xR3qnaaJBXTnmk1l2wkemz5fzmAUxwD0XMp5FRg5as+DWEZ6d6tw2kLUUHJPT2ZOCpyfXWiJueiA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 09, 2023 at 10:02:32PM -0700, Hugh Dickins wrote: > pte_alloc_map_lock() expects to be followed by pte_unmap_unlock(): to > keep balance in future, pass ptep as well as ptl to gmap_pte_op_end(), > and use pte_unmap_unlock() instead of direct spin_unlock() (even though > ptep ends up unused inside the macro). > > Signed-off-by: Hugh Dickins > --- > arch/s390/mm/gmap.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) Acked-by: Alexander Gordeev