From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23E30C77B75 for ; Wed, 17 May 2023 06:23:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6C27900004; Wed, 17 May 2023 02:23:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B1C66900003; Wed, 17 May 2023 02:23:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0B55900004; Wed, 17 May 2023 02:23:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 93CA1900003 for ; Wed, 17 May 2023 02:23:02 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6B161120486 for ; Wed, 17 May 2023 06:23:02 +0000 (UTC) X-FDA: 80798754204.08.000F7B9 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf06.hostedemail.com (Postfix) with ESMTP id B9143180005 for ; Wed, 17 May 2023 06:23:00 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=QLDKcIxh; spf=none (imf06.hostedemail.com: domain of BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684304580; a=rsa-sha256; cv=none; b=1q3+beP9hbVAw6PTUCGko5bf9YRFwMPkaz3duFcFVt7mC2lhFT5ilh4fhdFC9WlkR6+yuF hItbXgiqn0mjJmgZMHTynOUTOa4OEgadFm3XBucSF4I1xlg1KtZKxgUQYOe2F+mQKe2kCP zmthn8Vk3sfzgVd1DyK9jv5L9y2YQe4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=QLDKcIxh; spf=none (imf06.hostedemail.com: domain of BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684304580; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6Yrk/M1EbXl/kX00xJrpSXS6oPhvx6jBCa0pOVA/Fvc=; b=HJ7BQLjGpAJCJgXsns63jLAlHPT1yQL2MiuCFiSYxOMQ9/vc/x2v3SDpUc0Oi5PNUu8VUl Al8N08a0S5wEWQGS2Y51X1vxZx/YIkCl1/AAn+TVIc45cKrfsAgHnIXce1oVGWYSZ+l/0N FBk1SuVjhnGzb0G1topjjrTeDBxuUs0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6Yrk/M1EbXl/kX00xJrpSXS6oPhvx6jBCa0pOVA/Fvc=; b=QLDKcIxhaZeTjAcqCHut7E8taM v7znFgRP6KTVpBFix3YkEYzXxV40cbqE+nriHreHGbeq1lVmYHPi9gbGyfalBYM8m/kJRf29g2TGj 6288yslVoRO2W20wdV22BmtyVcK5CbVSujD6TcvFeIZzdYpF+plAfgYIAThSlN2gvTcFC4a+uAt/4 HNmGtNjgjK0Se3xZA0LoYQ9Y5cgnzmKumNV1kq/ACjaORyilNCwsGOrbZdk0ULsLamcM+t0dEMI1z nzK0Le7jU2Sp+7r+boAnqrz6EUhmfqY+HeAA20EJo41stcXNd3CZctwDtd95HnD7vM/K15OR3U5BP G0cYmEWw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pzAYq-008QEK-1i; Wed, 17 May 2023 06:22:56 +0000 Date: Tue, 16 May 2023 23:22:56 -0700 From: Christoph Hellwig To: Ruihan Li Cc: linux-mm@kvack.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Pasha Tatashin , David Hildenbrand , Matthew Wilcox , Andrew Morton , Christoph Hellwig , Alan Stern , Greg Kroah-Hartman , syzbot+fcf1a817ceb50935ce99@syzkaller.appspotmail.comm, stable@vger.kernel.org Subject: Re: [PATCH v2 1/4] usb: usbfs: Enforce page requirements for mmap Message-ID: References: <20230515130958.32471-1-lrh2000@pku.edu.cn> <20230515130958.32471-2-lrh2000@pku.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230515130958.32471-2-lrh2000@pku.edu.cn> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Stat-Signature: 5gqbxfoppizxmhx5hcw85h44pd9nsdj3 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B9143180005 X-HE-Tag: 1684304580-105651 X-HE-Meta: U2FsdGVkX1/jodJrO6dVs01uTGX+WOKuvOdxMYay44L80cHpAI/kVAIygjgE4rFmt1tBhCgNFHMtCLf87Vctj6sAwk+RfqtkGIIDZUW8kmCOtRwiFEXaWtG8dr6+Bw8Ti3S+59l4MIVtYAXFBIL3lIk4PrkV1vVEzdRWJ+q9TZNBP0uhpYPAM/9wq+OndFqbOJlspzOiPPyEEPlToaaNVWFzcwZ72pcW6Q4w0z6V6j7JF2jckdly0WuejUkn+RqNHtY7Rln+W/fgf7F79vXEIPFxcSTB//TEPKBkcX2/cpm/fT8nk5/pqzTzR3Gj345J2DMwsRho4F2Kh2sH6HqrNOLrWiJg8b0N+qX4F+cnP3urM9I74zo3ito4opsX2QVYwnd4KRls7SauBvxnxHwH7D/bOzsfqWEpGt9w0WTtx/OyNT0wBa8lWRtzZ/HY/FRZOgu/z45oLposcKSbptI1OnxyfSaGP/rjZQuMSNmVpbYSYQLJwJGsxe+kUULE5qUZGKUq7ymfwB96JrrLqWnvz82XH66hXRK6EkdyURZXjhbcKGqrT9XGmRg6NvQPLRB2fTM69/SabCCiIdLb6/lIXSvXjTY1JKHCMHTXMjsQwKvduEBwCVeqfjcc2xOO80t2t00GvvCvriMmye2mBM0L5aM2pBK/LNYClg7/et97dZPLXMQCuJe/ktwgn/weC1Zd/aOV5W/UzJ0BKJQtfxJv3w7UJy6k1bLHW+sGvgumrJ14GjN6iInb5XgjSToLfbBPVyrkNZ4TCshC3Z+Kn6LPhf1AxvZZXqZEsCCZHbkdaEOGz9h/xeS8Lq6pccSYIzzf9Y9SOCnNhirmennfl730cdZaI3VNxavc47SdjSg/Xk1x8T3GsNAn6ZDiINUqa2Iz8f0tUlAb0PR2Ve/xdDSpjdK4/BGNTGkx3NPDlxtH9ibn17a4js+6SxPj7H2ZZNo+tw2LTf4/Hmc+xrRvWPW 2QEBFte6 iqIKMdQAti0mLcFQJOLUzbOdbCopsEAiqmO3o9ME0XCA08kzjmhvXf7FpOy7zxsi68PQjiaxFl+cibY4eSLgs0b5Dm1UbpCPKN9WC/oRLir5uEb/+goayuPdLbOHASpT6PzdoA/oGmgTrXku0yIZrGkJVWvty5jNzRsfV7yt3sRTzK1gB/MKV5AQj6NV2DiNl7XEYFNPCa84gYykuiUqDUK/JUCSUqEccfgmzXQaLNDBZvoyu/xkTvrxemyI5ZNEOg1S+91EgvgS8xEGJ+qoCMkK5IM807rV72+yBImY0R8GjHJeqEtfQBvK4uX7bFC14iFdmDmbThkzWXu4cMSr4akTWc3gUjVcjEbzxadP0wcuHMUQCLfBYkxCSWeOP5QJgjz4dr39wNstcpCAAGezuuBPyVoIpOa2MrjXsaYK804RNjFfskwK+ShDreI5TJSP3eOE54fcz26hFGKXBAYFnS0d6Hq48zrhASRHNfZXQ4P5jw1U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 15, 2023 at 09:09:55PM +0800, Ruihan Li wrote: > To address these issues, this patch introduces hcd_alloc_coherent_pages, > which addresses the above two problems. Specifically, > hcd_alloc_coherent_pages uses gen_pool_dma_alloc_align instead of > gen_pool_dma_alloc to ensure that the memory is page-aligned. To replace > kmalloc, hcd_alloc_coherent_pages directly allocates pages by calling > __get_free_pages. This looks reasonable in that it fixes the bug. But I really don't like how it makes the mess of USB allocation APIs even messier :P Not really your faul, but someone really needs to look into the usb memory allocators and DMA mapping, which is tied to that and just as bad.