From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B41E2C77B7D for ; Wed, 17 May 2023 06:20:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44147900004; Wed, 17 May 2023 02:20:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F101900003; Wed, 17 May 2023 02:20:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B968900004; Wed, 17 May 2023 02:20:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 100C0900003 for ; Wed, 17 May 2023 02:20:18 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CA536C0431 for ; Wed, 17 May 2023 06:20:17 +0000 (UTC) X-FDA: 80798747274.20.DABF014 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf18.hostedemail.com (Postfix) with ESMTP id 2554E1C000B for ; Wed, 17 May 2023 06:20:15 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=lCMxRrDH; spf=none (imf18.hostedemail.com: domain of BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684304416; a=rsa-sha256; cv=none; b=jrVzg7g3AuFLlu05PFJMMo36KBxfOep1XqpRG6dJ5/119/6mvzuUKvMmBpHJg9Q/WA/sAT dspC6N5rtiv3nsOM7geEM6HjR/GKda2W6qe+r7XESZw2iccuGDx+yjnYcN4gcd+CajEb+V gtz4mLtKPx8Tho/cXYgRssaWUPF1Sgg= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=lCMxRrDH; spf=none (imf18.hostedemail.com: domain of BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684304416; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Uiam3MV1AIHx2JXhBYlardHpiKPPLXRwMMxlhPQWj/8=; b=xHQ4ziktqPeuf4KssOW/q74Nbkpv4qrjdXhBQS10v5bunrXi3lTNG6Y2qB19Zb0r6UAo46 +Av5INICkVdpdb2pUUZGUGtUY0boEFCQz8S30GKrS2yQ4ATHyJCmJs1AAtaIIT0s1+u9t5 k63cZq9cdl+j24i8shiRiQyOPpUUGEA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Uiam3MV1AIHx2JXhBYlardHpiKPPLXRwMMxlhPQWj/8=; b=lCMxRrDHuojZ0UPd/0UgioRB86 2fhjUmfD78FcEyAu/uz3qh+YysEvBlNn3xRL8Tsf6EbZ3JjOPy6WMGzZ6RC48vvcs2bufdXIbItkI QKDCuWVkywiVvHZ+0vIGTEaNwHLPKEoKjT+qbxKoNaOVlewfVtaLHA028AScpKU449bGeo8DpmSq4 cQtDOvl7rY08GfxHMJlOMTuitFwEx8Tde4zleVg3eoI6f+RJX2KGDrRE5MndVj+WaA6OXP010uY55 3MqslUAkzi3wJzPq957lHtT+WX0rw+ZkskTevkhRhbJUEDcY6KS57uu+alDGFxf0qPsuqmi3hmEFe v57ygwTA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pzAW7-008PAq-1I; Wed, 17 May 2023 06:20:07 +0000 Date: Tue, 16 May 2023 23:20:07 -0700 From: Christoph Hellwig To: Lorenzo Stoakes Cc: Ryan Roberts , Andrew Morton , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , SeongJae Park , linux-kernel@vger.kernel.org, linux-mm@kvack.org, damon@lists.linux.dev, Christoph Hellwig , Uladzislau Rezki Subject: Re: [RESEND PATCH v1 1/5] mm: vmalloc must set pte via arch code Message-ID: References: <20230511132113.80196-1-ryan.roberts@arm.com> <20230511132113.80196-2-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 2554E1C000B X-Stat-Signature: zium7q4nxij8fasxprj9cfejsyd3e6ba X-HE-Tag: 1684304415-302146 X-HE-Meta: U2FsdGVkX1835irHAxcImtooYIKta5qqGhSuGtRyjGXupnWnp/+ADdMW3U1Zdtshx/YTJVshJfiVcxi7S9qw2dRc6ju3HYnhHg4OtMdWNNZowzmomxpf91/3OczWKlPTmwA0ZN29TtrTI4dVQg4Emgmc0UMTbKGatB3cAOnLuuiP45XH0A/BkRW8rA97L5o6d2H14ecqwzBkjBphxWk6i6oJ0IHm2geZ+hV/PGjoLDP/3D/mmJK29lh974uQ8wQ3qvGphSb9gsjzVpTre68qEStZIgDG/RHUBZ1GiOE6mI4q+tyd1Zemlypy0/CaUsIr+m7kOlldWZG+XauNQjEmmLS7wcyJZ5BWXGO0yYgI1EkxIVvzPdecCaj/1m73LziPZrSOew3jS1FYvvAirJnfQQ7qAS96EkE3dCK5IUfFGnUwo/EXS4sX+hjB+HUgjS83a4acVyxfc7cCdQxoBerhd4hAAtEglDL9jISG8Gk4a13XGGl+M2yMliZJRBxyNY8NgifbxXoWgWiyaa2Wa0LBW2LMXB9z1kzxXQW84sg76yFJ6scw8PzFRM8odHZRFo74X/wSyilwlZvxQrDojbxekrTW4qQKJr14X0nYwcBPAkTqSZyYChTfeKtEa77MdnhbQicooU+vk2+8EqaRY/x/RsNFOgsy5poA9/qQyrF41Ju9meszhDs73RIiHAG3r7Faj2QNdkd3pJee56l8obyxNrBxPPkojRnCppBPxhNn4sohnTUN7QI1wyAE8ftNMfRdBBp1pmX6aoemSyVuPwFlp4808Fl8iEUzLdyH9yZ5M31R/4a6/6MfIPaw4+kCtSZHa6JRLOtgmF+/Ys3k2h6AQNp2WFe7fXIbXtAVTPyKqSUHOdB446uUYK2ECk83YeJ8NLx49ibssMwByiEBrrIPK1tQFwQXcC988zpM1FvsKz67G7v9TkD/8mrbet4sgIxsDMNEP8R3RhFDnBhAWR/ 41Ru0Zph ME2SwPw0nHnn9Q8X20PLFbJkHlC6FUyR+iusKVxjXHZ1lMkPLN0Tj5znzqNGPDVCt8jIORuBOAbCB/F3r/N8AOaUE9fGAtuue6naSGUrfeoxfFAsN3CYRQwhwCBT41Lbx5dA8qKOVJ/vlb0XOOGRMOj8FeSQxVUjNqCO+iI2oxeWFQ8D29Z/eltViHfe/IA6Tx5oFiYA/AKjtp4/uFAiDztBdctqg+RGkHJW8b+KG+TIJCwodqM5ZFImJCVcuGHjzEMqKV3YdZCL4WDASKh4TQHXbz2UImsXSuKBgIo0KOyBGtXo5KUC5XASUEiOIvlTfXFq1Y6gybWvAovbqhBIasfQ4L/PdIAWdjcZMpsT6OB35l4hVu0BFzjn82vrGjyYH77Dtiq04ni+9Xbo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 13, 2023 at 02:14:18PM +0100, Lorenzo Stoakes wrote: > > Fixes: 3e9a9e256b1e ("mm: add a vmap_pfn function") > > Not sure if this is really 'fixing' anything, I mean ostensibly, but not > sure if the tag is relevant here, that is more so for a bug being > introduced, and unless an issue has arisen not sure if it's > appropriate. But this might be a nit, again! vmap_pfn was factored out of i915-specific code, which probably never ran on anything but x86 at that time. Now that intel builds plug in GPUs is probably could. But independent of that core mm code should use the proper APIs.