From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C023C77B7D for ; Wed, 17 May 2023 06:18:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BE01900004; Wed, 17 May 2023 02:18:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2456B900003; Wed, 17 May 2023 02:18:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E67C900004; Wed, 17 May 2023 02:18:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F0012900003 for ; Wed, 17 May 2023 02:18:54 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BC85480472 for ; Wed, 17 May 2023 06:18:54 +0000 (UTC) X-FDA: 80798743788.17.6579808 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf02.hostedemail.com (Postfix) with ESMTP id 88BD880003 for ; Wed, 17 May 2023 06:18:50 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=y7xtAHQV; spf=none (imf02.hostedemail.com: domain of BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684304331; a=rsa-sha256; cv=none; b=Ru7cX/Pf9U5xpPtrX2HFNLokf3cD1kL5NFLiEGfZ9QJMePm63OjyTIr97g6RxuCETUKOtb c0jlBwZaz0rQkh57yIVoe0MHafL1qI6/Uzn0t2jfF5zCG59ST3u7jwKfGjmffYb96qDImY BaAg1n+M3wnShx7hbe8RhO7cK1eox3k= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=y7xtAHQV; spf=none (imf02.hostedemail.com: domain of BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684304331; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CG6yKkcSAXmTuFHjKJxYYVG+vMb17/IxBz/Znck1z2k=; b=ppgvx1slZSzrOSZ8O2xEca0GO4y7HbE2Su4s4/IL7qzXj7LStlvA+0euyEtwlQshyqoZo0 O5cM0Rdjjh8luvqhmCQc+teIqmp1PkBnKCkhRe/pjQCey23sX0IBzKWjCHFdNGqhhjZ3bQ z3OusjKv2rkRZttyFrvIqV3lnrih5I8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CG6yKkcSAXmTuFHjKJxYYVG+vMb17/IxBz/Znck1z2k=; b=y7xtAHQVU4tkYSmSVfuwQ0Jnrs iPGaJm5VeifNYA5qMSu3pYT1HSgqq/ztIxbl7aayvuqu52zUcZIk1CjPNlAbv8tkr7TreZYy2YlV3 f/D6z0pM94aTlNkwPKalADYYdsZAGP0inNu6uV1delhWWc7NzZAMQSnQABk6rnUZ8Ojo9ySSNTTg7 ZRJpngPiWbzeTcTM7k9uVqUdoW5CIMWMIsNYBGkDEaIl+XEqPdUSL0JsENdFwz8WP3EuAbYzetMY6 Iprh1KwSO2y5Vl0ILl+2jw/1Jac79IYg6HelJ6X7eTNS4wKBXvWByYtXX0O8ogv+NAb/0RY63dpQY GH37AvaA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pzAUi-008OgF-1J; Wed, 17 May 2023 06:18:40 +0000 Date: Tue, 16 May 2023 23:18:40 -0700 From: Christoph Hellwig To: Ryan Roberts Cc: Andrew Morton , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , SeongJae Park , linux-kernel@vger.kernel.org, linux-mm@kvack.org, damon@lists.linux.dev Subject: Re: [RESEND PATCH v1 1/5] mm: vmalloc must set pte via arch code Message-ID: References: <20230511132113.80196-1-ryan.roberts@arm.com> <20230511132113.80196-2-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230511132113.80196-2-ryan.roberts@arm.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Stat-Signature: t8z85dnimj8ws9p4i83mbbto1uq76578 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 88BD880003 X-HE-Tag: 1684304330-815545 X-HE-Meta: U2FsdGVkX1/ktbGY5GcvZBLOrwRt90ahQbAxRNxoE7rVYvWaaUybBApEYOvDR1L2sKcTNfPh21QNkasev/OVt1WmfbB/Gxzr0fLJQlEowK/FbkL3GBWhua0vaPgZNacZYBh2F9FACU+h0D4jgUwYvhBygqz1J+k5shXRKIVRImbs923Jwp/GpvTlUyw5f+vZQuKMr/BAxWqkxXvoN4p2fl+pJWfuUhfjJisL1tU3jmTa1CgoHKjIQw7+mJgyA8e3iq3jlFuNb46h3NY+UsUcXHS0ODpkf3K1vC24gGZYyUagDaNueWFmhBCYslyx13OoQmi323QZaF4k/fqqg8RcB8rLAYdTY333OZ8NWkFThau0BaOWMZSpIxTLAp3wopfv04zCWFDGK/r37FdigrtciH2ZSuaOtYyLJmosA0ZFdF9rwO9o7Fh27lZWv/vf9Mn6ew6BT8B4DP8PBBx5uQQB6HhrSaCR78cOVFtxzza8YuCbtGAKIp3ynSag/LJIG33UZi5aT42E/8aWTGONBUH+rOLNs/C/vLsyVOavF4QWvPLWcW3EcpLA7OlxFGr1ZpMKv+bWO3R5cCPlXZn2Df0APKNJJgvbxn47QfaMRDHOBptZq9gEdNI4gjI6Fm3NiUhSZ0yFUOgHlTvRfmyhfRpkuiDmtm7r4r2a6AlNxrW2QZy/5oAnHBp9ma9jpbwOG+1ul2cKVvgznoGaJH3cqJ6HUGuZf5D1c3fyv9StXVdFVRnivcuPYAvmnhAFIS5WIrgHIs2AqyGWKFdSEnTPhZIaA/AqdBOVbwpo6OhgXeM2+DBjHUEzWNiTlB5g0ooyp5T8LIqLqNxxwzTINbIOxPRK17qjqF1UM0Cjw/cBJ6azWg5TpBH28dprz+RP/B36Zk4euVttQv9xbJNG3YvZspU/gzcIta/5D0fySEIjpBiX4qQODUiyY4BNZkTzZ7vE+6dUJkaRP/HK4PfbdjhUj2p TPKNE484 oB2LK2r3H4eifD0IS9BYL3GxK/gaPnfoL4EtB71lhHwlYbZXyPpeFmG5L1+tnTyw8J5++YLedBD5rdLEhFWCP3EiJ7Oi7PTTprnRli09hs2vesvkTyXORm7+4D7BCmWlxUMpzgrEfLCKH+4nfMgmPZ+yyjsyejPFXwUZiOJ1Wqxnc2pJ0uRzkmQmHnRunSsw1tYEpJzk9FkW3yPXoGVB+/hmhnoTr27EXz6B4c2Icdd2PDOvOW7vbtFHQtsnHZZvf7dvX+cq2HunFicOw0B37nhszOeTuX7O5TAK4+pEivU0w9/ygsdbA7Cjl/vPs27Azg7bA/PQnxYIieWRqW6c3kgZ9EmsQ0+n/njA6LcKBtivC9ubVG4jwNDVRiNio6ZiqTg+zGL0GJGQjRBo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 11, 2023 at 02:21:09PM +0100, Ryan Roberts wrote: > It is bad practice to directly set pte entries within a pte table. > Instead all modifications must go through arch-provided helpers such as > set_pte_at() to give the arch code visibility and allow it to validate > (and potentially modify) the operation. Looks good: Reviewed-by: Christoph Hellwig