From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E55AAC77B7D for ; Wed, 17 May 2023 06:44:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 85762900005; Wed, 17 May 2023 02:44:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8074F900003; Wed, 17 May 2023 02:44:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F5A6900005; Wed, 17 May 2023 02:44:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 55D1C900003 for ; Wed, 17 May 2023 02:44:30 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2760DADD7E for ; Wed, 17 May 2023 06:44:30 +0000 (UTC) X-FDA: 80798808300.02.122A817 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf08.hostedemail.com (Postfix) with ESMTP id 73F6E160014 for ; Wed, 17 May 2023 06:44:28 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Ubg7KZoq; spf=none (imf08.hostedemail.com: domain of BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684305868; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BmH0qWrbShxIwLQjFwhKQ2xbwDXtOMyKJ7ZdDUHvgls=; b=g628ZpxbDhb+hdQTeDM0afOo3Sz+qFGPMQuSa8tPqhVJvtBuf23ihBy5/HKWIrt5HtS1WT V4wYaN0FgTdb5tkhfoXbnd7sdH4l8/aKP90TyTk58i6rNeKN4JAJUsuKqVc3B3HwI8gHjh 7H2rhLvKJhSshgSsWnw/++0r/2tajbE= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Ubg7KZoq; spf=none (imf08.hostedemail.com: domain of BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684305868; a=rsa-sha256; cv=none; b=ZMFpfqZG85Knu24ckpDGv0J1UxtQVt6AFqb7DpZRk9SH8mNPGIOoVlUxTXfW2T4u6jCwQn P4yhAY3cSLw5ddElXGwoSM5QVz5MDqtvwHXpd3se3tVkhp3oB1ths8IwlBL+tJplyjHYOG Dl8xTrCH9XoEeyf5HHS54Vi6ITRJlNc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BmH0qWrbShxIwLQjFwhKQ2xbwDXtOMyKJ7ZdDUHvgls=; b=Ubg7KZoqpGLfixImSbIdJAj9En jUqu+kataka3wirto7TkRILjk6/oQB0kQ5w4ud9tT2SXicS3hMqi6wejow4KhSCVP7i8d0rEOmsJe C8evKLeUBrWF1gdyDcKHrBMVdM1MjTovB9f360DHQDrrxZLtEzWGBUitxnXOBlq9Cj30j9WPoIb1W BVuTzcrgBTj9rEQgGlouy/yPASlheqckxCi0JAKWc9xlVqH3CC1wOmWnlJcogAdy03NNNe9Wro/bd 6J4qfSHi8Ff+fXX23LeS7dY5M/OuyfANausaI+0pnqDjake0FXHH0OKybCCQy0VyqG1h4tH5LIn0Z KExUOmUg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pzAtd-008WMI-1S; Wed, 17 May 2023 06:44:25 +0000 Date: Tue, 16 May 2023 23:44:25 -0700 From: Christoph Hellwig To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de Subject: Re: [PATCH v5 RESEND 14/17] mm/ioremap: Consider IOREMAP space in generic ioremap Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-15-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: 9hwzfgpi6oexu8gf511owze9whc31ueu X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 73F6E160014 X-Rspam-User: X-HE-Tag: 1684305868-859293 X-HE-Meta: U2FsdGVkX18dHYdk3/7vkIPFgospIzPAlhoF8KdhCYwcG95m75v5bPMdsHN7t3MshBZPXyMCBgalgo+ZHuf2Nw/ugzOGhFE783r8GsMO3ymFpbbLBhZlsZb7GKLSB01Ds5Qerjo7tt+Hwfb5feZdAuIMAkGMuMGu3se5r0ErclADG/KVbIiRkOwu+60EQmGpDdarT5O4ONdQj8aSRjzSVwwV8xgDM60gkbBnv7AebtCixVuhXhmHLWDtOhtX3NggocVsJTtBlRNgDP0XnqLfwP6uLzOBi/T9ThZFG0uRjQPXl2JSTFboAfln/HMpSmJoCZV3xyKCQeQuP2vdq7i8IqdNw5JC23C9cJg/Fvppzmrc1rSdyIP1NbPVBkbSwf7Ib+P25vDCfKNy/wnFNosCEBDkuO7Tnnhx7Ly7k/1Kh7IWCR5mF3rpQUgOOxPomuHNP6Z6ewyDjE+pHP4DnoCcppET6FnEYn2afebCGcIhqcrLEeiETo7sWwrSVB+hdjgLYzeTq9fhed0tzNl8ulcwO7Oc7XlEP6+ew0tbHwQHTPFXLQ4SXzPHpRvhRauoSM01bkxVCeNOSL2nOZ4SRl+asJJlR1FwJXOa0WK5W96ySyMQJgYYnCAWeC9P5keYHzkfVxTmKObZh+4bo+TK6YsQglqyTFgnvH7BdRcD4fmd3LHrf/X2M+ZpXb6wl65yn0UWs0wtv5X2fwyhKszyUmRBzudPHWcx6TSlhU1F1Vu4/cmTn1Td17OsBZA+G+TcKR7MiIOks7C1qIFhHTdb1s4htZgp2aTiJGsLmyO812k/c7D6cZYGUtCeHJwiu1v8UqUGrCdryzq6mCI//hTmAbq80TlWhEZK6/Ehq/hgtRN3ecMQpwvfLv3Q4d8CtjotTE6Dz3Jz4esvX1GLysPunrBw6rhXG5Oz1pz5Xs9Mxn4i+n1Qy4BmskIBQOa75+7VZXwKxtyRcUZ2mchHRhj8407 Ma9tU8j4 67twOkfQpxDtpgSQRxhIvvEp2p4Y0wT1UvruKJXMmc8SQcqmW5GG61ioTEp/y6qvFG9PZth2xoOMaj2n1mdLxwWNVHEMbFSQKOzL50Ys7ukYFFx3Mt+0mMKravCf9hVRNuujFy7gBjWIgA6jUJ6V0n0wNXrBMjFgmBNKdI5hv2XpmaufMrpr5ijhU7g6IwWdvPmaEEcThfbUnIlWYpSYIXSHqW+FwpYi7dkKAgD+iE1VWokMuBHNeIvGkfGILuREHCuEHYIs1IUp6hKIUfG79+NFYZY2/3ZrckBesZiXGzU1ivLEUk2rcofwLZWiaUfLpeO9ASBdX6Z9/uagzgQmAb/p8tg76IEJLk8jKLjXPSH4kne5p/VkWTS0xmacw2RMr5eqVsWw+caJ0f8A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 16, 2023 at 11:41:26PM -0700, Christoph Hellwig wrote: > I think this would be cleaner if we'd just always use > __get_vm_area_caller and at the top of the file add a: > > #ifndef IOREMAP_START > #define IOREMAP_START VMALLOC_START > #define IOREMAP_END VMALLOC_END > #endif > > Together with a little comment that ioremap often, but not always > uses the generic vmalloc area. .. and with that we can also simply is_ioremap_addr by moving it to ioremap.c and making it always operate on the IOREMAP constants.