From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00023C77B7D for ; Wed, 17 May 2023 06:41:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F44D900005; Wed, 17 May 2023 02:41:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A66D900003; Wed, 17 May 2023 02:41:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79485900005; Wed, 17 May 2023 02:41:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 672F6900003 for ; Wed, 17 May 2023 02:41:31 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 389A8C044E for ; Wed, 17 May 2023 06:41:31 +0000 (UTC) X-FDA: 80798800782.30.90C6144 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf21.hostedemail.com (Postfix) with ESMTP id 924351C0006 for ; Wed, 17 May 2023 06:41:29 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="z8bR/V26"; spf=none (imf21.hostedemail.com: domain of BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684305689; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CykYlbUyBmsKpsUHUyxIc0LEz/CT+ai84PogzOUldYA=; b=SDybAJPxH5HxoNcfErDwnsQ2zHLahkv9HQ+TRVP4ad4bGsuvlOzVADydXDn7ChgDJgSB+0 zccVdPl3RN9bJ0OZtHhbeGzDnehwvRpeCW+xjtmPlL8GUxBDKR070cf62Ctngquz29Us/P L9+J4LQ4a7V9G1xkw8TVI2S6d3flof4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684305689; a=rsa-sha256; cv=none; b=GB/eWWSHIy2VHTTpmpkew0uuo2gJXcMoHP8o+K0G8fq+54iYk8IJn+/XYC0b6ds3vqRWlR 4OT1L1g/tmO2UKfjeX7NV9VdD2vmhFyceDdRAlN44JHex32PYD+1RK+IDEYsoME1mjphmQ BxdUT3vF1GkdHbqf3iOJDvBnknqpAVU= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="z8bR/V26"; spf=none (imf21.hostedemail.com: domain of BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CykYlbUyBmsKpsUHUyxIc0LEz/CT+ai84PogzOUldYA=; b=z8bR/V26LFSYbui7hpcGxPXyCE K+EqwK9dVITZUK9ukOXcaCWNNfqgU/KJ7e+JSCtIYcclkNbCis7+uJttuQhRKsnowxuzFn7m90i5Z qpB/+Un0orP8guRw1G/iwV5dbOX2VM546ecPbhqW8x6IwJf3SNklX5TKwn9pHv3a2LA1hkY9XnJNZ JyXI5Y4ykRsXoWTmdqa+Plc7H5pwYJe/4yypbhfmmdx7q82Si9rYhA5yYz7NKUt899gqVYeZojZlG lHRgh1cB7UlHFbktMnNiCTo8Lhp9rT0fGHGgFJHierOjC2gX91Gw0N6y01Ot4ruNsAxNxaO4QSrFu cmNo5kPA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pzAqk-008VgM-1e; Wed, 17 May 2023 06:41:26 +0000 Date: Tue, 16 May 2023 23:41:26 -0700 From: Christoph Hellwig To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de Subject: Re: [PATCH v5 RESEND 14/17] mm/ioremap: Consider IOREMAP space in generic ioremap Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-15-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230515090848.833045-15-bhe@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: aq6idjbmr5jzbz11jy8yjt9i76hiify3 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 924351C0006 X-Rspam-User: X-HE-Tag: 1684305689-253882 X-HE-Meta: U2FsdGVkX19mdU7W7WWWKvsALZxhLBVPHKKsZhzWCRg5Lx7331UvfUXc3gOseW1jcA82rBAvwGF94qeYOYvOF/uZSUTg2zNNRcRMNSRcgq66AalkuyCLIHuhpRrGFS14wa4mfLsgoGyBlNwE5bUD44Sk+4+bDb6YWWMa2P8a5G1Tjpg9dGFHtjTkui/dj3WYcyKKLnsf9d67ElF/0DQsCCkDAaSLGv6zQunqs5VbUcvz67zf+FHVuohflMyLtKJN0cjrQwPGWpvUvS3+qUAMz0xDoYFdGS2y+S+tPn0N4l1FgeG1j+lWIgl9eeU62GxnS+YsYYrsnk6l2VAOTy3H02vcQO0bQYv7watLZw/H52x50kSG4PsRAeu9u2cvINoQikeoa6D7b38mwtnKMug0aeiboFiynj4ptiwmKs3JXrqTpbQ4CRiT2QvcKHAC0LCja5P6Bzfx/rbJ9qYDdjZdW4Q+BubucQOffeGKMusNaIzmVtmeW533LD7RD+icQIAFOSA4+UxmnNrkV4p/XMT4u7sL2P4RAV9Y4MjWKZxFZQWk1uISRR3T/DBtI2/WuHcAA0B/QIlM0MPlEbtWYw9F3mpgcPw4T2upNep1a2RGE37+wm/mKXmZf2ottuMSfBqdHbDyboQ7NAGigunXzvoz49rQ1ZTXmzZMg/N+ox+22/TlzzgyKffxYEjlnbX6zTopEN31sPnHrxfGT6W1NXLnEoq34PmXmAakoEkY9qyj/OhjyQGDYC3IZXuUqKkkkz3LXovBwOq42OM/ce7jnWiPYwxbLe0Wevrr21ekYSVeJ5ENkw2Aln4NpKGPSVYxE1kpkXur4CNp8fEohN0CtobUv8ieRyGDXdouMWNq8tHLeWEpoK2zVqGgl0KQsAv/9+2wsCbT+Zt1bjcGeq1l9Tx1L35YEN4x+nHVoLxZBrhXRccrHeiYxLsWDb0onazHvtnvHgYNq2RLGVRMFOWLjEn q69fcJon MUtVN5/QBOeQ2g9ZP82wLLKQJBP4c5MzT2DBC+1ZrvSD2bKzE4QxpCKDHAbztWv5MEQZJLjugE9RemMKeLCIlOCGaAWgasGQxFT8OyRMZVUqRELyd1sMV12TuOSvOjDpmtDBbFZkC5i7HFEwU3At75k7O7BixqwST/A3tPfFAcUrsY29EmSVXXgcu7/Zen7vJgRkANmKyIg4FaJ5YryiUWDaE81morsMKmgJLnurkZ4AjY3gW9PiEgV51oZlxBSXPxz5WpUTMMlc8q46/QcPcxbH+wsl5yeJXZgXzt+KDOvPjUKWQG1WdOR2Iy0WbF8S7sVZq65wjL7nX6+83jPBPiSgnUqOYjq2fw7zl8gvhL9VhlAgbNhTQuNMDANXyIL2OsK6/UzAcgnlDuOg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 15, 2023 at 05:08:45PM +0800, Baoquan He wrote: > @@ -35,8 +35,13 @@ void __iomem *generic_ioremap_prot(phys_addr_t phys_addr, size_t size, > if (!ioremap_allowed(phys_addr, size, pgprot_val(prot))) > return NULL; > > +#ifdef IOREMAP_START > + area = __get_vm_area_caller(size, VM_IOREMAP, IOREMAP_START, > + IOREMAP_END, __builtin_return_address(0)); > +#else > area = get_vm_area_caller(size, VM_IOREMAP, > __builtin_return_address(0)); > +#endif I think this would be cleaner if we'd just always use __get_vm_area_caller and at the top of the file add a: #ifndef IOREMAP_START #define IOREMAP_START VMALLOC_START #define IOREMAP_END VMALLOC_END #endif Together with a little comment that ioremap often, but not always uses the generic vmalloc area.