From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0B12C77B75 for ; Wed, 17 May 2023 06:38:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C1CF280001; Wed, 17 May 2023 02:38:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 54AEA900003; Wed, 17 May 2023 02:38:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3ECF7280001; Wed, 17 May 2023 02:38:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2C286900003 for ; Wed, 17 May 2023 02:38:00 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 00CE4AD8F1 for ; Wed, 17 May 2023 06:37:59 +0000 (UTC) X-FDA: 80798791920.11.F05FD07 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf23.hostedemail.com (Postfix) with ESMTP id 62999140016 for ; Wed, 17 May 2023 06:37:58 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=xPmECXDU; spf=none (imf23.hostedemail.com: domain of BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684305478; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JZ0E1cXLrZ9bDAe2GWQiXJ8aw7kmRqj0VQc5spb/718=; b=3rWiSUqT2wnzR9nMbBO8M9cBixbM4lQQ2/Dw35Q11l9RfPCBtB5tOqrtDTC3ZyS3nesDBN ASBbyfd0qWsKM6mppC7i96wtR92NYcgoR1KLVqbTnkK8oBKDNHlSxcjGSElin/D3U+Nont s1adzOHx3bY/ZNUDgCpG+pOrjHR9lcY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684305478; a=rsa-sha256; cv=none; b=xEKJK67dCWzQCPKk6F9+Lr7NNBArWNq7dohcq+Oy0I5Yi0c5q04d/jwZeknoxbWKg1YpyT 8dyOP3pB4ezP3PHAeqnV7VxaGZEQofQdviUJeLIlsiptq0PoLULiaR4qgEzcmw3oC5W74m JQduS6HY1yewvr0gNkzuteP7xFp7deA= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=xPmECXDU; spf=none (imf23.hostedemail.com: domain of BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JZ0E1cXLrZ9bDAe2GWQiXJ8aw7kmRqj0VQc5spb/718=; b=xPmECXDUC1tRNxXSHQpqDQApvL eRpHTc/0MGOkKNqgGS/gFUvRnEEDpb7ZDNFJnNPShlgH+oB2VRNIYChsTMxw62ks9bJek3pO4kpuT CQ1j+NMds2fUrAm6z84reZ7Ekj8NadfqtHtYqHd82ayEXfk7viS5YTXp4J/08PTwIzxF8/1AO4+qG 5zc4xEkZlwPQLpjv1PX/kJm2aLmgVjoWEAGCgJ1Ioi6Iu/pyNKAIhSEn1ykiLwieOgSZ89Fspddz5 jaRyLSaf/2K91BPZRjBFG0CSmHTB09dbldytgeTQ8dSFLt/i0kwzBJoX0Yyx3mHZF15DTTHemvk7Q gvTn0L3w==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pzAnK-008UrG-1E; Wed, 17 May 2023 06:37:54 +0000 Date: Tue, 16 May 2023 23:37:54 -0700 From: Christoph Hellwig To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de, Yoshinori Sato , Rich Felker , linux-sh@vger.kernel.org Subject: Re: [PATCH v5 RESEND 11/17] sh: mm: Convert to GENERIC_IOREMAP Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-12-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230515090848.833045-12-bhe@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: zjy3zpsajmwmedea7cgn17uwdzoe7dus X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 62999140016 X-HE-Tag: 1684305478-397687 X-HE-Meta: U2FsdGVkX1+VuA1N8cfQq80ZrMo/xnbKqKk1MDTAJriEOgkX9EcdDpuH4S0aFs6Exl+zEitWjXdjS6fZdfErMUpSnWnWMQnjjVb1Hd1EZ5OYm+3bJiNrez4tQ7i5PWGg8g/kCfTru52UPiCs+2pk470+Ps0exunXsXYqJSs0KaSJwCXh84x2q8l1JfiVdXPsHVpqNGTnJ//xAcCw7JNuZltvrOGbcl8meJBCTI6RhuFWawTTWcFD/U5chH3+f0RKb6NTJRKh+xLVeezCW1Iz26nLKdMiHQg48PdUYHO27eNWGma4fSZmFLNZtE/suUPxVqisxB5fww0dLt0XKdens6+dnosdzyDjyrN7QXATHpxwDJ7ePQtQLEXBw/bcPrXDeD1+6LsEUgL7SH3z8nmKMxkcTNmGCZX1OXcSlzaP7BEPHfosiOwA8Pwxof6x8E3pET0tgwBVeY/YVk78emqHyi3vkjiMURbxavn0bPkLtev2do83SkWSlkbqnv+iDPxQEfSKCtJQpF2exlKAdoq8SkpfrQdqpnyMY0jkc83jL3k3nmv3AJVrjWnjU1SBcZ8BMAhpIR+ickxQNoc8Vq6PpzGIfdoW0mPXyrkrhHvHcfNMs9KXKaQgFnurb1EgivoSBnOT02tR40DOKsnYCNHt8DuqDbZfs8MvcUtW2+gSY4AWY2ZnsrUmL0Zu3w+wsuZwemDiArA4LemyxcppHOjProKdr4H6T7cYnpVZAgw5c0qyaUjFHXsKwrRkyrO7fkRty/ccxSehYo+lakdsigDKQG+x/SIw7pM0BlIkt1MXVdGPW03UKjkxz29y+RlA3Zc75uRo/+yx7dep01ggCtOkzM94wt49QYRVHkUB0HQceyXyxH4Rou0HijkxXx/X8FNjkV+80v1SNW6QBNx2IbRI+aVnt0kLCuSbscki7agSv4ZHoM7BoPAtZY2Q9r6cHw07w/cddtX/M7x/aD4WgUS b+VU7E1i xKRetSZ43HGm9b9xxEqFoVzMLn1n+GC31b6YDXLCU7QqTmGj0V/Fpa267iIy6mAiD8m3DS9AWTd+g2XaviHtdIjpUjZOWUR8z6LQgjZ2qkfmhsMcx+RiZFCobqSnWTeBgfHEIUsAR3wuTrhDlvkltuSVX5IMh7HrSDpDFLIAfjpLdAbwKVYAMLfgOh8Od3h7mbHPiVGaG6Eyn5mCdKjY5mHrssDGVopfyCTktHYfSYHxY+HeebVSDgqvdutmMd1tzFSuy5JvKJ7VM73FfuBlnLxSretdGs0d8TCsXoMt4GRdLOpUJ8gA7tLJ1sKsqsP2fs0cyi/Sz1tdwEnTwYcedJSinGJvyqGRx64Um3SHrireg7gz6E6AIvcziVe+pM0R5B54sJMmmnm7tyiMhJl7H8wip2Rc2Q/rpYd7FIpJtczKGPUrFJDbBof2s7Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 15, 2023 at 05:08:42PM +0800, Baoquan He wrote: > Meanwhile, add macro definitions for port|mm io functions since SuperH > has its own implementation in arch/sh/kernel/iomap.c and > arch/sh/include/asm/io_noioport.h. These will conflict with the port|mm io > function definitions in include/asm-generic/io.h to cause compiling > errors like below: Please split that inclusion of include/asm-generic/io.h and redefining of the helpers into a separate prep patch. Otherwise looks good: Reviewed-by: Christoph Hellwig