From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 309BFC7EE2A for ; Wed, 17 May 2023 06:33:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C51FC900006; Wed, 17 May 2023 02:33:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C03F6900003; Wed, 17 May 2023 02:33:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF4DD900006; Wed, 17 May 2023 02:33:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A0E2C900003 for ; Wed, 17 May 2023 02:33:11 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 29BF314042F for ; Wed, 17 May 2023 06:33:11 +0000 (UTC) X-FDA: 80798779782.18.A20840C Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf10.hostedemail.com (Postfix) with ESMTP id 76E3DC000E for ; Wed, 17 May 2023 06:33:09 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Izlvxhjb; spf=none (imf10.hostedemail.com: domain of BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684305189; a=rsa-sha256; cv=none; b=OrdKo+xRx6h+hFZ+XVADR1Zs4R/N8XzySS1gGwJb7wRCxvKH2FbUsXXlgHnS3R9l62eEek yPXO9wvLNw15fX3LtEZ4Zljuw+hkz4NwTDV0Ptl8ad6FFOlk6Jn2UoOTU2inydsR2saIMF rj59050JPxyed8U8gWeOcLCYyqJX8Ew= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Izlvxhjb; spf=none (imf10.hostedemail.com: domain of BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684305189; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mxkdlDqyUpwq2T00umhrhBcnqh9XBG0TKSm9fXSA9Sc=; b=bBr+gSjzHZcIjgYxVczS1yMaT5rrccY7Uer4HYHHT1Oy30OdLRX+8lOg+7VrwCnMG420aF p5/Y3V4DQEQtVKCiF3SpuVzFjBk3GkKGAYWX0EZxsFtoRUjZ9/wRjTEz+gp+E6AuazpuYj L0nFB3XqlM4iYOmDsE+bwLQoZ57EkyU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mxkdlDqyUpwq2T00umhrhBcnqh9XBG0TKSm9fXSA9Sc=; b=IzlvxhjbxQwrfiXgp7vofG8iRA 3rSVv47naGjy5yBlsCXmBFo0P9BGl4m1f0VVw4LUzJnErB+de4aK+BFgWRpTGgdC4pfm/uFJU4Dlh 0Hu2ZymcFCRd9WHxlZ9qMDbIkfui0s2xxNNgaMTvS1EOChnS3j0ixKLfKexwHyMQbwk2/PSpSYaFw dauSVuDbeVqiWqwt085XxovPwY4LfcOIsv/SzWhAet5ERSxhPfBArznjMkhzGygvFOtQ0pFWACOPi ZLXtnKcURHR5uJ9LY1DjW4ebmWgvjd2dqeHyU5e4JsXgDfiPBeE8OfnOOqPJnq68B3CqfQtNEiZVQ JSzI/lOQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pzAig-008Tw8-0Q; Wed, 17 May 2023 06:33:06 +0000 Date: Tue, 16 May 2023 23:33:06 -0700 From: Christoph Hellwig To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de, linux-ia64@vger.kernel.org Subject: Re: [PATCH v5 RESEND 08/17] ia64: mm: Convert to GENERIC_IOREMAP Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-9-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230515090848.833045-9-bhe@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Stat-Signature: sfgtuuopfsmbs1mp4jtk3hfs1cc8gg6m X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 76E3DC000E X-HE-Tag: 1684305189-25130 X-HE-Meta: U2FsdGVkX19g94vDbMx6ZpxjEtieZTmwBjrjwCkBYt+Ki4Tcw79Y1TfRaQ2Lh9g6ukoiOJgwVYVNGPoe4mFBkc6A+Chq4mnku5vNDIOoX34UzCAqarIycRIrcO8ZHgBRvZWyG7fHs7i73eD4c30hg2dsqPVijJaoSbintCkObkHX4r4urTGgcmTibmfrtjAfdQTDBZCd3ckXWhN7FaX4QcwjGwA2X0jysLXAkNhyXmO5P+kxHkYb+YIdj4jbyUHryGQGBcOweoT6octqKwm+ScX6QKwL6DKvTTiE8oEpTW2JJYisB49R+NbIvYItQvHTO3fQhtLdhh2w6tev7FQV18LXAxyJh9dcBW1A4oGdCPmUuJbTPzxUy4fPAPuB2PFo+gohsxC9BsVEbF1+teD5KIxQtiypZJCq5bkO74+a9UconGXYgtmfwIW3RwcRPTTaNYN5ZbMZ9L4JXgy2BWFxkkkEmhWYdHf4nv79xpGlTfH/gxP7SvcNahc291hx3OzlZOG2EHFlngkMc/zbIZA+s06oDlf4+SO/dzfbQO+Qfm5fsk927NYQUw6wT+tVibggQ2VDbt9J6WQPsZ0eMSi1D0zPWF4yilb5W5lOVlJCUFC/L5FAvQEEQw/ptr/qT3WtRz+4nXwiMbdQDb+tncJOAt8NQGIbeR1+9X08HQwgOlPNxs2mEuCBYrHFxWQs0ul6z7lBxbqKHKXO618gRxoIPWccyZKf5uwiedqxTj3JS7fD22FG764g7mVak+ajKIYCvJhsBH0uw2qqRMCLQZG2g8bLeW7IV1ZgIgD9h4ajNBLlrlvP8IT3akH7tMxCv2C+1YKZnK6Z7f+2Vx8wuVVpYPGhBsYcxYYZmK9KUDmKIOzs+sQLjvikLMuR2LQR2YeTYBN7hFR+76jfxmB6yEvvNhLPI0vhK3lPyQgWSdbkjdmnjqaq4cA2Azv54b0HBpiTsPFMnB+PKWWe+UsJNK4 gKFFDTla eZmxaX00SQMUGvIqjJxctQPjeW6nQZ+Rz9Ffo8bjpG+1wf/gHQpQVhvroip6oEfK9E96G0fKUVQFH5M2mx3r79n8CAYEjbSBIBOvW0QSPbdBZ466H9gTUqGLFfwcEH0kOTnwMoD2EQfB42dGAFZs+VbW1QKwX3V7jAJxUAsrFz2LjfRycG4x1TCEuCk/bAPg0JEhYaylygu0itCOBft7KW2ztrwO0qrvdJ3uNrYPIV0rRNL0+J7d3DA2I2+EoGabh4dIeMbK30dFroCkLMmRFoVQB1KRE8flRWw5n0QJuuT4z78qj7QdVnEhZiYye/NY6i46SopnM2Z4S2RO9o9x3pErdFstWNWiKARGPPDPDeI/sg80QFAqx37y3lWvM0/xo9M5MHQUNsFTJAENg3fYQJoz4RiW3OMUu+1NYGFtXGmlWETn4WCP/Xo8xlC5lETrZJbXJLIAHka1BWE5AQJ3HAotwcA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > +#define ioremap_prot ioremap_prot > +#define ioremap_cache ioremap > #define ioremap_uc ioremap_uc > #define iounmap iounmap Same comment about the placement here, I'm not going to repeat it if it shows up in more patches. Otherwise looks good: Reviewed-by: Christoph Hellwig