From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32753C77B75 for ; Wed, 17 May 2023 06:36:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB7AF900007; Wed, 17 May 2023 02:36:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B65D0900003; Wed, 17 May 2023 02:36:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A534C900007; Wed, 17 May 2023 02:36:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9A1D8900003 for ; Wed, 17 May 2023 02:36:30 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 61D86C0450 for ; Wed, 17 May 2023 06:36:30 +0000 (UTC) X-FDA: 80798788140.20.3CE1317 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf24.hostedemail.com (Postfix) with ESMTP id AD734180007 for ; Wed, 17 May 2023 06:36:28 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=eXV2qErw; spf=none (imf24.hostedemail.com: domain of BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684305388; a=rsa-sha256; cv=none; b=sqV7Oh1USvnt3S7cHzPj2CXh+E9QXKlnddodTmIewY7Ht22Jbox0vN/1ORr20f6UxMDPSz lPk57WUjZyVz1IDaNnZgKr9/lvRpD95+ASM2A7uYo1M9KLBNZy7TuPTMCt56zkIoSHMNGG z9X+BMsmQEF9CzbUlqPEcvgGZH/NtvA= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=eXV2qErw; spf=none (imf24.hostedemail.com: domain of BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684305388; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LyqwcPubn/JsQWHMskCZBu9QXpuNcB4Hd4xqTmLITsI=; b=ZoEvA/ccI/czU5nI5Rel6SvbhMg0YDl6OK52VZ74bhV7KfoNI7GLHORtGpSZJzUVbfoC/K JZ2ceO8yFaiKt4qYU7D1D2lbPo+F42uqaH1QxoxqlyK1hA70Jl4Hm7mlqDt34P2l8igcyh uza4Q07YgsfQIF/wIdiiwT3w4mEaqnw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=LyqwcPubn/JsQWHMskCZBu9QXpuNcB4Hd4xqTmLITsI=; b=eXV2qErwJTXGUoa1Zbhw+gAMw0 GNVHvOiLHyJvuf62zEKGLEA9V8ORQo+Sl4BroKuAAfHbtj60Yeb1thb73fA2jXbgVOS2ahCdFJ+mE VBGPhrJlsTqEaUImKwoyge6oq6QxZSdBip10g6F8tqeDJ8i4+J6TKcBSzLDjh/O0ycop+SMQM+F2v ErLvWCCNmc0jDBcTsP3bs2DxNwF3y7u5/NtB9tkK7QEbMxlbzu7B1mE1w0hKm9KQZ8AhgR3r9IIZ6 Qq0G6b9ARjq5usIYdVJksLo3TS+jsz7aBPqlrnsXxU/iw0KvWkX9m2CiMY0l9RQBar9wTFPyr8Blg ptop//Zg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pzAlr-008UZj-2Q; Wed, 17 May 2023 06:36:23 +0000 Date: Tue, 16 May 2023 23:36:23 -0700 From: Christoph Hellwig To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de, Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , linux-s390@vger.kernel.org Subject: Re: [PATCH v5 RESEND 10/17] s390: mm: Convert to GENERIC_IOREMAP Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-11-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230515090848.833045-11-bhe@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: AD734180007 X-Stat-Signature: 51qb8y41xbd5jerruakxjwm68axpoedp X-HE-Tag: 1684305388-337612 X-HE-Meta: U2FsdGVkX19T4Vw9y5o+yHHN2KWS6/SaQxFVxBxq2u11XXP+g/TNCTuiFexV5z2bXTBsnsoQPXdqp6R5Ptttnjn0i3GqMjkvczb3swkh1OsP22yoMPNMOLawSI0VuKkXY0IPKeJQ0mmUxVSMd+CDLrccO0M4k2DGrwsAmLRH49C14FfDEWMm6NmxWVuCn1UnSU9CBgFfXFZEqynwSop3B82OBlGiD/CcNvt5PPWehMmxRxo0MJOHTLEgmXx6HIwvcV0+QgX7CisDWIVjL4Hkc7DY1spKAvJoSW9bMRVP70FgZV9YtrAC4ywkbx6VWB9wRBAjqTS68myRI1B2KA/Nm/jwt1gOuBOc1MAw1paWbW2LKL5gnA71vjTRQfEIdSKJsYjdMN0iBBFrC9ndj5e1S/yjf4gxcrpH68kBDWXmxqrBBWormoCH4xNayJNOhuGQ0RBzeby6psqiiZuP9UlvpDAS8yOpmaIJ1MkEo592AKOFVlixhIcS99UihQ5XjgJjI4wOZMozpjXGiR7hBjcEfdpS3c81k+9aEDiwpctU+ddgE/AJNY2GhuvrYF3yoLqwxGDxTDoJpYIOaRh6Jcf/2UR0si9rabwM69tnjr1ZMvUDrsWoIbyWTgLQHAB9gaJxPRh0FbUvjZmiqakCHF8bPsr3foY0VjE1wbnjiNQu5g+8//OwMz00kQECRhEtqlX2TIdQPQ/01CDUUKD/vXxZwZ74Xx7PXIqOxFtNF5PXjwBgbOZaB/hroRGj31UlAFptlA9DapgsVGSEzacVZbDP2p4ZzYdvu+UJ7Sz9Y1GcKsP85X/dPWhsq0jqFKXV/ESsDtA63+8PskxlNzyNSh8n2tOA6o4P1GYTat4M/D1yIMOiENbOcabrpn/HOTeRSA0Lg62goO47qx94wWCTjeCCkq0I1jciiom+mzuq0+kgjOfcZE5ZlOBT1d+zegkQgYO+aBS65RnTQR12AsJpQoI k56VMZNe SPoDqrE2e2/2tz4Ddcnw7g88pmv1M8i+DJzzpjNie+k8wAvj7C+h6KI6L8g8JkYlpDAdrelKvYgd5hnbtsa12TM17sn5UNdbt9SwoJc/ZbmKHC2fCtsLQUgKnmSfTpUd9WuJsdMzw1FRgdKhyzBk5wHvdWo/zUgUEfViH4AOyIFMCGIHuAQXyuf6D9VBWEE2OOQsIAe9GSBvT7zcrtsC5/UBH1Ty0cJGZ12c/uF5X/1SqUfpuOir2qGlb0QBAY3E7i6ibhXy/8W8Ki5qzuvIfLRuscBScN1wjwrogz5hoz1syVYvd/8ZEUnfP1eFXlLoizwMT57I92bCMY/QVoH3JYxGHK4DSEf8aYgq6iRzyI6q8X7hfYIDKSCH74mJPPcszVM9DMoKJxjn05rDTNq+/1hpzfRm8D8CPQW2qZLLGILHK2dLj8sm4rO3p3w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 15, 2023 at 05:08:41PM +0800, Baoquan He wrote: > +#define ioremap_wc(addr, size) \ > + ioremap_prot((addr), (size), pgprot_val(pgprot_writecombine(PAGE_KERNEL))) I'd move this out of line and just apply mio_wb_bit_mask directly instead of the unbox/box/unbox/box dance. > +#define ioremap_wt(addr, size) \ > + ioremap_prot((addr), (size), pgprot_val(pgprot_writethrough(PAGE_KERNEL))) and just define this to ioremap_wc. Note that defining _wt to _wc is very odd and seems wrong, but comes from the existing code. Maybe the s390 maintainers can chime on on the background and we can add a comment while we're at it. Otherwise looks good: Reviewed-by: Christoph Hellwig