From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83A2BC77B7D for ; Wed, 17 May 2023 06:30:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 268D9900005; Wed, 17 May 2023 02:30:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 219B1900003; Wed, 17 May 2023 02:30:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E1B6900005; Wed, 17 May 2023 02:30:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F2A48900003 for ; Wed, 17 May 2023 02:30:52 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C9AFA4047E for ; Wed, 17 May 2023 06:30:52 +0000 (UTC) X-FDA: 80798773944.17.64CFE16 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf22.hostedemail.com (Postfix) with ESMTP id 0578EC0010 for ; Wed, 17 May 2023 06:30:50 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=XfGkZqYR; spf=none (imf22.hostedemail.com: domain of BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684305051; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lHYduRAGXCkDUrS8b4Gx5zxhlIgk1+vCGXqqxRlJ+eA=; b=IhwLyg+T0T6WM8mJvwxkOFgJjtD+3SWizU1C6fyT7xp72zv0kLeJyZbJj5DF4H9YKD1ege 9X1pR8f/Qgq1/4PFaZJEy7iAVFMYbvO1QdRbFpOuXEQT9P3UM+tS/lJhjcIlk6iEAShd4Q 121/MRKgXk5diUr/m3ObwvymKSpmx5I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684305051; a=rsa-sha256; cv=none; b=PcamcYkLJ0k/+LIT5aNkeE/WEeXTSm1Ln53t2KxQjaqtIEWVxP2nSWPSSktFrrpKnj9uEh ObjyN/+4dAqcthAE3dZI462ySnWpHYcMMfDvXxCksRVQwGWsdEgofmpHmRcmbuyJK6KI4Z Fm/+HsWPP1lKGY3B/wYmu2EOrUuWhJU= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=XfGkZqYR; spf=none (imf22.hostedemail.com: domain of BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=lHYduRAGXCkDUrS8b4Gx5zxhlIgk1+vCGXqqxRlJ+eA=; b=XfGkZqYR9+Q+PUUQxBnxaKZfBQ wLIDVA84yn737aw7Dc93fZzAfT2HRb7k6gxeXJHlj73m6oMreWWh+dGd0ZpoAI+dP/DxcpvFTynRX ZuInH2ELv2cUK/JYU5gTgshp4n6SToNn3y+cAluXnl9ef8oddhikSoy99RcE+0B4bQqv+exTUeJJT Qk5dsPTyfh5hnxes6whp8YustSHdySbuoHhxBWqWZqIFN7R7AP0/3gTf67zk77eItoQdJAsvtDOat m4LPom31pYeicRdHLNVclWMmNcmf3vSrg61hNpMFdbf0+lzMkxcVuxNySZaR2H/E988yDbgb3IJtl OMOXdcWg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pzAgS-008TRG-0s; Wed, 17 May 2023 06:30:48 +0000 Date: Tue, 16 May 2023 23:30:48 -0700 From: Christoph Hellwig To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de Subject: Re: [PATCH v5 RESEND 06/17] mm/ioremap: add slab availability checking in ioremap_prot Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-7-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230515090848.833045-7-bhe@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: xrbg11se8shjxeqixrztthxrbbgnkuo9 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0578EC0010 X-Rspam-User: X-HE-Tag: 1684305050-424440 X-HE-Meta: U2FsdGVkX1+8IzBIMxWenfRj2YIyXIW4xMXtWHYsPOQU+Ti9BxuoCU0T4Kdux9oQNwA7LvprFIISgJuLoMPxJ3CcLPB4FExeZaJ12jGcjGqCq4PgbiZRy5B4pqHZ/dXsQ13ve3ltjvhxyGkp373QK9e0PngrTcs7Hm2gflj+1D2o8uQmAT4E8YczMnWUHeWX6P4EujXw5lQzVCuZ4q3zq2vfVyAlF0c/UOwdxO7q7UVeLPpe7A+qQ9UMg0TMy7jFPxWCWjCcOFTXL9XxTekT7TqKL4VXsQ78v0NEQ20V5k1OorQtDp4JXhUYjuUrndoULYZt1hWKvybgaQLDM36eipKTQ47UUbW6RIFyAi12HJeAQB5x3UV8egdmziQwUTL9n3iaK0zyMuK4nBZ03M3FzzZtVLVNS/nFKASWMosBu8mv/KftUe5BDC9kNgjiv95SteD57bXb3pU2L8pd/Vbk8s3yZQNJkITn4QuKSOZ0hfcKK3Lee2L984gyG0aAarg+9oWwDtvC0Sx/b947rIXHdW5jDhRt9yUdAw+crYPkHYZQeDd7Pnb66V6atdbw9HlowRbQDnXkIrpD87/VRDE2OKpZvd/FSWInEYfDTkgrhxHDxUF2/ZhznLba/wQs+w7bV5pvpwmtP+m1P6Fd0rF7GlcpWjhoRoqGIJHTL6IRpdOlHmsugq7nj4alzlhWmDe8s07gBLKoL8N5ThIXY/fqNU6RwEuboQfBhGB0P7yBIOM3mYmCeEkcK34IgsscLuWH7m4iwO/Hb/2jfIPlm3V3gY+suPE5O17c29EF75F33ekMIM6eRiwthu5BteIMg7vm0TJjllQVxFCK071ha/TjQi/IBB0hUtUtbp0UF2jdEH5/rXMx+Lrg1JupJRktCnufL/ZwYXJi8qDRf96rXznshLtJxjcSpop2T6w/X+FV8aLl+6SbU/EwZPf4OJRH5uTkLmRKz8/07hJhNZsPir6 0AhWclah oTfyZ0SlNUOirdiFwNyRCwkiB33/5apYtyPZ125FWS1NoBU8gpPIZ11dau4dKX8+thLb+g0SIAYG4sg8tUn4lvjLbKK/Xrj1pvbO5M0b4YKldKfOakKY9Sz3YuG78z+Kn4IDif87GBVkoEuC84ueJTkitx2rVao12QVB1lbteuWAYdONfgGychYU/+dKE4eblV1sL//dwbuHKXwXud4G8qO/ZW3ywYl8fi9yUj1pnxwogIvGT1O6kXgWaoeWsFxjndfTK5IChfxezWHeE88gnd5cQk/MWf983KzzyJfJNUITQGCLR6QMjb4CuemfdEDGfp5Fvtj1yN8yoohtHu8UaCg/5NtGbvhAThWAL46TJypCRSDpI/PaMxmTjAlUi8ASXcGLf2mWMMit4KfZSN6l6iFYCaJZWqxBUwiywZiIXZBVZ4TPPAhsVqtRKBAEJokucJdk1cD+EtjbsLl0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 15, 2023 at 05:08:37PM +0800, Baoquan He wrote: > Several architectures has done checking if slab if available in > ioremap_prot(). In fact it should be done in generic ioremap_prot() > since on any architecutre, slab allocator must be available before > get_vm_area_caller() and vunmap() are used. > > Add the checking into generic_ioremap_prot(). Should we add a WARN_ON/WARN_ON_ONCE to aid debugging? Otherwise looks good: Reviewed-by: Christoph Hellwig