From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3922AC77B75 for ; Wed, 17 May 2023 06:29:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3236900005; Wed, 17 May 2023 02:29:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E11E900003; Wed, 17 May 2023 02:29:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A9AA900005; Wed, 17 May 2023 02:29:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7B52F900003 for ; Wed, 17 May 2023 02:29:57 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 55B991204A0 for ; Wed, 17 May 2023 06:29:57 +0000 (UTC) X-FDA: 80798771634.25.2EFDA52 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf29.hostedemail.com (Postfix) with ESMTP id 99258120010 for ; Wed, 17 May 2023 06:29:55 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=OiHf3Ei7; spf=none (imf29.hostedemail.com: domain of BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684304995; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S5cEDxvLIXfF6hhPeiKwzMcCpc9yxz2+Gj2aOaYhurM=; b=evhI/ekVeWZZOPZ+7ESWyT31op5o2Ax89UoE5ybgcXpt6qox9iRNS7CnPJlNaxl0vMKRM5 BAZ9ziY9DljkHzsMsDEk8sWZtZkiEC4FSuloyxF1k+YFgHCqgGKfx9biqU3SOjuS0d0hyC z3cs8GgeEpN5RJiyBMlNC3dUMQOF6os= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684304995; a=rsa-sha256; cv=none; b=62Z1ekAt4l/Gnk/87MxGv1eLn/qYHW6F3HwmuOUH44ydpaW5O+AooqdXO63+b7da7NEvOB cKGtleBLR2aiu9/UWcPZevQrKL91qve90+/9qbdWRjmy4E5YynHIHkaBQthW8h66PGpDP4 en3RMeqWq5HcIrukEtKB5uES9TbOEns= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=OiHf3Ei7; spf=none (imf29.hostedemail.com: domain of BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=S5cEDxvLIXfF6hhPeiKwzMcCpc9yxz2+Gj2aOaYhurM=; b=OiHf3Ei73KQczceza5cq/WYQh4 Am9CD9gpEjCRUmvhkl1xG7u/iGOdJgbpHXPze13IrKHa4wII2y8jx2oNcaxfMR+gOhl5TSVIsRxWY QPpfQcN4qJhRUGL6zhTq8alf9bXPD4Q0sNLMxcA2+bxy6G6XPkpoocLd6PPCS4l46pedkhWpY/9iK 9zW0zLv8r54JAUSAiUQGMT4M7hxtxqvZoGhv0g06mrcX7ncLrInemXxjh+syjmADMs92jahScH8bh x0J0GAbH/lDS3LJj8H6NUA2pDGyH0gSt/x7AcpFBulfQWhVOl6Zc6dacJgFBZzUbJ8KDCzxZggiQd OsT0u5NQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pzAfY-008T7E-2H; Wed, 17 May 2023 06:29:52 +0000 Date: Tue, 16 May 2023 23:29:52 -0700 From: Christoph Hellwig To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de Subject: Re: [PATCH v5 RESEND 04/17] mm/ioremap: Define generic_ioremap_prot() and generic_iounmap() Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-5-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230515090848.833045-5-bhe@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: eei8cib87ej54fjkhgkxzfn5n4ey46dt X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 99258120010 X-HE-Tag: 1684304995-495915 X-HE-Meta: U2FsdGVkX1/obRtOwargFgZSbd4AabTAcczZZe5RQvgL1jdaXTAP6VSdXUrkluVBPbqSN3zxwIeYTHDk1Rv1d/lFpGWyuJG93fUcGqSw48tnyezMZpNJ1HSXjTA2KJUuC0WmRe1Ie5pzqXw3LlDz3SLAI9oyWm0+nLybjCvQgyXYhj/KUnJ/EF26J+cMUsL24VsFOGAhav1/tQfbUGXWsXkA/ViZ2U70g2vfpjuKEAHsHASwMjdeXAuUjpZ44MKVBCpx2KOTLxf6zwQkLK7Xvz55HYb7GG23pPHtzN7lya/q8Mo1PpuTL0zNDwpVOlsC5rr+UM7zUuB+e46eFCtEnJms04EVB4ISSNC9tRsOmsrrD5WcP37OE2dMzml7rmnYbqOgUzs1pYc8zrF9N2B4Csiu8szgscy6YvXhvlZNcKWBIdf+RNkYD+AlrIBT3DOQQOMSruvccSohaQAwqmnFOKUHbzNbvSIZ5Xr64xzYf85cJ5Sc/c+9rf+gPKCe82huvxxrIv2qj/CMChkOU1IFxzWrzlqV5L3q6+rlC8IojVf7oXE7izkMX6K2g23LoRglSU8RIiGPtIDyQLrwRBwa1GhYm5DJ6TSKdsXEtdwl6NYDxse8H3Zd+g6VkJP9qBw2Ej8hiPuoc0d8GfWRRJdRw0QjD6e0Y8LY9QN/d6BXvKiJKsYudFppqqM2BlI5gwrTiy9RlRzMu5HWjH7JgAbLQ09xTc4OtMvkR/YjcFz9t5oJq/yUiOFz4hgSb4GCDauguZI4sDyTHwi2fwRWy9ZvVQCyEP1EWM/EwLTeOybJ6KFJbrxMpl9AitW/UgzlUsK4do0bLZLY2z+/Rq8uxEHRyTCK3d5OMxiQa8njV4jodXlWbKQSNw/InV+cUFNtqGH+/if1QdpBYK4onq+a3LVZQnEj+nEjkMtUojOc2STZBDcbPiA0AJyxT24gKtDFVLnQjNmrrCWuCE5tApOtEmA +isPDR1l AI3od6TEd9yAx1CZgfdw7NdGbEoz8RCEGgKMqQO6l8kSNOajPLCbrk/Dek427gc9iUOLVvrsRAzM063nIgKLsyvwETJMYqutuzF6h62WXp3OGe+mVsKewXQH+LhMyxWzkt2QvcZg1P64Vla2IzFCwDLSK9RDYu9ffA9zZo8e3ycfmebYTagY/kvgf3zN/pKYumWKMaDSBJFVi8LuAtj3qXgA8ZNFMGugE4O09vx1baviPmzeL5SSu2yHiAUuQ4MHRwXuO47cy6BW/XaiaUTIjOuFZX/VukfVjHktU1PcL9xdkoPEn3Exwin2j96bmGmGDyGHivYQ9StUgdgjAeAqD+o5UoqejWQIA9MZgquZ3LfJct61cFYtD/zxC0aCYsmTjAzbTrXDLz+3mtHUODMKMZjW54WDe8aiD7P3DjROsyDmmo9fKJLDZrGGm8riZTtK8tne1B9cYilwg0hb5L7tHxMjMj66ovqWqy/Smyl/CwLIerf/i9Iy1kBzAj2AIraKJnq6OknXitRgeeAA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 15, 2023 at 05:08:35PM +0800, Baoquan He wrote: > From: Christophe Leroy > > Define a generic version of ioremap_prot() and iounmap() that > architectures can call after they have performed the necessary > alteration to parameters and/or necessary verifications. > > Signed-off-by: Christophe Leroy > Signed-off-by: Baoquan He > --- > include/asm-generic/io.h | 4 ++++ > mm/ioremap.c | 22 ++++++++++++++++------ > 2 files changed, 20 insertions(+), 6 deletions(-) > > diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h > index 587e7e9b9a37..a7ca2099ba19 100644 > --- a/include/asm-generic/io.h > +++ b/include/asm-generic/io.h > @@ -1073,9 +1073,13 @@ static inline bool iounmap_allowed(void *addr) > } > #endif > > +void __iomem *generic_ioremap_prot(phys_addr_t phys_addr, size_t size, > + pgprot_t prot); > + Formatting looks a bit weird here. The normal styles are either to indent with two tabs (my preference) or after the opening brace. Otherwise looks good: Reviewed-by: Christoph Hellwig