From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 434C6C77B7D for ; Wed, 17 May 2023 06:31:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D15C6900005; Wed, 17 May 2023 02:31:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CC74A900003; Wed, 17 May 2023 02:31:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB64A900005; Wed, 17 May 2023 02:31:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AC9DB900003 for ; Wed, 17 May 2023 02:31:57 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7B155A04A8 for ; Wed, 17 May 2023 06:31:57 +0000 (UTC) X-FDA: 80798776674.20.8547A58 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf26.hostedemail.com (Postfix) with ESMTP id BE56714000A for ; Wed, 17 May 2023 06:31:55 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="cFu/rKWG"; dmarc=none; spf=none (imf26.hostedemail.com: domain of BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684305115; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R+bia8kNOnh/zzckPz9KIXCK6j55WEZoqDL73kF/+sg=; b=D0+Y6EwrUJ/BI6ZqQlnnm4vXmbQ5y7eLrOSde5ASfIaa75vLnsNXcOpgmTWpMsD+yvdEy/ ZE0gHvrk5Sm4GM95vGYjOWYBUWFYKDORPThm33H8EhooMWI0Y4F+C2k7YYkytbl3qnGpEL NLkjxS8SXj3ONZbClzFYuygA2/jhlzs= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="cFu/rKWG"; dmarc=none; spf=none (imf26.hostedemail.com: domain of BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684305115; a=rsa-sha256; cv=none; b=FCWpsqIs4DI3AUuZJ8SFoHkmkkzaWPp9/VTEuzKz8hUsqPwmBsedTrzmXeZ71Gx6EjLnUu k1rnRMRc895SeIC4b5maZdwsWJ8AgOZYSmjXaV544cWXif8ZbpMkbJNvxr7JASh+O67oa4 1qUIDnehos9/asNJAFXKeFr/P16TCps= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=R+bia8kNOnh/zzckPz9KIXCK6j55WEZoqDL73kF/+sg=; b=cFu/rKWG4aO9DRAq9O4fdaCYuJ lC1p/EPe09ZjM+Kwuh3kG/tHsPA7KpSfPG3f/ETB71jX81whefhm7MjZT7HQgppLozACG7eNAmAGs UZdqpa3pypr03b69y93R0MdXcjh1CefbD5hNoFMnCiHruzxM7YvO23QVu/wvLFglpzr0w/Yzdxa1c O8t74JrYxS+8eY2MeeeIBL6rMJhHT2crq8FAe9CsAeqB5YTnBPdIqfRlKXpb3nPSNqN2qZwhk9c+W BOuIGzvDfvMISQnfs5Z7NJJGdkCP4ATb7xmSbESVAb4ncjEXyiZdbkkVU0AvizH30Kx8Cc7UId3fT c4LcH0Fg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pzAhS-008ThE-2J; Wed, 17 May 2023 06:31:50 +0000 Date: Tue, 16 May 2023 23:31:50 -0700 From: Christoph Hellwig To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de, Vineet Gupta , linux-snps-arc@lists.infradead.org Subject: Re: [PATCH v5 RESEND 07/17] arc: mm: Convert to GENERIC_IOREMAP Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-8-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230515090848.833045-8-bhe@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: kokxendgtnqdakpzqcf3hdpwxko9u5t1 X-Rspam-User: X-Rspamd-Queue-Id: BE56714000A X-Rspamd-Server: rspam07 X-HE-Tag: 1684305115-836424 X-HE-Meta: U2FsdGVkX1/XIoHMD4aoqUESYq5R9ddatR8WY0hHCq5C9KLAyXqV2jfJ7Uxv70lCUoM/vnPf+c/6fdLT0tzWoV0YgDfuGLyYbYLv3TGaEUHUZwDhSEmxAHuRIrzjZxTwL7V04OtF/tuwqGfELemOK1FseIF4ik5jwgjrPhqwFcsV6VOzvY3NtlPjq6vSh329dYSjBmrPcOxLhmV5HfOEgfQmr6S4OoEQPnbhEpYClrUUFFiYJ7uqgOJJneY2RJ7l0MYCziLpAZJO6Fi/wY86iz9Ocz/bMUW+NslmSlrR80yzxYi7UxaXxa8xg3SDGzboOFiOK7VKsj/LSRJkk5owzpq6/NA51+ROLRZemLVw0QzlvmR4pPdy3Hdky4uzypeWuAxhrzVpG4/52kQlzSVik1NQ12sdOTR+Iq1MzmRMWMzxDkxXw6gncFZYY9vI4tDXK3mGFICVRB411GWGPgaUGPokrAIw/N6NVxQwVD7ykFx7JyJWAqW8vGCrOR5K4ZY/aXTKhIhKny/OkQUkguBtVEuZb/SY1iTbRdxsVbHB6Pz8ArpjLVp4Z9Ag+Q7aUab6OOpXNoNuAJrz4xeqsQwAgKDBckRy3bpUfyFkk6TpixXIGUOsC2ByYMZy9WBH7yVxwupJn3tKmTYtAC7nktO3Zdj0lXLFnW0bBs89nIJySbXM6RxFbULV5T96UvMyNuRNx6dQnzIWSVNq7ygX76F/qorD3NwQUncCOJxGuwV0Z+cHUSKPeuwOvLUBS3kk9IPfyt+q/hjjxulM593y+2IopKRzAc9GHQLgm6WbxEhlnFLZHSc9g2wkP3eh7szsD7hqgbXKw87JRfYMAICiGKB/AGNpddCcJ7zF44goxrdIzYDW4jwb5ZhfJi7MRLX7zhOUVNgDTnjwKJUhU2aDDtitDTccIqYqJQzre8X1x5zjRsjpVIyHI6JG4wJ3I3KcP8rX9twPnm6MFSlk2dGhlVK oAVBj+vN mWLDkq/HbJEhWc0pCBlwlY4vmJFbty9WDk/Wa72pZNlX9spgu2wMhY++odqvY57OsKyNfS1jSUwKGxVEKZyaYW3EafWh+p3Z+7/Qqhbd2hAxD0GKNb6Bogj4Pq5cj+lPZJDclIYVFyYF8oT59/IuRDLzyEJ18mFoOAzp2Ae416HvKZJleJxT6Z+LoqnYgT2YhFEKZYVJQnc6Iipx1FgpppqHI3IDVCpAiBSaBoqvztrYBBROdIFwPn+xXupMJn0a0dBLGAJW6n7f6ksvzX3DFTE0bh5l6XNIFLQlMgx9/S5mfU5FiM2QJevDHullOQO8Fx9ktu3DJJzCjkEJZHOW7yPZ07k6ass0B49e3zxH1GUfWY829vnZtZphDn1uHkLrFsASHn0Qh6c+qre1c/1H8hnfEMEdTsOsbfBC/52/kj+JzZj4BKZlqGh8mMf1A8EM/7nqkqjSuMnbeUEVhzs5BXhTGkw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > +#define ioremap ioremap > +#define ioremap_prot ioremap_prot > +#define iounmap iounmap Nit: I think it's cleaner to have these #defines right next to the function declaration. Otherwise looks good: Reviewed-by: Christoph Hellwig