From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E49FC77B75 for ; Wed, 17 May 2023 00:19:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84CF7900004; Tue, 16 May 2023 20:19:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FD2C900003; Tue, 16 May 2023 20:19:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C4B4900004; Tue, 16 May 2023 20:19:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 59515900003 for ; Tue, 16 May 2023 20:19:00 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2C7651603FC for ; Wed, 17 May 2023 00:19:00 +0000 (UTC) X-FDA: 80797836840.17.1CAB414 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 4D7E080009 for ; Wed, 17 May 2023 00:18:57 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gIlBWrbH; spf=pass (imf30.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684282737; a=rsa-sha256; cv=none; b=nV7FEb9XXGVDuZk8UtX2394/jTRroWAKk0Lp+40Zi84x0A9Ux5khJA3dMK9ycTvPo5/W3/ KiYyJXMAFtbMkFCCLo0Oqo8/mkmcZ26nWge8lGPkng/TBsA8M2IO8k7oXaTgG0Ot50y3aM qTtF1NkdjV4i2fJRHispFKM21o6qPqk= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gIlBWrbH; spf=pass (imf30.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684282737; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fAWA1BLnS6OZoKpUWNVEQYD1QFUo+cJ+dgpIwEFG8vQ=; b=iRWYNPalOgYrwIu0Lunc4QrdZlzpX8jf8hlQtema5a/iEsySX89YBKhc6OU9OIaOz6ePf6 CtdI8ueY/jiqZL289NVPF88DSnexf6IM1RI/z7q4Vo9mX+Q7w4fFhQ+ZWW9F2d4fWnYs8m 73z7vjlvliiLjE590zS7g5E2BI3+iNY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684282736; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fAWA1BLnS6OZoKpUWNVEQYD1QFUo+cJ+dgpIwEFG8vQ=; b=gIlBWrbHybg+YZojbU6z5zz/UHNxbxvbuRRZfnlspBp7aACUa9HDbzFwxNaJDgDouU1wQF kjsjBJap5mct/S/wG4/rr69dU7/RMtSsRiFIh9C8G/4j4FjqK3w7AmUeKYhOCyRIP4eoO2 iTARBPWQdc/qXGMy+NU2jIKZ0DXaAGg= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-630-xSYMGA7rM6C5pLqfMBrTEw-1; Tue, 16 May 2023 20:18:51 -0400 X-MC-Unique: xSYMGA7rM6C5pLqfMBrTEw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B3A533810B05; Wed, 17 May 2023 00:18:50 +0000 (UTC) Received: from localhost (ovpn-12-79.pek2.redhat.com [10.72.12.79]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 02B2A1410DD5; Wed, 17 May 2023 00:18:49 +0000 (UTC) Date: Wed, 17 May 2023 08:18:46 +0800 From: Baoquan He To: Vinod Koul Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, schnelle@linux.ibm.com, linux-s390@vger.kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org Subject: Re: [PATCH RESEND 2/2] dmaengine: make QCOM_HIDMA depend on HAS_IOMEM Message-ID: References: <20230506111628.712316-1-bhe@redhat.com> <20230506111628.712316-3-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Rspam-User: X-Stat-Signature: w68su6xkb7mxxaatjxi43q37xccqxi4s X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4D7E080009 X-HE-Tag: 1684282737-373633 X-HE-Meta: U2FsdGVkX1+3v3irq+7drfN1uWBzYuUAqPsPNHpt7NB1eRipH9LV4SsgRGIPA7mRUix9ulO8jsNwNfx8HFXxwZT9IDBPcs96fJ2ezAGs66HWq4dzhauwRrbjyeJ2v98X0+48ullwFiAtFjRUHzN++uLeZNqF9uN19mChf3FNxv/nYve4ng8qAMK2RHtj6qgxE1kS5y7hL2hKLA1NlLuiBgUP/YuvtkjdAdUkhj8XPdz0qMX5yghBni10X3zz3S0p+VTED70wQTn5rWk9cuzO3uCj9/kS8snmSw6VlX4USA07C5tr8BR5T7RX0tfeSTvtwawnJ6ytcLSdAgrFxnpQgX7qd8g34Pxdc27NIm0VCeSUCLX8dPRruYs4rySHJrOPk0NQpp169gx5hdi5LjUoJuAr05oJfiqC30ZgpOCP9OjljJoSqv18lEHWp8akUXLUsy/ONWpIbhH5Qx7AZzTVKxv4GHSZ4gmlyw8lLYIdHiiLi1vO3Qzo7Yc67t3pgnhcBkEs0IgT9f2KrAkMfPxVM+SA29+jwAI2agiXme4sesAMh0+lYfUF6k4vN/3aNCoTHeK8eVzYwl3+J6uQVTJHuiq/Ae1HS1U++nwPYG9ySjxix6Uz0RE5YeWC8IV5jLQ8Lj6TskRi3XeycnYH0qvsAyrWCtTQ5l2AlNARLgq62fPb6LkcYUMSToE7E+BntW5wLIXW0f9pQp7t0s7K2nOKEaEYXJBtgjpi5w3LyBLGZCDwd4V7xl8mmCPy4SV0pNkzdXK3zNI1vgFEbmyUCBCwH/Imbb+DJUdifubiCEPiL0vTRdgxHxGPlgyaAPlpQ2hztjBkYmUGwDNFiLLdyeAIDJ8vP6emGBRn4NlHTztmd30H1LrNCc6idB8wz9JoaS0ccPMEXqNMeo5wvg6piJMFa2BJk0Z/dyScqOBSdd3JBQg2knGGUCmTS9DlPhroEupGAhnKMypIVmyE+7UfeXR 7fMnZtvt 5CmTEFAUK6UttCkgY2ugphST9RgWAyidQZVkuKnFU9vm5YYh4CSaJeHB8MpOWEnkvUjvBinmf9gbulWXtogU2VV2DIfpM36UQsKocIVrrSeU5N+5W/yvs41jgOZGiA65fWlJhG1VhVn6PL9b3nGQOErRf8uyeeVpi0uMSe+hDwj8r3+XZPZa/ULva7G9s8TcSFgjb4lCtXZHyGXWj38c9LfPIgY3/feA6Fcx8osIbAkmPwMoAlLGzUUhoekuz3DoHT7Zcfd6LizdNYVthSjnc00c4BBmjlBat1fMweVS+zaNQADupvkdLGe3ttkqJxli0qjm/S8f3+ZKm+Ve3MH8rUaPr+QuApxMeqEGzwxtD8wetVSTOG4QKpNMg7tmdaOWyPzcf8VYSt/s76KPDWJdoq8YaDi+mO+XhNJ2AaVxAg9Q3DehuGFtXJzXHAENm2BOe8a4TGlAqtIPxask= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05/16/23 at 11:26pm, Vinod Koul wrote: > On 06-05-23, 19:16, Baoquan He wrote: > > On s390 systems (aka mainframes), it has classic channel devices for > > networking and permanent storage that are currently even more common > > than PCI devices. Hence it could have a fully functional s390 kernel > > with CONFIG_PCI=n, then the relevant iomem mapping functions > > [including ioremap(), devm_ioremap(), etc.] are not available. > > > > Here let QCOM_HIDMA depend on HAS_IOMEM so that it won't be built to > > cause below compiling error if PCI is unset. > > I have 2/2 patch here, where is patch 1 of 2..? It's here, thanks for check. https://lore.kernel.org/all/20230506111628.712316-2-bhe@redhat.com/T/#u I used get_maintainer to get reivewers list, seems your contact is only put in 2/2 patch. I also sent to lkml, linux-mm and s390 mailing list, so the whole series can be seen in any of the ML. Thanks Baoquan > > > > > -------------------------------------------------------- > > ld: drivers/dma/qcom/hidma.o: in function `hidma_probe': > > hidma.c:(.text+0x4b46): undefined reference to `devm_ioremap_resource' > > ld: hidma.c:(.text+0x4b9e): undefined reference to `devm_ioremap_resource' > > make[1]: *** [scripts/Makefile.vmlinux:35: vmlinux] Error 1 > > make: *** [Makefile:1264: vmlinux] Error 2 > > > > Signed-off-by: Baoquan He > > Reviewed-by: Niklas Schnelle > > Cc: Andy Gross > > Cc: Bjorn Andersson > > Cc: Konrad Dybcio > > Cc: Vinod Koul > > Cc: linux-arm-msm@vger.kernel.org > > Cc: dmaengine@vger.kernel.org > > --- > > drivers/dma/qcom/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/dma/qcom/Kconfig b/drivers/dma/qcom/Kconfig > > index 3f926a653bd8..ace75d7b835a 100644 > > --- a/drivers/dma/qcom/Kconfig > > +++ b/drivers/dma/qcom/Kconfig > > @@ -45,6 +45,7 @@ config QCOM_HIDMA_MGMT > > > > config QCOM_HIDMA > > tristate "Qualcomm Technologies HIDMA Channel support" > > + depends on HAS_IOMEM > > select DMA_ENGINE > > help > > Enable support for the Qualcomm Technologies HIDMA controller. > > -- > > 2.34.1 > > -- > ~Vinod >