From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8179C77B7A for ; Tue, 16 May 2023 17:56:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 64291900005; Tue, 16 May 2023 13:56:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F272900002; Tue, 16 May 2023 13:56:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BAB2900005; Tue, 16 May 2023 13:56:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3D4DB900002 for ; Tue, 16 May 2023 13:56:49 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E65EF1203C4 for ; Tue, 16 May 2023 17:56:48 +0000 (UTC) X-FDA: 80796873696.10.CFBF225 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id E6B5C100002 for ; Tue, 16 May 2023 17:56:45 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SAyDZvq3; spf=pass (imf05.hostedemail.com: domain of vkoul@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=vkoul@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684259806; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l0YG26SggnMgqFK6GAegkgTGvSL84G04qHiNLpaBIYI=; b=JpHXvSXiiAjWx/uO+YOYp5uaOOF5vUuT1+LUtXhi+mmbxkCjnk6zxv670WUjLGI9u3QoZS 5Vh5+ZvBpvqYuebCqIQ8khbCSlpu3OK8yoTLN6CTcv3euXJEiGZpjWeNIKE6jXNHmQVt4n zWlE1+uVCy1aFsu+GcmLRv2misXkz70= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684259806; a=rsa-sha256; cv=none; b=XyxrGHt/rOy0owCDc+OZWGuKsMNiLY+ykbYZrJCtR+zhhvMxO3+eKlSCeC2dYAGnUSQem/ sv915cJXFb+7knqwYjbSepAe/l9hO5w55NQ4uFPg5T2+f0t5hvNwwvBgIzhuaFuC8J9+y4 Ps84+6EaY29j8QhkJEgTScLCODepHDE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SAyDZvq3; spf=pass (imf05.hostedemail.com: domain of vkoul@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=vkoul@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B8FDF63620; Tue, 16 May 2023 17:56:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9498FC433D2; Tue, 16 May 2023 17:56:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684259804; bh=7ULD3yxJaogVlKiE5g0T5dzK9aiAn4kF1SV1cudf0a0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SAyDZvq3aI7/IDGeV2SK+xROv4K/jTU2+ZB3sCeAk+zcBLZcL0uYl7DxSR6UkmAbc GiL70Fl1igazasLe7Nfh1eye/vhD7JlpTfEwFNZa4V3mJ7oWobs3KJAybvXJUm9Z1s jmqTpuxy/tY3W9o/cVEo2kiZ1ONxXb6ZX3MTypvUR7cVMr2kykDqZgrrAQO0fn0BK7 +bi2nP6QdG1CyxxfjVNbIRJ9UZ5OX2/Tqf04H+Q2pzva0bfJi1FstVkdad04QkvTNF DQVh1PrLL/V+pmjguWD+nhXThIs7nitRkmHAwu9uwJ2r5hL9SVV0HT/H3jT/f/tTql zJ9h3Yz63kG0A== Date: Tue, 16 May 2023 23:26:39 +0530 From: Vinod Koul To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, schnelle@linux.ibm.com, linux-s390@vger.kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org Subject: Re: [PATCH RESEND 2/2] dmaengine: make QCOM_HIDMA depend on HAS_IOMEM Message-ID: References: <20230506111628.712316-1-bhe@redhat.com> <20230506111628.712316-3-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230506111628.712316-3-bhe@redhat.com> X-Rspamd-Queue-Id: E6B5C100002 X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: uf7mqze65hx3n4s3cw8dsf3f6xs6fyuk X-HE-Tag: 1684259805-592025 X-HE-Meta: U2FsdGVkX1/BRtKM52UFH3OcbGB9cziSA6g1nUFomUwVd4zLlm21ZQCaVzng5Tgo4GpygVg8+JoJv+t4W5Fwqu4xWyeZI9lJmMJHvvcOzsF53KINw4rpsRoUQaMFXVOHCuTDOrUkdMxr/tXRJSGplQ0eTONb+H63++tLU0lqoYD1u4LnzAoVV5TQeBhA/LkQK3rIOLjdcQHums5qHbvU4Mt1O7UpjMUu0ilbv18TjB8d8qP4ainTzCj0tNqzRHSaNGHypwy5RQImkFjeRfpuuOhV/K3ibZTnKO9T9H8l58S1B0qEVS+cfVBUNuLlAwI7IaCnaMPVaaNVpyOp2M3mP5XVvZNnfmHKnVaQwFnpYzHBVF1fi1fFpjQ08HoanBVuqpPvuUUnsYLNVBV7LSaD3YrUBJGMuZoYfPE4Wx139DhjOIBB7YSl681r4yR7pv7uTO7l8Uj0rj6vLiThkHJHTJqZO1fCs3GOF5aEHDOiuh9RcV8VfqeBy+C5aox7pyGehfa9QmjJKZRoRTIT+XSmHbK1Jh4ItAM2SQwIv7vXW9Qi3HijvklRiibT/7hZUX/xKStv3sV1eM+C7cY+BmDo6UPsvA5EHWqnut5hE76T8eLbEBVdqQxw+QDrGjf+iRHge0aTy6NpRhDrMJTgOyrUCWrPP14UEDQ7iD1nn3t0eBJZWeBI6DDrt5fyGLOhZYXbFL1XHc77DhguvP0JUJ0wovfGrigE7MQg2ww3zV8uFAZYEIMb8hs0feavhgVZBURcGRgta3V6VhF+sc1ZIDa111BwWwdIOwNGNeY/wj4nDmc6z6lE6lOelvIZnpC+UAlPwi2ZtbJF8Eu4Nu77ZZFpbiuZhpEaIpjPXHkbUN9gfwhGjg1eMVi5UFiveTdnqw0ej4cs4RKo6FnA0xTjyqlCSqVnR/2IFJSdzt6CKbzSVzwj70me65BrFA7pyfyp2Z4Qh9joIm+2ggI1hHxv792 QTrXTtda uHixip/XivBgXstuhSCfxKnLM+YkO948BwnbGUGNzlvesCx742xsGQWZm4ZF8W3RuOCj8Uwd6i1edufbO8gI6JGZWf8i053o2W3H5ZghME7n/e7+tBhPHCajk5Cvp1vAW4/eeKoRyz0cvQn1KUJQJZJxYWoxmdgOKjVUXMNUyL0bO+KTmbpIDspPZKVaLvNnPyoo7VtIWchfmHqjYM/nZiulnbUGDGJy6u3y0XTkWKU5Cq5P98YCF9pI9XR4jm8z4jnFWGKcO5EL3CnTlo+60mETFS378jGTTiSPy9WX21QTruAVI6t7xr+9KFOELPFkBHcl8Fp3vkZ+TpyMG+khCvs3qJNNAlch0iSzxAwHVWA83cHEfMGACuUxtzUNPo14iuJU7gtdbVsDGE1ogIi41PNalBsgVlGHvf/6jVRX4vrHN9A/+BRFLBugM1MOjwH35dihT0tkWfNhW4zEWaadfR6yyCuGbj6Nwtc5Rbs4h35XoTjmiL1uebPrn6Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 06-05-23, 19:16, Baoquan He wrote: > On s390 systems (aka mainframes), it has classic channel devices for > networking and permanent storage that are currently even more common > than PCI devices. Hence it could have a fully functional s390 kernel > with CONFIG_PCI=n, then the relevant iomem mapping functions > [including ioremap(), devm_ioremap(), etc.] are not available. > > Here let QCOM_HIDMA depend on HAS_IOMEM so that it won't be built to > cause below compiling error if PCI is unset. I have 2/2 patch here, where is patch 1 of 2..? > > -------------------------------------------------------- > ld: drivers/dma/qcom/hidma.o: in function `hidma_probe': > hidma.c:(.text+0x4b46): undefined reference to `devm_ioremap_resource' > ld: hidma.c:(.text+0x4b9e): undefined reference to `devm_ioremap_resource' > make[1]: *** [scripts/Makefile.vmlinux:35: vmlinux] Error 1 > make: *** [Makefile:1264: vmlinux] Error 2 > > Signed-off-by: Baoquan He > Reviewed-by: Niklas Schnelle > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: Konrad Dybcio > Cc: Vinod Koul > Cc: linux-arm-msm@vger.kernel.org > Cc: dmaengine@vger.kernel.org > --- > drivers/dma/qcom/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/dma/qcom/Kconfig b/drivers/dma/qcom/Kconfig > index 3f926a653bd8..ace75d7b835a 100644 > --- a/drivers/dma/qcom/Kconfig > +++ b/drivers/dma/qcom/Kconfig > @@ -45,6 +45,7 @@ config QCOM_HIDMA_MGMT > > config QCOM_HIDMA > tristate "Qualcomm Technologies HIDMA Channel support" > + depends on HAS_IOMEM > select DMA_ENGINE > help > Enable support for the Qualcomm Technologies HIDMA controller. > -- > 2.34.1 -- ~Vinod