From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1C66C77B7A for ; Tue, 16 May 2023 16:34:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC4B9900003; Tue, 16 May 2023 12:34:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E7515900002; Tue, 16 May 2023 12:34:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D15F0900003; Tue, 16 May 2023 12:34:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BFE5A900002 for ; Tue, 16 May 2023 12:34:52 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8B328120387 for ; Tue, 16 May 2023 16:34:52 +0000 (UTC) X-FDA: 80796667224.24.2B5B415 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 691111A0017 for ; Tue, 16 May 2023 16:34:49 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HuitTlbM; spf=pass (imf19.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684254890; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=53NKQ5uw9SnRFMJTCe9LxwJTjXKaTTMdxaGXn1HcNvI=; b=vPmdwm7ZC/BQxo+K34FfOHFLmeitrRN28GvTbAhEpsDh/dNCx6i0Q7OyyxNQLjENwCoEC9 h83tG2MOw97po/pfLjBMQ9qqQw0WbPTwHcEpmmxWwk1fRAtPSo5tZ6nOWzoxw/MGr1vLTE uqWJUB4/5npTylfesgZ2H1ZndEHVVCI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684254890; a=rsa-sha256; cv=none; b=uCSjWDKpMuPCT0rgfdfNBSqP/tl57xnKmxsLN9fGzWfQ0aaKaiATPVwcD2ARsEehdR3NVY cQLOI43W0+qhAOUFzZE4CBymTH0HXc23l6P/88XSPQ2+KDoAU5ebjxfetnfmL9rwYIYt2M ZmcpLAhMczP28ehL9HSDOO2u5rN9K8Y= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HuitTlbM; spf=pass (imf19.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684254888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=53NKQ5uw9SnRFMJTCe9LxwJTjXKaTTMdxaGXn1HcNvI=; b=HuitTlbMDrPREpLIEkG4HjKy6T2UDaMdCl3iG9VJu0Zmx0jjEjSMQ1ZSZOwQgullBa0kKa RXaaZ5JGSlLC3fUIp+2b3fXVv37K892YIQEhj/PfylnVf2gmYhAo/QHSIrpLwmPpzKUE++ OdDBfe5B5eF4EpkJ2wdtgCSU2VEk2Cs= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-553-wdRDBmLqNQKAz-5uwKqtYg-1; Tue, 16 May 2023 12:34:45 -0400 X-MC-Unique: wdRDBmLqNQKAz-5uwKqtYg-1 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-3f387d3b41eso8749491cf.1 for ; Tue, 16 May 2023 09:34:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684254885; x=1686846885; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=53NKQ5uw9SnRFMJTCe9LxwJTjXKaTTMdxaGXn1HcNvI=; b=YmuU1ls8oySfaOHa01QvsitJsfl5/t9L9LaDhyBEIsg0Qp8RDjLz7YmE+KN8u96v6h S5JUCRJktZ/Qs3JsijYClTvWOl++KmRTZDHu4CtZiXRnNGEZ9nYUpFh/B8PZKIqT3sEy 6D6BP7Si38A/TFLb33qzq4gWBRvq+PdeRWvsHTXMg4X7W4trUOhQie41JZ0iMDnZZCkA IHNP5OyZ3beuzS4708mHmhpaeW16ztfa9yRVhufVaW3RGHSdVPs30jxM7Xryc1RNWHet E2gAJb0ZUZODe9phdat7VnNGUBJMGifNHY/xQ9zDBa2N9pT1ODTSk9UBhU22Wk0NcuqN Dkqw== X-Gm-Message-State: AC+VfDzdO2g7ZXD9On5oGIX/lBEDK4JpAc1X4e5bo2PUeTyxQwmDR+rD 45B9LsCKXJaXzisx0RpIUFPYVhklz+gpLApNQDlDe0fXbizMxMvSFXS2mpxrr8H3V6dU54DN6WL 9tGKkYB1bCyg= X-Received: by 2002:a05:622a:1883:b0:3ef:3912:ab3e with SMTP id v3-20020a05622a188300b003ef3912ab3emr241903qtc.2.1684254884941; Tue, 16 May 2023 09:34:44 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ45k6UsYhy0Q1O9scbqGvnXiic8Hnt7VxHTJtSYtfcme6kIxey26s7vFgM/LTlqpcCOXk5E4g== X-Received: by 2002:a05:622a:1883:b0:3ef:3912:ab3e with SMTP id v3-20020a05622a188300b003ef3912ab3emr241870qtc.2.1684254884693; Tue, 16 May 2023 09:34:44 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-62-70-24-86-62.dsl.bell.ca. [70.24.86.62]) by smtp.gmail.com with ESMTPSA id d28-20020ac84e3c000000b003dd8ad765dcsm6336150qtw.76.2023.05.16.09.34.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 May 2023 09:34:44 -0700 (PDT) Date: Tue, 16 May 2023 12:34:42 -0400 From: Peter Xu To: Jeff Xu Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-hardening@vger.kernel.org, Jorge Lucangeli Obes , lstoakes@gmail.com, Liam.Howlett@oracle.com, zhangpeng.00@bytedance.com Subject: Re: mprotect outbound check. Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 691111A0017 X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: q3r4c45irixwohhb81cf9x5h3a8izxbn X-HE-Tag: 1684254889-982263 X-HE-Meta: U2FsdGVkX18MrlzVtKiMRU9UdhZxuPhfs/KUJgn6djXCaDBeH7PJiBQhrRx/PeuNXpg+uhCKySz3IK9O84CxSaj5Xbugv+lgQnVWROK8PAAtJMr8YZKdamF1rOw+7xbvrOg8X0MPuuLeQ/X5Y3JzddvxRmKVwEfP8joNVNX2/gdCfbgAy/ZgDNRCDTXL4c3UeL8vCmk4UgGisgWwOAAmgjPPXpBUSc6BCA7D5mAj0OO/c9H7C8QDUcpxZ78ZFs+KvQYii4k0qWVuziqMoBSS1O9kbxWQivBxtMxaVZB+yXduMcOYXoDimk5vSifRtdw+1je8N6SerhPwyzS49/On0x4PdI3gEh7M2L+ukJpPv7b4m84BdAc3urK3JpRbH1IvrKT/Ip8ZDkMQosFJyUfusR4JR9w4QQs54fPE5woI144deHOBSrazmzfR5LG8kvByayJJzF+RXaztGnoCQMXlqqpRP5ij9gHQ/CrDZ/GqfpS06mUxqJuAtf/TnQRsyR6J0oflUuiIqOZwXYc4ZGWDrft0vcUQ+zcEHLBA/+BTiKG+4zUrEmZ7N1rDl/tlmfRJu6tkbOmNKr5t7GNrP2ARyxTr9x/q8q8qCVE+L8aSwyj+gMivp/hRv3QGA+AU7O+9gygW7Rnmf8H7Z8SSyz2jXZ6oxNwImRxuN7JZ4DilHzTl44qTC6e/4wbGfklSsi7oA17tjgbG6aXsur7GGb8+LNUgvEJQDJQIcsaVVSNKcfveO/HUcL9maaQD73ZuofD5Hrz36t4N4Bb+kKeF8aOKiGXpRLWm/H13Z6Kd1Yx1a64tIohNxCOD5RAlE6EslxTXS7ZrOO+RgLtGmdxJMSYi5GVabf7kIE/FgIftmZNuxeVZHz3Kwq/dxtlVhOqfnTCA7PBBvkPQeRNawI/kB4iLbxSYRKu2j1MNVcKOrf9MYbij+wxvfSbfL4FXLNUuIjEQ0GHGYL872VKqmzJbsav 67XXe/tz sCLPoyIZa4EPWhOw8xFNtpDAnN+Pw/i1tEYlQHR5b6jNsY/1E7sFE1VlLxIJAINlgcydHIfKE6xmJWu+v3wB9bbxQDqCio0Cg1SA7kU4VSH6shtikG55CQ5YWV2vEnnVT4jBgj2sLmfn3qudA6h8My02YmC0cXVsl6DABMAk6iTq0IdOyjMz5znvF2fgWst6tqYSMbNaDQN5UUOPdtjv0AQlNJNJmB6Ox8SHU18EiOMZGXpUqniO9PikrHIcfda2QSpwNSVoDqx9Hy+6vH4Q7kMkwyscdWwq+Y3BKlSvJNrBmLlQamA+hWGY5HTmBStJBboQ1sN7ZWbjdHTWhphWlLB+dZvFspdBUKgUHApNWUpjdmRJW6mF5PurPCiFEvkszP9I1CUEb3AUSAfe7A0/6nb8TaHQPmnagf/EC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 15, 2023 at 06:41:35PM -0700, Jeff Xu wrote: > + Peter, Lian, Lorenzo > > Is this related to this hotfix ? > mm/mprotect: fix do_mprotect_pkey() return on error Doesn't look like to me, that seems to only avoid replacing an error with another error, rather than stop returning error for any case. AFAIU this shouldn't be intentional, but Liam could correct. Maybe a bisection would show at least when it got changed? > > > Thanks! > > -Jeff > > > > > > > On Mon, May 15, 2023 at 11:00 AM Jeff Xu wrote: > > > > Noticed there is a slight change for mprotect between 6.1 and 6.4 RC1 > > > > For example: > > Consider the case below: > > 1 mmap(0x5000000, PAGE_SIZE, ...) > > 2 mprotect(0x5000000, PAGE_SIZE*4, ...) > > > > in 6.1 and before, 2 will fail, and in 6.4 RC1, it will pass. > > > > I know that munmap will accept out-of-bound cases like this (because > > memory is freed anyway). > > > > Is this change intentional ? > > > > Thanks! > > Best regards, > > -Jeff > -- Peter Xu