From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14A87C77B7A for ; Tue, 16 May 2023 08:48:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86D0D900004; Tue, 16 May 2023 04:48:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81D4F900002; Tue, 16 May 2023 04:48:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E500900004; Tue, 16 May 2023 04:48:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5F128900002 for ; Tue, 16 May 2023 04:48:36 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2F2131A0179 for ; Tue, 16 May 2023 08:48:36 +0000 (UTC) X-FDA: 80795492232.14.322E370 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) by imf30.hostedemail.com (Postfix) with ESMTP id 6AE9F8000D for ; Tue, 16 May 2023 08:48:34 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=armlinux.org.uk header.s=pandora-2019 header.b=js0YVStH; spf=none (imf30.hostedemail.com: domain of "linux+linux-mm=kvack.org@armlinux.org.uk" has no SPF policy when checking 78.32.30.218) smtp.mailfrom="linux+linux-mm=kvack.org@armlinux.org.uk"; dmarc=pass (policy=none) header.from=armlinux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684226914; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9gKm6hNxnZ/Qorc3xxf+NVLvSWCZn3qdfwRSX3WF/Bk=; b=KImdC+IkowR7Zi+jwv7yoInaqotiqP7mwp14LoepKGzOiZnY4AdycqrwBgkfgy1vAr/jSX dZs/6ZSbJ89Z2gYbhq4KAn6xxIFIo4Pm9fbmw6H7g+h4jby7vAJDCbE2eBCPCv2vdKJgEW A092FxKHxDS6AEK5rGUv6SWPMuGSSko= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684226914; a=rsa-sha256; cv=none; b=1QuhBLQshL2X84S1YAjr6RSlUNcaQUT345hwerYMx3IZACGSk0a4JHCFlghv6Ou+p/1ZjG dGmiQ8FkhRDxZjZgIwm02gNkIvwl5VJ0+ft17MPpoPDeB/+QRFuXsXyo0BYzb4R4SX6IoK KIjOLU3KmFbqMcA/Vj7FlKPDzpHbY2k= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=armlinux.org.uk header.s=pandora-2019 header.b=js0YVStH; spf=none (imf30.hostedemail.com: domain of "linux+linux-mm=kvack.org@armlinux.org.uk" has no SPF policy when checking 78.32.30.218) smtp.mailfrom="linux+linux-mm=kvack.org@armlinux.org.uk"; dmarc=pass (policy=none) header.from=armlinux.org.uk DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=9gKm6hNxnZ/Qorc3xxf+NVLvSWCZn3qdfwRSX3WF/Bk=; b=js0YVStH13cyFq5np19XMzPZfF Dz6MdM4LXI2Hk4GZpLREH+JR/4tYvxRyAMvoQxeiPB9kjyZsCNi8JsBS/IzowgbplfbpczQ9x2/ia XGvm5MLoMNkpvl5IlKMCw+t+9F6ihZSaOMn58xxqR2/x3w52YrfAGIEOsTciraDA5Q76mFicynePN TRwJioLih3OyN8cwpWonG1n104/YHAriRZq/ZeKfZqUfCjxY7C5kk7SWGtBRNkC6W0JQmQcF703Um z+VUxgL5osKR6PInKErS2Qcq7/U2dFld6MhmpC4xDu+X8ROIVhnR0wVXbRVccYLzbblpM7WSdi6V2 +MLEvpzQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:51546) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pyqMB-0005P9-8q; Tue, 16 May 2023 09:48:31 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1pyqMA-0000fY-HT; Tue, 16 May 2023 09:48:30 +0100 Date: Tue, 16 May 2023 09:48:30 +0100 From: "Russell King (Oracle)" To: Thomas Gleixner Cc: Andrew Morton , linux-mm@kvack.org, Christoph Hellwig , Uladzislau Rezki , Lorenzo Stoakes , Peter Zijlstra , Baoquan He , John Ogness , linux-arm-kernel@lists.infradead.org, Mark Rutland , Marc Zyngier , x86@kernel.org Subject: Re: Excessive TLB flush ranges Message-ID: References: <87a5y5a6kj.ffs@tglx> <87353x9y3l.ffs@tglx> <87zg658fla.ffs@tglx> <87r0rg93z5.ffs@tglx> <87cz308y3s.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87cz308y3s.ffs@tglx> X-Stat-Signature: zfcaxam1jy38zb41c6uz981ciweots1x X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 6AE9F8000D X-HE-Tag: 1684226914-996018 X-HE-Meta: U2FsdGVkX18N7wuI8MSiwjkzCoTty4TnJwAtF17gqeUZRXBWxfmpanbZIzOkkwReJ3nSv2Rp9DyiaAZ83yH4X/ncj+7dJvZW/froULtII6wPtPT2AncMXdmPxS8UsraCCT/hsPZmJ9Q7NOfsH8hVyXARbHjeN2gHd3nlAuLiCtqSta9BKKrgo/22k8zf111On/GQw8JtSSkjPN4clSE2rf+EsYYLe9pE1zumRIoLVSrUw50OS4XVA+Cip89A/ImoNzAwsR1CQ5dS50fsQcOnnBDQySqFCmsdt4IaR+uqpDhl0luoum3TyQGqYrjYwqCplOAaTNoKDqcgsFOr5meLJDjf+WTywqkr80mdWc97zx/C3BUedf2GxSSRdLTR2blbNeL3eq6MdSD3LzDHundOnxoWcLX0eD/ce/0weAoe8falZmuO0mVamhO+isCtGxf50ID3ww6h9oc7vj16KrSlFnKi1rBd/YzKyyu+rhIUp4i3uhVv13/GcS1A2j4ZjSjtipLfRrbmuMOG2LVUCN0FYX9+lKMnowwNQw8pG3rOTAg/IDlo3h9pjtEhws0AWwBZg1jthTKHUz8bNi4gaF2wg9CiIA8PGopp6+26CbR8gGQWJ/ylvNXgDgy3wl725dy9A8fMnigyPqhn87vq9eoRUE0QXU5kCLghnCUZM9RLUXHKQ/1VK62omO+BZ1VqHdjJVTNRMd8g4Etca1+6t+Q0qYpacDsSYfj2CDEyK+czXm+1eZlvNGTugpERGexgidcFUtKHka8FI+ehZ8NsOxhrBXDYJgJmFN+VDK04m7QWDJTjqqE6QH97pGGlp/zfZz+qt3jKi46Jdxz4wUJG32KvgiYd3yk2D2CohX1UYzGsmJpmRni+Wav3/K4iubdq5kLipdZcX7xjkqUBVn1In690DnnrudcDkc1MPy/CHBE/BveSbJ/2vi3CpocLsHImgKFxr6nqDuGmygLGGmIGztO 3QvNpD5G jf16ps/4kjWtx2/HaT69MPz0meEpV9VxoG9jBHhYAX6GZwYE95hr4vmdsWgRe4PdaNUezCrBOu9mc+ZVIJpTvPeKzJnDxdCBChK7z5HIQzgL3tZ294F+tz3q/7g4ABtSb9vOCP8BkfMiZnIOhdDedAJ+w0t8Ri/kBqkCGpbJRaZTLhDT2NMVx7Tu700q90TnoxdcyrnJHVMnrtNA2bGcn6ngUww7cHi7Ci3oyls6nI7Ja0YszRP+LtB7oGR3Ztn7YhbyY5k4Oh6nGFC3Xum2tXPlojPZqHzdWuOPhdyOhN5Dw8W1tbthZ5BckSblozQbMN6A6TU8nlZUKEX1XFxl8Txzt10UhzVqOM5//B9+yZ8/Wa6FLU30LZwjFdXiEZ8kBzB/+Ri3PrOghCNw433T9Au9QSYMTQqFRPnQuh48KEmDN94RMp24Ec/rPuBqbzSlW+ReZZuVGc0FohIgNRIvdl0INRGs+WE10z3ia0NC1PlJ9+gsU9AbHdnyX+F+vKUzg5pU3AR6HpYGbxBQIg6A/0OW/GJYJHnyXoZMKyUTH+qX/T4mZVbL+7VNTrw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 16, 2023 at 10:44:07AM +0200, Thomas Gleixner wrote: > On Tue, May 16 2023 at 09:19, Russell King wrote: > > On Tue, May 16, 2023 at 08:37:18AM +0200, Thomas Gleixner wrote: > >> void flush_tlb_kernel_vas(struct list_head *list, unsigned int num_entries): > >> > >> So that an architecture can decide whether it's worth to do walk the > >> entries or whether it resorts to a flush all. > > > > Is "num_entries" what an arch would want to use? How would it use that? > > It doesn't tell an arch whether there is a large range of many list > > entries, or a single entry covering a large range. > > Does it matter? > > The total number of entries to flush is what accumulates and at some > architecture specific threshold that becomes more expensive than a full > flush, independent of the range of the individual list entries, no? It depends what you mean by "num_entries" - is that the number of pages to be flushed in total in the range? If so, what does a valid "start" and "end" range passed to __purge_vmap_area_lazy() mean for num_entries - does that go to (end - start) / PAGE_SIZE, or would it still be restricted to the sum of that per list entry? If so, what's the point of passing in "start" and "end" to this function? I'm not familiar with this code... -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!