From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AEC2C77B75 for ; Tue, 16 May 2023 13:05:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6AE66900009; Tue, 16 May 2023 09:05:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 65E70900002; Tue, 16 May 2023 09:05:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52670900009; Tue, 16 May 2023 09:05:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 42285900002 for ; Tue, 16 May 2023 09:05:23 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7D8DA1A0299 for ; Tue, 16 May 2023 13:05:21 +0000 (UTC) X-FDA: 80796139242.29.C514805 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 3C2F81802EB for ; Tue, 16 May 2023 13:03:49 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TB1e6oxu; spf=pass (imf16.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684242229; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tINlKvgyQ2vAChliCA1uarlkfAXboH0fEYXvp0VtNa8=; b=VUcNsGVewyDyE8eV9e+zhDkhjpF3TM9KBSDVBRulbFCP5R5DOHAw4YVVfr2nvPcgxsKbxu FcJMSvf+uS6+f0Nyv3gkRXi4n/Rpkfm8crdU3BRtcQsJeZZzXMLUWLVGIhlzQMIv9y87pR zw8ZuTXoZi5e4jY1QWNlC/MCr+3K1q0= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TB1e6oxu; spf=pass (imf16.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684242229; a=rsa-sha256; cv=none; b=KBxS83SVZB2QD0rh+q+qkcwPS023lvWUxAmGMMWJdc+4V0RLjk+beas0jG9IgFY4IwlSym spfN9oRywG9Hz1JLxRkvGLWSoVeLFTiFXi16Q18ojmgzL38hJRRX6xMit8oRUG6KHRfXdw VAG6d7e01LZD2BYRN/jnwd5XfqCBxKw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684242228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tINlKvgyQ2vAChliCA1uarlkfAXboH0fEYXvp0VtNa8=; b=TB1e6oxuT9N6GTlNQzt7AxyfAzAl6fkz9jAPVTbK30WmQXAbsqkb/KdtqZiL07oPKSsJdm TismGO7CMoZUgCCFT3UYGJZA6u4bB93zQBkkrOD8poSaLyhAGKEP0dgq5QJzgGezlMFF8N bRs47eMPKbm5wIX2NVOggn7HgPeYb3Y= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-264-RiGwLzi-MrG956DbXJ3JHg-1; Tue, 16 May 2023 09:03:42 -0400 X-MC-Unique: RiGwLzi-MrG956DbXJ3JHg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 96A52101A551; Tue, 16 May 2023 13:03:41 +0000 (UTC) Received: from localhost (ovpn-12-79.pek2.redhat.com [10.72.12.79]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EDF3C63F5F; Tue, 16 May 2023 13:03:39 +0000 (UTC) Date: Tue, 16 May 2023 21:03:36 +0800 From: Baoquan He To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de, Jonas Bonn , Stefan Kristiansson , openrisc@lists.librecores.org Subject: Re: [PATCH v5 RESEND 03/17] openrisc: mm: remove unneeded early ioremap code Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-4-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Stat-Signature: anhufo7gs64mnunahu1rjxoo4b4cos7o X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 3C2F81802EB X-Rspam-User: X-HE-Tag: 1684242229-535501 X-HE-Meta: U2FsdGVkX19eNeZhh4YNT6YJA2FEgUb5gHUvSLVWpQkbIBFbo9ZuZpOFwzv32WwNG8XpJJDQeySqrmvsYY2CqotA/kgpJ1sIi9qKOzyBI5LDOTmnE8FrzDrmH9bQUxs6mFsbDy7u2oBu+nLgHGvLlHonr056LUXc+iG/SLodxRMg18Sxoby1gMyZU7am2+bGHMIO+EN+LeMA7YhVfQ4mggGCpqpnzrjUtKfpwEZHIPp/F3rwkjtPOzfKrPTdRtKqUY5yT56y3r/yn2SD5HHZfF3E1s3Rhv4x2HSPqA4JML7RVlc13M408U4r/F4gM4SMqFOrXENTsFI/qtqPJyUylVCjH+MfX3KuVc7ZOWHxh4JFQwrXAuAu5sM9fzB6e9r/dtNma+USPbLn70DPgsHr6aYPZFLZi1AhWDev5WWoEMW0EYc6wy5FeuSPA3tfrM/jiEtM5IvGLp28WYhXATP0qtwm55K45PcCtodJ+6L5xEP2ReQE/ps9DqGBoV43U1VhEsycVf+7heKyfTsBEqDZ2j26h13LskVbm6bwQkj6iSWCVec3qjNrFBKsjfJcGZhaqp/nyXpZEQhoX3SgTsmrmZdRLwRTbJwXUXLPBPla89DGXhZDWtpHAx5qTP2Vr87nT+cAqps0jO34UiTybZNHuChp74PPbGTFpzDr3O66QnVPxkl/mEQ9DF7PmUOPHfiTf2RALyZg+LSZn8XdtkogeqjF+26HditsoeJc1EKDZ+EIhnK7gETEHq58oEDq5QB5D+sTG6rFUS7tpjq4dVPrr1MJvZ2VBqInz083ZCsTH9JuwZHtwkLqoyD1RjL/NfHdKTTW+uprwBLO+pvOKuQl3nauB/7Ur1wr9/rUzzMj9qGQqvT6QzWutI9dfkgmBOTOezAqAnZuoi1HDv3zK9r/Y5ttFTFfQrrMR6dM7HWC48g7kJCu5ueFIvvKlL2ROWSs/fBflJ/dLqyuSvCOxUs BBC3wLdV Kpoe1X9ruVvFXg27Z0fP+LY9vupBjCJH0mUK9YwlwQFMb2sR3KLZPI8w/4V5B5xcvH1I/aeC8DNeN3C2aeK0XnZoX5SWwhNeo1pj19n1pdBT7VrB2InMIVF1ygwZHaMUA7kzwH6lC4IwO2wJkRP+yOE5Vn2HFbmLV3429W+P6X5j/K6pXonhbfpq5KkHyZKVjYnp68mKvonPdNK8+kqjOrGaSjI9ZOlCHjg9wcEYFkVOzmNXBFB8xwU0Hz1dY/LXFLYLfAFUZEVfizlZjU+0pk6bFXFkPWrVg0z3Hy2Jj7/Cms+bh0HdMnz8Yk8wqPgjTK8KpDBwxRgPeek3DvuwftppOAkQ9l8UK6hA32COJUv/eU5U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05/16/23 at 09:17am, Mike Rapoport wrote: > On Mon, May 15, 2023 at 05:08:34PM +0800, Baoquan He wrote: > > Under arch/openrisc, there isn't any place where ioremap() is called. > > It means that there isn't early ioremap handling needed in openrisc, > > So the early ioremap handling code in ioremap() of > > arch/openrisc/mm/ioremap.c is unnecessary and can be removed. > > It looks like early ioremap was the only user of fixmap on openrisc, so it > can be removed as well. You are right, and you are saying the relic in iounmap() about fixmap handling, hope I got it right. I will remove it, the code will be more cleaner. Thanks. > > > Link: https://lore.kernel.org/linux-mm/YwxfxKrTUtAuejKQ@oscomms1/ > > Signed-off-by: Baoquan He > > Acked-by: Stafford Horne > > Cc: Jonas Bonn > > Cc: Stefan Kristiansson > > Cc: Stafford Horne > > Cc: openrisc@lists.librecores.org > > --- > > arch/openrisc/mm/ioremap.c | 22 +++++----------------- > > 1 file changed, 5 insertions(+), 17 deletions(-) > > > > diff --git a/arch/openrisc/mm/ioremap.c b/arch/openrisc/mm/ioremap.c > > index 8ec0dafecf25..90b59bc53c8c 100644 > > --- a/arch/openrisc/mm/ioremap.c > > +++ b/arch/openrisc/mm/ioremap.c > > @@ -22,8 +22,6 @@ > > > > extern int mem_init_done; > > > > -static unsigned int fixmaps_used __initdata; > > - > > /* > > * Remap an arbitrary physical address space into the kernel virtual > > * address space. Needed when the kernel wants to access high addresses > > @@ -52,24 +50,14 @@ void __iomem *__ref ioremap(phys_addr_t addr, unsigned long size) > > p = addr & PAGE_MASK; > > size = PAGE_ALIGN(last_addr + 1) - p; > > > > - if (likely(mem_init_done)) { > > - area = get_vm_area(size, VM_IOREMAP); > > - if (!area) > > - return NULL; > > - v = (unsigned long)area->addr; > > - } else { > > - if ((fixmaps_used + (size >> PAGE_SHIFT)) > FIX_N_IOREMAPS) > > - return NULL; > > - v = fix_to_virt(FIX_IOREMAP_BEGIN + fixmaps_used); > > - fixmaps_used += (size >> PAGE_SHIFT); > > - } > > + area = get_vm_area(size, VM_IOREMAP); > > + if (!area) > > + return NULL; > > + v = (unsigned long)area->addr; > > > > if (ioremap_page_range(v, v + size, p, > > __pgprot(pgprot_val(PAGE_KERNEL) | _PAGE_CI))) { > > - if (likely(mem_init_done)) > > - vfree(area->addr); > > - else > > - fixmaps_used -= (size >> PAGE_SHIFT); > > + vfree(area->addr); > > return NULL; > > } > > > > -- > > 2.34.1 > > > > > > -- > Sincerely yours, > Mike. >