From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 369C3C77B7A for ; Tue, 16 May 2023 07:02:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D2A6D280001; Tue, 16 May 2023 03:02:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CDA71900002; Tue, 16 May 2023 03:02:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCBED280001; Tue, 16 May 2023 03:02:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AE02B900002 for ; Tue, 16 May 2023 03:02:37 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 73F8516148B for ; Tue, 16 May 2023 07:02:37 +0000 (UTC) X-FDA: 80795225154.10.22C6D68 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id BFBF31A0015 for ; Tue, 16 May 2023 07:02:35 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dqKO7pq5; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684220555; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=njlI1LmjRZaEp6WK7zcLPeQbvpU+FX18YegFi9vuPbs=; b=suDodbkOTH2b1lNN6S6Y3rjnKiGWiw4dcDu447YxkFqo9or76qvdT1dxox/cX2JDJR2fwj jx1oBMJkjFYhxVsycHBQm+0GpaepZHJuqQfitSsYr+NcmGOsHwlFZX1HxN/9vxjwnH3xNN HMlx9W7+8rIusYfLyGC54T2AAXm7cTY= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dqKO7pq5; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684220555; a=rsa-sha256; cv=none; b=65qkuboV29FAPJ8fXIHbyMwMyPyB7aP7Wh2oPiOGzFt66I4UGRRYH0XqtPSufki3tHTEnG M2RKJhRlaGXAyv0iVVMSXyZwFbZX1DvKFqQ8aw2is6ZEgEot2gfRL2/wtfbKz8a+5AQQ/y /G2UA7C2nkSj3J9jmj4wJkMEQJ++98g= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EC64663525; Tue, 16 May 2023 07:02:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4998C4339B; Tue, 16 May 2023 07:02:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684220554; bh=X9UrfPvqqhVbnlEuITxxN82KxDibpUaM4pahEhKSVQQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dqKO7pq5UGDtIJ1c5ASW+yMbd+dr+SgekKIq/AifX6XgNmFCfW50hv5yfQTrDLvDr M4utw2ZSRmQ96/DsD9ZUmp/r+VaLrJr1LX1FI6MoMYF4GvbYPN3L0DC7KZE0fTEGrJ wRGz2Vc0tURGM6JPz/zlzk7K22VrIScJh+vJ2aYdsXYibBBAxnf6geAyMG7cuxJ7V8 8CQz/I5BxR/sof/mhEQkRq1eBp5AHh4Ys9onieZWZkw4e/VX/lxen2drPKmOZ2FQr5 zsYRvuA3svHu+9GOVUfcp17byP8gyjlSzUmiEFCKjHzuBacNZJc5qqy5w7qj2EGvfV zyKuKFKeQlTdw== Date: Tue, 16 May 2023 10:02:27 +0300 From: Mike Rapoport To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de Subject: Re: [PATCH v5 RESEND 17/17] mm: ioremap: remove unneeded ioremap_allowed and iounmap_allowed Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-18-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230515090848.833045-18-bhe@redhat.com> X-Stat-Signature: jq9yaj1gpdamb7kgig134ti6ufp8uf9u X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: BFBF31A0015 X-Rspam-User: X-HE-Tag: 1684220555-365329 X-HE-Meta: U2FsdGVkX19uEAhyx7XwhkvmKRxHVKaIA/DCt4jcUZMrX1fleG1raHvmH414CBlflHg9WOJitvieqIY9XovsvuNJgZGYC3g3ygLAhF2arVt5/jlvIVcsTmljd/YWfGHJmTsdsIGqhuf/Y5crAr3I86JnWQhm++ZKJV9EBndmadQve74+alAv8j14grR2ssbHo2PDREj9U3Yb9ELSflctoKInueAXQFsBzWpFvqh9KCeWQH0JFmDsjtSsVrHUQgkVGSIAJvP2wB3hceCItMhgeg8G63Kj/YqJZq6CoxapTz6wkw1Uukjkb7T5qw1YxqfZIA7KeVgE2+JKogjeEaqaU7XzFFjT/bVjpRFDoE11Y4Z+QjzA/4RR2gsHegqOSp/JpHKVgog1XA2hOY1PsbNYHyAYE7AT20gEE/pQKXSNx68YdYGg5GpujaOVBDWWaC8W6yxFmAN/ZZbSyBzDfaR8Tz/A5mFBE7so3iotDXsmwlawz7ENSQPaJ6QIw0jitbPnUtLzjY2QR2k4PNycAeHG3fgS5baZpWsxjeDIDhRDrhIKyWxJDxidwKz7TtNpt/bwFoosJ50dA3+atmaUKQXwDACwxSjR9AeW/UUiN4L1OM9EIeAHVhCE4ecVW7/ZaobXG7siAhT7GjBzwKW15mzoej9WXQjapVvbG4PZ5iAXUEk8fHfPyno448aM+aPOGV29F/vNrf4ToRPQpJ2I19j/02cLW1kbQwViZn5m8Jl2ZOiftebIx9GO47qoy8XbONZl9H+4TleVbQ7vrwNE+onC5SHyyHmWbSZKCAwZ3Y7Yq2KwanICtTadEsV+wF237k/tG1LmkrXmBHhXvUSl2xmOxmQp3kbykbPWurbSZ97+ku9/qpv2NjbOzTK4cOgb+3Fg7wHOYq2GB/1Gns37AW9HiPutA3VKfJDiR+2SR1H6LQ3aLgJaGBirS0iLBhRjIt7PURg62kgh2mK8AW1yady LwOf7eAJ ZMM0eNSfU7XbUmwqXSrR+2ajft7ZLGFH4ijgk2yxo/KUYxg19ssnjHV1RF8OdLjfvkkcFiwPWv8l3IapOngm4NGP5ufrjfUQQdOeWAJsYLu48xg7QoMFLHkMhEjIm8D7wYXvoEr5MewRtB5Sz18lAmJblCsg3uXYo9H3OX2TRw4zWJoy2kQXH35i9wOj4R+xDQQbVdUZIupUbvzAP+vhmUT6tQVvtjXZHZlYDJpSAiNkSm+AR/AM7rijb39pxx37paqjt9TuoP6FrSxdhvf37UFzyiP3GcolSp3zYeWrhPuJWgWPBTWCwIhWg/edywGyUhvy/F9qKnUdMnQkDbLv6/N/h3fMRYAGeurVjXrDNCRHXZ+aWhtOE3gexliWoNrskBniDWSmb/YA2J3XuH4HczIpHqM5kBtV/kfis X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 15, 2023 at 05:08:48PM +0800, Baoquan He wrote: > Now there are no users of ioremap_allowed and iounmap_allowed, clean > them up. > > Signed-off-by: Baoquan He Reviewed-by: Mike Rapoport (IBM) > --- > include/asm-generic/io.h | 26 -------------------------- > mm/ioremap.c | 6 ------ > 2 files changed, 32 deletions(-) > > diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h > index 39244c3ee797..bac63e874c7b 100644 > --- a/include/asm-generic/io.h > +++ b/include/asm-generic/io.h > @@ -1047,32 +1047,6 @@ static inline void iounmap(volatile void __iomem *addr) > #elif defined(CONFIG_GENERIC_IOREMAP) > #include > > -/* > - * Arch code can implement the following two hooks when using GENERIC_IOREMAP > - * ioremap_allowed() return a bool, > - * - true means continue to remap > - * - false means skip remap and return directly > - * iounmap_allowed() return a bool, > - * - true means continue to vunmap > - * - false means skip vunmap and return directly > - */ > -#ifndef ioremap_allowed > -#define ioremap_allowed ioremap_allowed > -static inline bool ioremap_allowed(phys_addr_t phys_addr, size_t size, > - unsigned long prot) > -{ > - return true; > -} > -#endif > - > -#ifndef iounmap_allowed > -#define iounmap_allowed iounmap_allowed > -static inline bool iounmap_allowed(void *addr) > -{ > - return true; > -} > -#endif > - > void __iomem *generic_ioremap_prot(phys_addr_t phys_addr, size_t size, > pgprot_t prot); > > diff --git a/mm/ioremap.c b/mm/ioremap.c > index 4a7749d85044..8cb337446bba 100644 > --- a/mm/ioremap.c > +++ b/mm/ioremap.c > @@ -32,9 +32,6 @@ void __iomem *generic_ioremap_prot(phys_addr_t phys_addr, size_t size, > phys_addr -= offset; > size = PAGE_ALIGN(size + offset); > > - if (!ioremap_allowed(phys_addr, size, pgprot_val(prot))) > - return NULL; > - > #ifdef IOREMAP_START > area = __get_vm_area_caller(size, VM_IOREMAP, IOREMAP_START, > IOREMAP_END, __builtin_return_address(0)); > @@ -68,9 +65,6 @@ void generic_iounmap(volatile void __iomem *addr) > { > void *vaddr = (void *)((unsigned long)addr & PAGE_MASK); > > - if (!iounmap_allowed(vaddr)) > - return; > - > if (is_ioremap_addr(vaddr)) > vunmap(vaddr); > } > -- > 2.34.1 > > -- Sincerely yours, Mike.