From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25CE3C77B7A for ; Tue, 16 May 2023 07:02:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A844900005; Tue, 16 May 2023 03:02:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 95A09900002; Tue, 16 May 2023 03:02:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 84708900005; Tue, 16 May 2023 03:02:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 760D2900002 for ; Tue, 16 May 2023 03:02:20 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 36F40A0148 for ; Tue, 16 May 2023 07:02:20 +0000 (UTC) X-FDA: 80795224440.14.8415760 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id 7ED3B20007 for ; Tue, 16 May 2023 07:02:18 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lFWmtz+S; spf=pass (imf13.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684220538; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Rm5VXXsqIusMWRwdt/YknTSvs0yGSqmTmnUCEZ6I9EU=; b=vbK55niNHZXiuQr/wcq7udRx0OEVycuNlCPMzAgh+3halrUdHLJGQzUHw96fLNBAAnv24L 1SLVjImjtstdTKSF9eQv/K98G1An7/+6xRT+o5Vun+E50y4clD9bOX5rK0HRtWE+ajexfP tvATWVE26zXPPV2uEcGellQ6LTUZ4EM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684220538; a=rsa-sha256; cv=none; b=LTLUWp/DdZMpHjbkzR8nO7vC6FHkm3lCS7ADiJROSF+3J2jqagmbipH09VNJ+11rMueuA8 hxJw9Axv0AzCX79hQkPQAeSM7/IidO3CONFAsJFhNKx0OjvP7lwk18TzcsjPx+zvoonYml cE3EgG7cBL/2lKeH6mOlE05+RpUouxU= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lFWmtz+S; spf=pass (imf13.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A63316351C; Tue, 16 May 2023 07:02:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2488C433EF; Tue, 16 May 2023 07:02:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684220537; bh=0oIdahxmDcks/2I2njxfN/C39E1GVYEqbwY+cPgU10U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lFWmtz+SVS8WKz6sXrGBaXts2fFXA+qshSS6blyCsJR6AqF7t0JOZgPVjyZSO6eLh gYGpj9NwRda+r4uaUo8fMKUvO84rzoo13pa2Ybxj5USHpSSKfxnhQblW8rkf2uiJ/y A0i0hdXKjG4H2DZY6LEqn+GBz7IQEdNiPv76r5/pvKryx2xdx6QizqQadPDdbe2srD XSRmH7K7f7rPVqroJe/wonig8z2ryl/UkWBJZxaAMGJhGMZ5uUwgPswVzHf08f02Cr PiUHfAWBeEvECflYTrM4I0vE0ipunJt0ENiq1Lu/T867LZ5X+c7n8rsEjfi1ftEyAB 0QrjywtKuLnsA== Date: Tue, 16 May 2023 10:02:08 +0300 From: Mike Rapoport To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 RESEND 16/17] arm64 : mm: add wrapper function ioremap_prot() Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-17-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230515090848.833045-17-bhe@redhat.com> X-Rspamd-Queue-Id: 7ED3B20007 X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: srkitfyi5hf81e3zxr8ktw57nte653xc X-HE-Tag: 1684220538-543714 X-HE-Meta: U2FsdGVkX1+fSl+MD/pSwMyv/73mrZ01IDmXUeb/ZxRSmCcfL2BM0GWK0Hsw/DUl18z3K7Um8M3gZ5z2MKtDNa4RozGVVZQOssfM/6ksq60VnUoxGzev1Q2PIFZ77BslOIXIPIHP2Pe7b3+MxiHnawb4urbSNKrvXYFIdpC+GlUlF4KIUk25+XY6XvSeXC3Rs/hb3TGMHPKevhDZDyDbGdwvUYEdapyc7/TdEnYaqA13OP7N+2KukJTvlkEE7G2ADkKGTs5+iaMj+KdR3NmkrFCVFzn7h8Ip63O8ZEzDkpsnJNmMl/cmjPAI6F6HZ8vpi0E6nvvdWrpuSB9r8R6iTr9iGtz8bQ0ai04jZ1Yus2fGhkqA52tBYGd7d5T8t2mD29embgGTWsFrRKFmmToJxtkGgB7VmYdinszLHkC64xOnyCpf2dqHZyfdLT0gQbW8SmnCCr6VvdVY+ufF/TxZrUoUPz/MwAf9jd0zPFFHQLnrhCTDSpoYt5ivIUIc87B5Hk8Wdy4cNV5GS7/Wfbrovch+vziJhiz2qMSAB1WjMQbKSwVK0MkeKdViv69Hu4tSzB4INzBdvQ/kTdtmY4ii4fYcLiTKS2Q5bhqzI9yL/LWJ4GTm/1IJnzGlTuZ5cjtmo+qze2sRy78JPwt2By0WHboFgYjqw77xat1YPQYxogtt/v585od3UDo3cG2le7q1ReWfN3/bugtrPwv4nUYtjZmFZrUWTQY4aFjyJG1gjr0P/+AfSISvqaXAtcUX2deXCIbRDf/afDc9Xuft2t/yVHldwWNFE5TSD+hznOeT0aq1giQMYljyupEvW903erNDxk/SWWTXLIWU4wBXPfAyoy0NXpJZuj3dR+nwv/cTiy1XbzgtThcTJ5ZDcOtIwtqyifULRscnu8NddzRk/LnuqqXm5WIp8AF1EQo6lnb8UDCg2Wa0s1k0VYcXIEMumh7gaFh0V5autHnLk6jdEBR mfl/gQ12 6JPN+fjymkH1eeXd9O6orzDz9nwmgAdbwzQz7uzO6kSwDvgfdjQQ554yYObKpFbzx/fxsf9Cyxgy8XvGv/SN28xdbiwArrmH30hcvTgLfheFB3kocdiyjmHM5ePiRR7lvSAUhnxBQ/n/kebJYD6EiIHRcoU8lS6RvLyjIPZAsAgyitwBtXompdLw+5mnGgRMkv2KnShffCSDAQY8zSLineXzq/wEjBu2bPpJ5tW3VC87GjNVD2PFgOdYvGKL7pC6QPiiTzs0GUQOYm2W0I7bIcIwOVAOJAF9Ti7n4YvDSu6snZa2rdX9zewtSsNRP0eTzACGz1aPw/JciBkDBHLPv1hZTM+Y3Zk/dk4iVur9MyJpCEc7mdJlwms2RCyXz3PbWf8YKV67aCKK/MxKFBoj4xsAGcL9W37KrGztwBZ0lsKNm/TX+1HsIN74d70Ezh8RjLHzjPaIcGzk2knQJe+6pOt1Dv8WFMTZ7YVkKkVUolgGTxClH46/uOIDMB7OtlO7pt0epI5EO4eeRWoBFaXc2YxGoQjpG3UE2b2/D X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 15, 2023 at 05:08:47PM +0800, Baoquan He wrote: > Since hook functions ioremap_allowed() and iounmap_allowed() will be > obsoleted, add wrapper function ioremap_prot() to contain the > the specific handling in addition to generic_ioremap_prot() invocation. > > Signed-off-by: Baoquan He > Cc: Catalin Marinas > Cc: Will Deacon > Cc: linux-arm-kernel@lists.infradead.org Reviewed-by: Mike Rapoport (IBM) > --- > arch/arm64/include/asm/io.h | 3 +-- > arch/arm64/mm/ioremap.c | 10 ++++++---- > 2 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h > index 877495a0fd0c..97dd4ff1253b 100644 > --- a/arch/arm64/include/asm/io.h > +++ b/arch/arm64/include/asm/io.h > @@ -139,8 +139,7 @@ extern void __memset_io(volatile void __iomem *, int, size_t); > * I/O memory mapping functions. > */ > > -bool ioremap_allowed(phys_addr_t phys_addr, size_t size, unsigned long prot); > -#define ioremap_allowed ioremap_allowed > +#define ioremap_prot ioremap_prot > > #define _PAGE_IOREMAP PROT_DEVICE_nGnRE > > diff --git a/arch/arm64/mm/ioremap.c b/arch/arm64/mm/ioremap.c > index c5af103d4ad4..269f2f63ab7d 100644 > --- a/arch/arm64/mm/ioremap.c > +++ b/arch/arm64/mm/ioremap.c > @@ -3,20 +3,22 @@ > #include > #include > > -bool ioremap_allowed(phys_addr_t phys_addr, size_t size, unsigned long prot) > +void __iomem *ioremap_prot(phys_addr_t phys_addr, size_t size, > + unsigned long prot) > { > unsigned long last_addr = phys_addr + size - 1; > > /* Don't allow outside PHYS_MASK */ > if (last_addr & ~PHYS_MASK) > - return false; > + return NULL; > > /* Don't allow RAM to be mapped. */ > if (WARN_ON(pfn_is_map_memory(__phys_to_pfn(phys_addr)))) > - return false; > + return NULL; > > - return true; > + return generic_ioremap_prot(phys_addr, size, __pgprot(prot)); > } > +EXPORT_SYMBOL(ioremap_prot); > > /* > * Must be called after early_fixmap_init > -- > 2.34.1 > > -- Sincerely yours, Mike.