From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DB20C77B75 for ; Tue, 16 May 2023 06:53:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2250900003; Tue, 16 May 2023 02:53:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D1BD900002; Tue, 16 May 2023 02:53:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C18A900003; Tue, 16 May 2023 02:53:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7C17F900002 for ; Tue, 16 May 2023 02:53:16 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4E90714147F for ; Tue, 16 May 2023 06:53:16 +0000 (UTC) X-FDA: 80795201592.07.9D54CD0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id A600240006 for ; Tue, 16 May 2023 06:53:14 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RvjD1vSA; spf=pass (imf17.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684219994; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YDxuW5/Gccv/gNku+OS5oSwTPsWHEdiO44sHpzoEcoY=; b=MdOo8wlk2rQq5bQqe4JgQaciO9K0wjG8ZuLT8NcQ3uEq7tfdT2wxk3hfiXQqW1tXCGCD0w Mh//yFSkgkZTTBjsgvw7DGzIYhX9yWMx4RdwFspiTIv9xzWuYgDR3PoIiqDypH7EmCA6jD 0ZiH7lWDeaaxJBYC9F7r6XS0lj/3YyY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684219994; a=rsa-sha256; cv=none; b=sbcJuBsyCHq3XpvWoUvI/pD/78XEkP3EHXa/369l6EN+PPWlyVMbzEDpB8jS3iFiWIvzjI HGxYpAeDeM6GArCfx+/R1xu/5Z8rvkbACRnzCrKoIE8y+fWX3LV+KbhO5FGwwG1dJ8X9tb 1yKbhAzDbnFPeFBy3lhK/kJMZCKB5uY= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RvjD1vSA; spf=pass (imf17.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E018562CAC; Tue, 16 May 2023 06:53:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2D0EC433D2; Tue, 16 May 2023 06:53:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684219993; bh=zWowfpys7cJayhdbWlMlfG/naveXwBOaomK6G6YOhwc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RvjD1vSAOBJNjAg/ZIxaNqS2rkN1ZlKb87FTH1wyjTGlUAIpNihimQCBehxLwyAKY 54gGynJbfKhqXVBUQs0KQ5WYkVlgEiax4NBUKAMqRlDABOcDkYEQfDmUqFd0cVc2Rg +5tFUZtIuw2D3sq94eU18Cng/cxiFjnZIBRL6URAQLCsD8pXVC2rWlKWmYLB4LFNvN wVK415zfFdbPS4SjHqipuLQlYFG9zEqB51Of6oXmNOm2u/s3/wcGcmOyz4LvWqOjOz LoLHKaP50dbu7dxYKnvW3H+Vp/2FDG5ni4ZVU0tjPUFUOJobipbyYJvhN2PD5zGfJW 0OpmVx2CJIC7g== Date: Tue, 16 May 2023 09:53:06 +0300 From: Mike Rapoport To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de Subject: Re: [PATCH v5 RESEND 14/17] mm/ioremap: Consider IOREMAP space in generic ioremap Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-15-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230515090848.833045-15-bhe@redhat.com> X-Rspamd-Queue-Id: A600240006 X-Stat-Signature: k46detgos7khgwconyqdpd7oq3r35rf8 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1684219994-216037 X-HE-Meta: U2FsdGVkX18cmNJV4GSuJ/7Xj61VwK8ZVfAuGw2AMJMDWTKqbUzIingi7i6b7qFvOdiXtcRzRCdiKrOh/eZrZ7QRSELnThDBXNpTqmMDgogSi7gEWEV7vi1xy/aKdO2W4yb9daAi10xMMjl6xixtSIWMIwq6uirTgNzX59JxYGPeVi3li7CcDBSsFsIvUkWwS8KKOlf7Pgt+g5uCjP4sO3LJ/VT15VbcNZ+Ghq0I7IZb/h+bllyhaCW9400TKL7zABet6I5DkrC+cpvB/lyqa/BDPIduw//flrplX3LVmNOoryOfHefMp920XKY2Ht1qFAVOe4cni1pf+8zupChr7D/PtDtZMn64LQsac5RPgvDlU972ZlhsEDhL1iQRxV25qMvdRzK0sbIb/q7c/JR932AveQ9mK3lDXeBJcjnt1/moHAFMfBr7XWGeymaYnkZWW87jXSuXaxkpUUQVvWSj5gd+d1Rghr3xSHGmqpkKQ3rPBZaduZvrljSL3PRgqcq3YXEt7jxqECOqDMIPTzw68R6QREJXt6jlOteOcfbN3AwKRiL0/hZYJuJIjCXGjK6Elqv2WItHQLm+RGVdKTT4kE69QYRN22tha1fxMKJcEj5aEbXsSFOZ1NAan8o3GVUJBB6ojVwU672idqX09KgIuKcXEjofk43WtgDuyor39feB54fdubwiz9scRx0fw/KRoN16nYUeHHZbJKu9WGtTjbqUTGji8PhPrwX26CzvdFxjxDguiyiVxhTkeD5yZYnxJ8DikiE3hNuKulPMFQ85hKcpurq3qQ7UdpTdplLYoAt2YXFc5BcuTBdJjysRsVRnimuWr7v0xGOuKiFM0uvzdX8xGp1htztymO5pJApmz2x8wf5EUb994hyv20aSIdTT6CeKbVZNPr/XiXR+cM9+X2+z6IwasVzfGoxjUZnRVLO8SGwpo/uqFIWd4uZJJhn6n7CXvQVm8Tr2Xu22kQT WZgNmUXp jq+n1151WzBOOEbPIgDi9pwHjJ/JsUwucqOI5iGH3/ZHEtQE36hhW45RON4NeEntIeTfdNCtemzSjx67JIE2JN3bZMv+lbngWqtBskCIYNgEBql+sEN/uol0bhqRfQh+jn7qruhIFiokJ6JEEuGtY2BH45IZX/YmBvGUdliLFbsimoahDJ5WMyOw9gnC0Z3dXdZ4o1uIXDo7n9ZKwhT3lU9jiv+yFfcaYE3Mg4Fdvoup/njpkvTSrKRQB/H71+RGe2NPth08F3cRppF1FhpQBHwCom00hKhsgzMUhL8mYLzuYdAgAQjQBOkQ7F435/R8kWX0tCyHAzug6tM1FESWin3L64xCGBDbDvMOmXSE80mBx4AUZZ/dp3DzEMmDru6YIlQ9wI3OzFIAgFwNc2TNzLR+5p5WAbMrT6s94KkVJO+4BAyh1BDJUX7BwkQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 15, 2023 at 05:08:45PM +0800, Baoquan He wrote: > From: Christophe Leroy > > Architectures like powerpc have a dedicated space for IOREMAP mappings. > > If so, use it in generic_ioremap_pro(). > > Signed-off-by: Christophe Leroy > Signed-off-by: Baoquan He Reviewed-by: Mike Rapoport (IBM) > --- > mm/ioremap.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/mm/ioremap.c b/mm/ioremap.c > index 2fbe6b9bc50e..4a7749d85044 100644 > --- a/mm/ioremap.c > +++ b/mm/ioremap.c > @@ -35,8 +35,13 @@ void __iomem *generic_ioremap_prot(phys_addr_t phys_addr, size_t size, > if (!ioremap_allowed(phys_addr, size, pgprot_val(prot))) > return NULL; > > +#ifdef IOREMAP_START > + area = __get_vm_area_caller(size, VM_IOREMAP, IOREMAP_START, > + IOREMAP_END, __builtin_return_address(0)); > +#else > area = get_vm_area_caller(size, VM_IOREMAP, > __builtin_return_address(0)); > +#endif > if (!area) > return NULL; > vaddr = (unsigned long)area->addr; > @@ -66,7 +71,7 @@ void generic_iounmap(volatile void __iomem *addr) > if (!iounmap_allowed(vaddr)) > return; > > - if (is_vmalloc_addr(vaddr)) > + if (is_ioremap_addr(vaddr)) > vunmap(vaddr); > } > > -- > 2.34.1 > > -- Sincerely yours, Mike.