From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF89FC77B7A for ; Tue, 16 May 2023 06:48:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B120900004; Tue, 16 May 2023 02:48:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 73B90900002; Tue, 16 May 2023 02:48:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DB81900004; Tue, 16 May 2023 02:48:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4BF08900002 for ; Tue, 16 May 2023 02:48:44 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1585C161283 for ; Tue, 16 May 2023 06:48:44 +0000 (UTC) X-FDA: 80795190168.12.917D01F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id 6D1531C000D for ; Tue, 16 May 2023 06:48:42 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=H5nWBGVp; spf=pass (imf20.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684219722; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WHbmaNPvPira+3Ei9c0lisAI+g/7Fy9RvW2GzSr8ycg=; b=1B1Ndm7A3uW2sJ8DwZVeewfZltHiLKdgzPDs4D/dB83atj/eOYibjO2SVKr8+Uli+u8E/s lujtckWPiGJ4k3H4JkrC3K8HLcw5NEbCxQ9h0Hmk6odUeuNCnhqWpv8iVcgAxphhLd2uj6 ab9zDaFAk0vbk7lzyBES5o+9z0FSI7g= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=H5nWBGVp; spf=pass (imf20.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684219722; a=rsa-sha256; cv=none; b=libZ+HLs/T7nSiw90cRNi0sdIKf3iOEnu5HJ9qGxM1aN+0SvE3QwYvPpYlAR4mvKXtK113 2kXjNZ6HWC66b5pugiYxN+8CMAswGPGkS+qeQP2LN5RiMrWpAETkTH2NmQ5DNswJzB4cZ/ ErizUtM2SgBCX0vD6NT19QesTjuRp5E= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7699B6301C; Tue, 16 May 2023 06:48:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 677F7C433D2; Tue, 16 May 2023 06:48:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684219720; bh=8lytz54EhtEUEVF10JvyKvoVdJWuXGHYr66pEwPqID4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=H5nWBGVpVh7eIObnI3HWT8d0qnKWC0WDTq6zvJVPgfC9L8qza8lZPGSQ4Rbb0QDyU z8LRiznozgmQ+IzAHmth7ZWnHGjCHRNxsRsoU/GiM+/ZSQvULmR9qvdU7FCpwiK/GL XCEkd4wA5mSoLqfE3KqOrMETf1k0jX0+ScqlQI6GqLQ6YL3VLQOyBvVnjrTq5cmyjA XlUznXBW8q1iNm93zJJnIbqE5AGFIJL1UIQQN/Vj6FHFfMFI0+9C2MRSscwWCAOYN9 w8pwzCE50uFiCNCgyDJjzv2eBGJL8VrJWuOrr8WY0XUPphLbW8yPj55LJmd9+u1S9J AmXBhTOzSw2Hg== Date: Tue, 16 May 2023 09:48:32 +0300 From: Mike Rapoport To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de Subject: Re: [PATCH v5 RESEND 06/17] mm/ioremap: add slab availability checking in ioremap_prot Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-7-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230515090848.833045-7-bhe@redhat.com> X-Stat-Signature: 1hoehj19adtqh6zssgfb45rjaa3cmrrq X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 6D1531C000D X-Rspam-User: X-HE-Tag: 1684219722-863662 X-HE-Meta: U2FsdGVkX19mbUDtLvXXi/KW9tOeVE5hm4dqCgIGhqz4tMqX2n8e2Wvlu7StHeGdT+M95wkuOTEUO5maTY8DFVu70lk2WcExRfJU3odX6su6fFPtzfRBs8aoes9/PFt2TGdzx40JCIFEh38c2xHySBafWX1XINX7T+CNrp0psvBf+F+mwzcyDpgH6MTKxcpESGrkrjseZ/vAPgnr+m70DyKQth7rpInoWDPK2FRkVggfzZcnLBE9tQzyEwz5PRppSwpUM23AP2AFkQQpxuU9TCj7t396Mmls/0r6S18tfiKy79EvJNL9HBwKRUeVY3gXxmFZjgLuP9p9VH37MDP3nrJJNM2TFFH/PflYvAbR2RbQP+tFExZ9SONM6w7SX0EeBma9PdgJvei2MRyIFa+oiV/wRaW5viHb0sX9gkTYWKv5VHeMKz3ZIir/w42ugaOYTfEzebyo0q7kFL6emh5512ymSYeXJC9ic+NR9yqe2MjUWNDwuefb43wLj0pLZ1g9rRXalRPM6KyRgqIL/GMVpWnyIXNqlgtqHFoTpmCX+QNOxBtIW5LCw0DHkLA+xbRke3qlyxuM2OPMz/EkOAvmZ1LTwexAv6fpL9tH+8WiNQl4CmpbHiYtSItFl1TKq+lcP1QdAR7xGOwoAhngbiZ5de7VF0So+C0mQMqGD8H25/ogoi2ti4ZACAd5UjqOv+/QA1jDbU9ovb95hnMbQfsBMtyV/8shsyzIGHF/q3uQasA8eEkoTpHBbc3OfX481aE5Eiztx/EE+0nXeP5pR5ZQF1Bed09xDi+4z+O8PjEsW6NNHZ1BVsmL+BjysbrhREXHBUaWU2bOCKe99Fu4SXnqMAUnSetxeFuJ5wwlM/0vnNyJHP2pqHWzZnAj6Zn+2DFnHSWjUbWdqEIOYMSAKaxjhWKbWELhQQ2d4osT7QlhDci7ev86GCfy+oF3NMYpw//SHhUDHMbvDZ+ougrOOIt Lo+sielk rV3KZQV6ArkLMCAHK1cn7w1hvsOtpoJV4xzqQx4x9c+I3Z7pEsKQwqiFt30YaNm30Fpzt2FyApAVfgu3IUctpzhQ6Dk1JuvfSw/4/uTWBpaZ3H63n8qlZNzNfYsqSCcKUIqrv+wRgRbO9FNa8vux1Lchgor9PnoanqWX5LW0Xzg8mctpEYq2gHPGVpdxSLYoc1JMzkK7H5nvYLp9SyFM3Il5xlm3gKHUpRrLoorCTLx/nq1PD6ooXr1uXvbXYOtpv2vz+igqog/6QRgsnSe4zuxVHlO+cLb4blfDjoalfYicWFgj5K2N3mzEGMNLhjCtsEHB9awHsFK53tgvZ+gqauiHTh1X4IklEHIk68laIdwoF1GfP/Pk2iOf4xTERkTfZgJlMemHhxby1CTVjE340YbZSo3WKO2+Z4mKowZyZnLbT0PQOacJ9uKydhJkhuS091rlbCm7IEbFlSekvJBIw3WxR4gb6yqPzox9Y X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 15, 2023 at 05:08:37PM +0800, Baoquan He wrote: > Several architectures has done checking if slab if available in > ioremap_prot(). In fact it should be done in generic ioremap_prot() > since on any architecutre, slab allocator must be available before > get_vm_area_caller() and vunmap() are used. > > Add the checking into generic_ioremap_prot(). > > Suggested-by: Christophe Leroy > Signed-off-by: Baoquan He Reviewed-by: Mike Rapoport (IBM) > --- > mm/ioremap.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/mm/ioremap.c b/mm/ioremap.c > index 9f34a8f90b58..2fbe6b9bc50e 100644 > --- a/mm/ioremap.c > +++ b/mm/ioremap.c > @@ -18,6 +18,10 @@ void __iomem *generic_ioremap_prot(phys_addr_t phys_addr, size_t size, > phys_addr_t last_addr; > struct vm_struct *area; > > + /* An early platform driver might end up here */ > + if (!slab_is_available()) > + return NULL; > + > /* Disallow wrap-around or zero size */ > last_addr = phys_addr + size - 1; > if (!size || last_addr < phys_addr) > -- > 2.34.1 > > -- Sincerely yours, Mike.