From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 510FDC7EE26 for ; Tue, 16 May 2023 06:48:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C6DA2900003; Tue, 16 May 2023 02:48:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF5FC900002; Tue, 16 May 2023 02:48:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9656900003; Tue, 16 May 2023 02:48:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 937A6900002 for ; Tue, 16 May 2023 02:48:25 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6219E1C6CF0 for ; Tue, 16 May 2023 06:48:25 +0000 (UTC) X-FDA: 80795189370.08.6C06080 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id B2FDC40011 for ; Tue, 16 May 2023 06:48:22 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Pupmp9bN; spf=pass (imf17.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684219702; a=rsa-sha256; cv=none; b=rkyoqoVnJqWzFKwRpZVjTGWzkKFTOu5sadxWzo+AIh1/Xycj8ZvLqdWRthFQ+9RPWqUXN7 2qPrwWcrmto6YQjMxrr+56Z9Ce1W6fxvRJunWQGuVzVkVB1sTgF6ZegShkvKo2ZFFEFM2g RLwl2CXJltevU9m+Up9okuymfKZFRCY= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Pupmp9bN; spf=pass (imf17.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684219702; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b8IB1/vpurIHuYS7SsYK6zUnWftE8fSZ0kMzR0VBkJ8=; b=YdGDty75/TGIHbiP2rcj1ASefLYm5x09RPa2rxV58iv40E8+xMJ2mQ4/2zBIngUWSnjWZQ 6ysJTKkEfxTOtOjoui49OY3lqdrWW0DK9GlXJyGJuJAUMupLiynp5qaBEOwHtlSyErBPuo M7tIYE5RB5jVfRfgXXkryz5bDRmnfCc= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A622C6301C; Tue, 16 May 2023 06:48:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E8C4C433EF; Tue, 16 May 2023 06:48:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684219701; bh=R+bN+Jb2kJNplNYenuVF5QgSUK9IhdlaUvOPxPK/xz8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Pupmp9bN4mIe64U2fo9F8UefKptAy5mWp6F7MRU+/TiwNMhQ++TKFwcOXaw5QdM94 1bj8pkiTr0h1CWYOZwnQXpccEoR7RAosqv2vPzU6IUNP+h7e5qiL+ZDjrz2vAG7UzJ M3HFj+J7Eg/kV7Hu/Xlfhr4Ox54CrH8ydp6Ifd7BtrsFr791FbjKjBqEtOikLh9qaB SEq/1clH/ih6m7ixI+finZ1REBz1JevfVLcF190KsO6fiagiAaJfYwKDO6CmSjNIYg 51OAK+Dnci+faVsBi+J9Uc/LAPw1JKOib7qFQiIp4unwCIRov8FmdZIOU4BUw+AY1X C5lCE6g3CjXpQ== Date: Tue, 16 May 2023 09:48:13 +0300 From: Mike Rapoport To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de Subject: Re: [PATCH v5 RESEND 05/17] mm: ioremap: allow ARCH to have its own ioremap method definition Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-6-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230515090848.833045-6-bhe@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B2FDC40011 X-Stat-Signature: qqdiy59wfyq1q91k5wycga8r5yxtiwfz X-HE-Tag: 1684219702-38479 X-HE-Meta: U2FsdGVkX18zkh6GE7pS3Va4/MMp52dhjRNkHhNTvJG5xHH9M88bhtphroU4boQBqgA1JaLikGDWiruLvsL1RtZeHQ3vyBKiEejLjxGum88ZUGP1nZS3bUtbJxIbCNGglUKzmp9DvHS6zXt9N0OUz2Nr7+azr85+17dn//wGC7lfzOjRM6I01XjXXLswLCX9t8sVEArS20f6eiSxeodiuMauArOQivtfRL8XsTuvLekM3LhldCi6Ffqhvurf9MTxX5Svp3yMUEBGXSW83HZPlQay9DA0sBnzzXWy0zVAspnEf+KranbnS6w0QzAXIZizBj3syzFOJziN+kCyQKWFrPWZLvR02YFoUgXMKd71FTXUfs7R9QxSIoV0X4p6BLf10vZb4NthCz2CZk4F5skUwuuN2DZC54uHsFV0U7dy+ptgTTePtnViqBmn+Vuv36YygfgcFg2/BisUAmx96mXgRBNO2cmmfBjsG46KdMu7rVoRQgUyFVD1DxfEK0X03iVcMAw61rp0GgHU4o+KAlX4x6Ecgxts96ma44cH/fZYBf9u91usS6XwTBvYiLPZHsPAYNaQNtL6gwuHSswLPcvmYa43M9vjbqSDCTbxtZva/nb6b82b6JORbXx+BsiHw8ST2iHo+/s5I/BHBoTvzz4nDkOmEYvwE84w5mLXpB5cXakbSPA6/N0PLv8itDg2pihdXK5mc1PliKtz7U5aB15DrAiw7zQ6fUS1qBp52+np3QU1UFlSWiikm/Gs3wcIA5CAydNQ6oKf0b1fduyZGS+RN9brP3jX051d+/QyJ9wutr4/+zpbt4uDhddos7wagXY019OK410vdwRFiLMlhLrcztmwAO8klJjM2mYC3eBnY5t+C5DSevbBqjrf+dnl2n9Z8dJATyS13YTZC/YE7aOIpHRPL9efmirS9IJrchw6AEPPCF0VErOPHdyVqYLXu29whqC4LBhyDdJs7L60d5X WMG6ZDwL dK2NMRsS9ygniQew+8XKjAjrpXu9puaGTIjfLRpBKMgPHtgGcNr3ctzzCWUif/oulv7kh61/c+wYPdGwd9SusNR9kd/77G61kAAzpbzmfwxUEsJXDINM4ofoCLp4JzYKRpBfVTXglrC240cvLbVNBzOoM4om11sM6A1QncuhQ6QQ9ctDgNzIpjbrBAgmBELFpwStRbcD863zNCcAhUo5ZkA71dD6BQsIfkonN8T7vQCCHsRNQCDxZOI88f4QBejg3g5hfBEWJmm/lqtF/4XuKjEAO+QjGDgPQL+ZX42iLuBDesFT74K5OwE0hqta6lw2TKLqCeTorF5ZyG2P5L6W3PFotnJUYvtU1nUJ1lII9410XFa5ouLXyaa6zIa0q26Iq43UCXvFaIofDcNk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 15, 2023 at 05:08:36PM +0800, Baoquan He wrote: > Architectures can be converted to GENERIC_IOREMAP, to take standard > ioremap_xxx() and iounmap() way. But some ARCH-es could have specific > handling for ioremap_prot(), ioremap() and iounmap(), than standard > methods. > > In oder to convert these ARCH-es to take GENERIC_IOREMAP method, allow > these architecutres to have their own ioremap_prot(), ioremap() and > iounmap() definitions. > > Signed-off-by: Baoquan He > Acked-by: Arnd Bergmann > Cc: linux-arch@vger.kernel.org > Cc: Kefeng Wang Reviewed-by: Mike Rapoport (IBM) > --- > include/asm-generic/io.h | 3 +++ > mm/ioremap.c | 4 ++++ > 2 files changed, 7 insertions(+) > > diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h > index a7ca2099ba19..39244c3ee797 100644 > --- a/include/asm-generic/io.h > +++ b/include/asm-generic/io.h > @@ -1081,11 +1081,14 @@ void __iomem *ioremap_prot(phys_addr_t phys_addr, size_t size, > void iounmap(volatile void __iomem *addr); > void generic_iounmap(volatile void __iomem *addr); > > +#ifndef ioremap > +#define ioremap ioremap > static inline void __iomem *ioremap(phys_addr_t addr, size_t size) > { > /* _PAGE_IOREMAP needs to be supplied by the architecture */ > return ioremap_prot(addr, size, _PAGE_IOREMAP); > } > +#endif > #endif /* !CONFIG_MMU || CONFIG_GENERIC_IOREMAP */ > > #ifndef ioremap_wc > diff --git a/mm/ioremap.c b/mm/ioremap.c > index db6234b9db59..9f34a8f90b58 100644 > --- a/mm/ioremap.c > +++ b/mm/ioremap.c > @@ -46,12 +46,14 @@ void __iomem *generic_ioremap_prot(phys_addr_t phys_addr, size_t size, > return (void __iomem *)(vaddr + offset); > } > > +#ifndef ioremap_prot > void __iomem *ioremap_prot(phys_addr_t phys_addr, size_t size, > unsigned long prot) > { > return generic_ioremap_prot(phys_addr, size, __pgprot(prot)); > } > EXPORT_SYMBOL(ioremap_prot); > +#endif > > void generic_iounmap(volatile void __iomem *addr) > { > @@ -64,8 +66,10 @@ void generic_iounmap(volatile void __iomem *addr) > vunmap(vaddr); > } > > +#ifndef iounmap > void iounmap(volatile void __iomem *addr) > { > generic_iounmap(addr); > } > EXPORT_SYMBOL(iounmap); > +#endif > -- > 2.34.1 > > -- Sincerely yours, Mike.