From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E40AC77B7F for ; Tue, 16 May 2023 06:17:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6ABEB900003; Tue, 16 May 2023 02:17:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 65C94900002; Tue, 16 May 2023 02:17:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 54BF4900003; Tue, 16 May 2023 02:17:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 48912900002 for ; Tue, 16 May 2023 02:17:20 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0FDC3414AF for ; Tue, 16 May 2023 06:17:20 +0000 (UTC) X-FDA: 80795111040.13.FDB76EB Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id 3B059140012 for ; Tue, 16 May 2023 06:17:16 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SPOLd+7J; spf=pass (imf26.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684217837; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sS2yOQphVp2j5TaHMbaVZHyURrDzXPo48ZPW3RrT1IM=; b=ljmXONWBQ8CJ487SpL5MgSnyp7agICoN5uPC+J7DKwf6otPIsNmjY7VdirGgmPp+g1yhjO /QaKxvdmLPJoK7W5hD1E2kvgD8UeCHkXO42//4UtLwylFirwwCQWnNbfrdUfwl0bpOMnNU NVfw9i+nylC2ENEXWEt2pi/YPTln1rs= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SPOLd+7J; spf=pass (imf26.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684217837; a=rsa-sha256; cv=none; b=Q816ib34G+jjNro93ZzqDV0em71T7vrzZQJ6GBk6y/R09PCkjj7cDn+/buxjH2WomPlCs4 PlgJJY/FRI/AX0fNdAtuGhv5qpb159eUfe5fLmdAkpI1dQQ5vbPuGMyanTLq8m9PcZjc89 aP1F26L9qPe+rEcBR45l/87A55b5BVw= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 41F3F62938; Tue, 16 May 2023 06:17:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FC75C433EF; Tue, 16 May 2023 06:17:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684217835; bh=SISxQIMZ3aoEYbelSxp6Io1CmQNeweA4g5bNKPjqm+k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SPOLd+7JnyEKaOU2K5LUQsQK9/j1vK2WGpOTiprmvaHqBigWT6CkiFXXCFGLytJW4 JSk0BOEsog8klByEqKSH5UJp/Y5o3CMA17F1bAvUhBuqqcPH5gYlH99VMeD/1brMZ3 A9U0/uABWxZ7OsssRO/+xmmH4dvOPhgNadCSIMNNseqdtU2ICEk6SRQIkwXnYaFAdd IjPenDLCQ+G7fkuke89adIQGnzZxAADssTWFXuNMnxmjJq6rqGZ0a8VAQL15wIvT2o VCp/Se9uwez0vlJSC80RaxdmMXtl1Y4Y9XaNRFmKwXNnleaFCqOOrI5K535fWf/Hao +T9X1f6prM2sg== Date: Tue, 16 May 2023 09:17:07 +0300 From: Mike Rapoport To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de, Brian Cain , linux-hexagon@vger.kernel.org Subject: Re: [PATCH v5 RESEND 02/17] hexagon: mm: Convert to GENERIC_IOREMAP Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-3-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230515090848.833045-3-bhe@redhat.com> X-Stat-Signature: gf53zdq5jk33tqnhyfzkmirou57nznni X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 3B059140012 X-Rspam-User: X-HE-Tag: 1684217836-610820 X-HE-Meta: U2FsdGVkX19YnzEy+Kv3zP6RThdh2TkkWalzyDmXOEwzglcC+ty2F1eTV41s79ufWlTzA5gr9hNDsECSBEPhvh8j30XU/buG4BLO90UWZy5ovVkHfWGPZSHCwdpjgm0ctQ3m5qmJGi4zQIED/kK8My7rwZmS0UJJZS1CBx7EPNk+NdSH2UBofaC+V1xtsHfE0YIHBpubqbnXRhPVZEzDcfoTVJYVmhA92EkLyFxBPShXwLmjteIryA6WRAxqyz7rVGwPATJV6izou+x4YV5xV5uhPiOtoHDtceRrJ841uAKjGy+L1i1Z5A6qf/qNZKQDJSE7oyE0I40vruFkTAcJu5GkRjqacVc+Nd3iyqobaiigSo7Zu2Ujex3clL4IbAE9FWeel9YFLR9ZXh1/kyL3YzqZHLvmv9b8qgus7NBA/kwLOACJtOFNGERKuC76QvTr4RRkLx8jYqErzPZqg1QM2rtpqJOsJRoI8+AxQC4/toBC4KzQsQpZ06fUh6M7UFs7idKd8CwK9oTScFkkMibWPASopVS47aCgTixmRX1aOEQFCujf11nT0bdOU08jalsl6zjFzJmzl5q/w45uYWvaehcPiJqx1VEQeSQXzG9Xwn/IvhxNiObAOAhfZtnJy4Axp7q692PZwvnB0QjEpKgzgYzTtCYzJ97mV2EAebl7R4rQ9la4zkVTP5wHD6r5YJ38GV98Ar3m1enQiKfZBoKwhqbnlJ0GpbcJ7qEA1D+x+5Af7Ii5qupx/UklW4wdUEEv8LdapdUYy6g7z6Nw7QfmYKwHdtLJfS1gtb6CpBxFmS7LCKw3r0rGGGVHQnb85DSuiQUWwY22BvoD0T3iak6j8FfYwjP43n2JdFe+aHa3oyRSlHfZRbw8U1+KuAOEH3C7NAMyTtGvkKrN/3dIUTRWD4QQGbfWrc8+VWN7WpuXIxS8AaHYch2Hygl7DXNofvi1nmVDRuQ54rA4YnptK8F Vova0ojY ZN+NH4KwXZV7C75SG3kN+pikQ6oFCxmRkI6wHTfDD620UrcBTKRkWQDm45izhahpadVZ3HbZe6F9m70tPnUC3bYi9E/iaFA7H99mPLxtfCI6ExT5vB9/AELZxGXC1H2NPxwZ27Yc4pqxKYCFG24LIulitvvkJzFk1JTyGhashZj/1+4llDgV1WUacha5DvWc84/Palm95v5bK1oIyUedCKQdAdjizIzeKIAmDyHoDH3p/IDMp2jIEW9MjeHkWoyUgvgrrSI8eu10ECrh85F88Qswy95xyu2Y8847by7OAUJA2Jn6eEGKaWVCHbY8P57qCH0Sztl7OMYjVEJC+NNZ7EGceu3Hp/2mgKiqfNE8NdyFcEPozq4Lw5udOmT2l8aW2ISVSKK4YdPHm2C0lWdWo6Ve6jJS4LVzAs8acpsBxvbW40aB4KgZXwaDynlbI3LmrNq+4zZx2tU3sAZE7htaHlFyAGo+lWqHufQfE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 15, 2023 at 05:08:33PM +0800, Baoquan He wrote: > By taking GENERIC_IOREMAP method, the generic ioremap_prot() and > iounmap() are visible and available to arch. This change will > simplify implementation by removing duplicated codes with generic > ioremap_prot() and iounmap(), and has the equivalent functioality. > > For hexagon, the current ioremap() and iounmap() are the same as > generic version. After taking GENERIC_IOREMAP way, the old ioremap() > and iounmap() can be completely removed. > > Signed-off-by: Baoquan He > Cc: Brian Cain > Cc: linux-hexagon@vger.kernel.org Reviewed-by: Mike Rapoport (IBM) > --- > arch/hexagon/Kconfig | 1 + > arch/hexagon/include/asm/io.h | 9 +++++-- > arch/hexagon/mm/ioremap.c | 44 ----------------------------------- > 3 files changed, 8 insertions(+), 46 deletions(-) > delete mode 100644 arch/hexagon/mm/ioremap.c > > diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig > index 54eadf265178..17afffde1a7f 100644 > --- a/arch/hexagon/Kconfig > +++ b/arch/hexagon/Kconfig > @@ -25,6 +25,7 @@ config HEXAGON > select NEED_SG_DMA_LENGTH > select NO_IOPORT_MAP > select GENERIC_IOMAP > + select GENERIC_IOREMAP > select GENERIC_SMP_IDLE_THREAD > select STACKTRACE_SUPPORT > select GENERIC_CLOCKEVENTS_BROADCAST > diff --git a/arch/hexagon/include/asm/io.h b/arch/hexagon/include/asm/io.h > index 46a099de85b7..dcd9cbbf5934 100644 > --- a/arch/hexagon/include/asm/io.h > +++ b/arch/hexagon/include/asm/io.h > @@ -170,8 +170,13 @@ static inline void writel(u32 data, volatile void __iomem *addr) > #define writew_relaxed __raw_writew > #define writel_relaxed __raw_writel > > -void __iomem *ioremap(unsigned long phys_addr, unsigned long size); > -#define ioremap_uc(X, Y) ioremap((X), (Y)) > +/* > + * I/O memory mapping functions. > + */ > +#define _PAGE_IOREMAP (_PAGE_PRESENT | _PAGE_READ | _PAGE_WRITE | \ > + (__HEXAGON_C_DEV << 6)) > + > +#define ioremap_uc(addr, size) ioremap((addr), (size)) > > > #define __raw_writel writel > diff --git a/arch/hexagon/mm/ioremap.c b/arch/hexagon/mm/ioremap.c > deleted file mode 100644 > index 255c5b1ee1a7..000000000000 > --- a/arch/hexagon/mm/ioremap.c > +++ /dev/null > @@ -1,44 +0,0 @@ > -// SPDX-License-Identifier: GPL-2.0-only > -/* > - * I/O remap functions for Hexagon > - * > - * Copyright (c) 2010-2011, The Linux Foundation. All rights reserved. > - */ > - > -#include > -#include > -#include > - > -void __iomem *ioremap(unsigned long phys_addr, unsigned long size) > -{ > - unsigned long last_addr, addr; > - unsigned long offset = phys_addr & ~PAGE_MASK; > - struct vm_struct *area; > - > - pgprot_t prot = __pgprot(_PAGE_PRESENT|_PAGE_READ|_PAGE_WRITE > - |(__HEXAGON_C_DEV << 6)); > - > - last_addr = phys_addr + size - 1; > - > - /* Wrapping not allowed */ > - if (!size || (last_addr < phys_addr)) > - return NULL; > - > - /* Rounds up to next page size, including whole-page offset */ > - size = PAGE_ALIGN(offset + size); > - > - area = get_vm_area(size, VM_IOREMAP); > - addr = (unsigned long)area->addr; > - > - if (ioremap_page_range(addr, addr+size, phys_addr, prot)) { > - vunmap((void *)addr); > - return NULL; > - } > - > - return (void __iomem *) (offset + addr); > -} > - > -void iounmap(const volatile void __iomem *addr) > -{ > - vunmap((void *) ((unsigned long) addr & PAGE_MASK)); > -} > -- > 2.34.1 > > -- Sincerely yours, Mike.