From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51259C77B7F for ; Tue, 16 May 2023 06:17:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E9ACD280002; Tue, 16 May 2023 02:17:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E4AF1900002; Tue, 16 May 2023 02:17:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3B78280002; Tue, 16 May 2023 02:17:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C4A90900002 for ; Tue, 16 May 2023 02:17:40 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A99FB81431 for ; Tue, 16 May 2023 06:17:40 +0000 (UTC) X-FDA: 80795111880.18.7EBAF5E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 044FA140006 for ; Tue, 16 May 2023 06:17:37 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QjjFtngU; spf=pass (imf09.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684217858; a=rsa-sha256; cv=none; b=CmWBq/zN/x1eytbPSQdgDYDG09BSqi7lI8lcqEbe2eQcp+2CIYKBkTWsV7vPt/73ejWD8x ApJ4aPp2nxUUtr1Vs2MDdGRDidDmfAR1txOAnJBx5ti7iAXgQnFQ2JDIHRP/mnZ9AwKUaA qXfn1VII+/3jypHo8927dEAMp0JVINY= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QjjFtngU; spf=pass (imf09.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684217858; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b+M7SjY3Cp4tysYJSDWyO2n7HSvBl33aqS6dP89bkEE=; b=s3fb1fXCUb60u8/TwImP0lyo+hDQ9544isPZzNTqQdBpgHa40+M38JnihJqvlu5h8Vi7Mf ylgL+eQhzADXW0bUlfejT52HWJkhOOuqMEfvMtKWcYBIFtxdqIX6qOaSuq/JkpLHUE9BIc t3VmcHp56S1oV8U++Vx1LoZJD33swx8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2D9DE634E3; Tue, 16 May 2023 06:17:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4DB20C433EF; Tue, 16 May 2023 06:17:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684217856; bh=ht2toMa7sB2FoOI2dtiANjaURujeEantEFIqRkx7p7c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QjjFtngU/0ixMZ52uwdKMxFrkJKzGP+tm/9qrh/Q6dVb9GZRcefaaUGzwnBtR4U/Z DWcLX/QxVM1TgVjctlB6nDURbN/lLQZij1s9K3r8NakQxfbG2RZM6ij7BLM3iPTzeJ MgFCaYx1yU6mIT2lZZjoNYkqMBuzamBxAskeAdSI6jLBJH1YZMVoT68rFUMBj9IF7L Fz8e+Z5YIETnNUeFiVLksbZwKCjm31YFmfhEldQcpAZDQ/3DtOKd9iq29VwdbmS5hn gfy6E6RjhZIj0nePsJUXxa/DUtqZ28kcv0LuCgkD6dJ8GNk8fqlHiNkOYXAdc91zyW P3j/+q4UyFPmA== Date: Tue, 16 May 2023 09:17:28 +0300 From: Mike Rapoport To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de, Jonas Bonn , Stefan Kristiansson , openrisc@lists.librecores.org Subject: Re: [PATCH v5 RESEND 03/17] openrisc: mm: remove unneeded early ioremap code Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-4-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230515090848.833045-4-bhe@redhat.com> X-Rspam-User: X-Stat-Signature: xyuck9zmi3fqh6gx14xdigt5ahi8nbs8 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 044FA140006 X-HE-Tag: 1684217857-544589 X-HE-Meta: U2FsdGVkX1+5TRyIRI9qXZrcISykFg16NUxuuopW2CiclnNcHyNet+kmuqLItDoopQipCw+IInqBwk58g2/dJCvlcAZYVRAhIyfReypR2arQlvuwwIJcnaklaGy+N6umiQQurm+IsiHUo5i7YhmnzdRyDnccySxNsAzQ+L6jaeF6YbiKAPUMP3VFUcypf4EcILR0a0t97vajvJfyMDy+yaWwwYKCaiquUYs5yMMVXzfDaQaqmbO2OJFTDn+10lCbuz3oYiKcun0or0RaenUTlHcphD/bvmvQ/F96/k2/HjLVMYrrRZg1qrMGsISr1rLQ7Qwr1qcav+5KJX+gkeSgmGGYLhc8Id6cCP53U8SiKq9vGD+E7eu0TrSzbMA0OtpQY1uVWG0AMRBjgB+yPMx6l7G0J6DC345NseU+dfkr+brnYzZYgKD3Fv+F3EhQM/UmDdTg4OFYejj/b1FKA/VnUDFzGISrsu7HObnCM5cylkF/OQZi7AzWjv0p0DKwdDCggqj2EgWXulQ1JaNL8icQjl2auA1L9+4lyvDeigS0iMHbh4Qb+9FMW7nNEYKm/31YUHkefvd6AoE3ifzy+ugAWm9cJA3l86fsrWBhYQ2ZY3SyQrgeJI3tKU+PmwDZmwn8x+r1UAwvX5/+kbOeYhyz0zIbyOfua2pErrDopIXD4J14nG5wEOFWjaTtATZ+H6CSPQVsgHLQke/hkxKFoK20w12PsalQTstH3F3+hpnS1sg08OBd+tE2zttWDF8JJWpr7AS8Pdhoi72EyeI7RUEuUhB+UgE0U65ZXWnAULuMkdIvXhYcg+C8sxecQBS/jWw6xRocldEsTlOyfuWvxpb2pM9rSZbAURXn5qGdMzxdtvLKLjb6xVked5ivf2A035QnbiIYRQ3pd4dAJ6Pr4EWhlGznKtBGKJMqqo3oslKk/ZE9XFzgvRX1OZjf/5aNJbXNd/QmwSYgewvaz1d0rtc CsubrUyD SnPDItBiXtRcdUagBhQRRaCAs6f5i+SEEvSSX1oaBcvdrpAw6XwXjElCTqW/W3Q7Ym0X5rL79hJ8owrVFT6d2yB7iGsG2Fz3nggQlHyhp6DIsuL7td4PzjOCRLt6j1zyGu/+eGsCUn2/68Wc4Pivce+dMyYCN248J+pdLV+90zImS+x3xGajzC84UosE3X1C6+jtkWYYBShF2HRrqmbl4r3WGXU9/s88V3AbJ8YCbHt/uGGzdNI/EYe2z/kpS1GkFEKUMYFZNnL40uV9foGdW14D72+QPfONhRNLm1OpMovgPAHWlJWKxvjwhgzmXD+XYPMsfu1bWRFU2hTcZ5hAIM+MzUtkOROodFucjdtbTTQLO7owWR7aVLObnYudEnXcGtLbi4nb+PWcGzu+EAMkts0JoNPzGXEh9HHFkHDro9U+9c1Ey88PeEBzm14FszWzbqlQdrykho+vh0b0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 15, 2023 at 05:08:34PM +0800, Baoquan He wrote: > Under arch/openrisc, there isn't any place where ioremap() is called. > It means that there isn't early ioremap handling needed in openrisc, > So the early ioremap handling code in ioremap() of > arch/openrisc/mm/ioremap.c is unnecessary and can be removed. It looks like early ioremap was the only user of fixmap on openrisc, so it can be removed as well. > Link: https://lore.kernel.org/linux-mm/YwxfxKrTUtAuejKQ@oscomms1/ > Signed-off-by: Baoquan He > Acked-by: Stafford Horne > Cc: Jonas Bonn > Cc: Stefan Kristiansson > Cc: Stafford Horne > Cc: openrisc@lists.librecores.org > --- > arch/openrisc/mm/ioremap.c | 22 +++++----------------- > 1 file changed, 5 insertions(+), 17 deletions(-) > > diff --git a/arch/openrisc/mm/ioremap.c b/arch/openrisc/mm/ioremap.c > index 8ec0dafecf25..90b59bc53c8c 100644 > --- a/arch/openrisc/mm/ioremap.c > +++ b/arch/openrisc/mm/ioremap.c > @@ -22,8 +22,6 @@ > > extern int mem_init_done; > > -static unsigned int fixmaps_used __initdata; > - > /* > * Remap an arbitrary physical address space into the kernel virtual > * address space. Needed when the kernel wants to access high addresses > @@ -52,24 +50,14 @@ void __iomem *__ref ioremap(phys_addr_t addr, unsigned long size) > p = addr & PAGE_MASK; > size = PAGE_ALIGN(last_addr + 1) - p; > > - if (likely(mem_init_done)) { > - area = get_vm_area(size, VM_IOREMAP); > - if (!area) > - return NULL; > - v = (unsigned long)area->addr; > - } else { > - if ((fixmaps_used + (size >> PAGE_SHIFT)) > FIX_N_IOREMAPS) > - return NULL; > - v = fix_to_virt(FIX_IOREMAP_BEGIN + fixmaps_used); > - fixmaps_used += (size >> PAGE_SHIFT); > - } > + area = get_vm_area(size, VM_IOREMAP); > + if (!area) > + return NULL; > + v = (unsigned long)area->addr; > > if (ioremap_page_range(v, v + size, p, > __pgprot(pgprot_val(PAGE_KERNEL) | _PAGE_CI))) { > - if (likely(mem_init_done)) > - vfree(area->addr); > - else > - fixmaps_used -= (size >> PAGE_SHIFT); > + vfree(area->addr); > return NULL; > } > > -- > 2.34.1 > > -- Sincerely yours, Mike.