From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22359C77B7D for ; Mon, 15 May 2023 17:28:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 952A7900003; Mon, 15 May 2023 13:28:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9031C900002; Mon, 15 May 2023 13:28:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F210900003; Mon, 15 May 2023 13:28:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 73BD0900002 for ; Mon, 15 May 2023 13:28:01 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EC2FEAF243 for ; Mon, 15 May 2023 17:28:00 +0000 (UTC) X-FDA: 80793172320.30.E69DBB6 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id B177CC000E for ; Mon, 15 May 2023 17:27:58 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YAFxSR24; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684171679; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OdG7f6znMQkKbie7LhqyJT2EpCYQ4RcchTRRUpChjcY=; b=U4e6cJQrsIEKNkAQVzHc3vhSN7psApJjTmt8CMaaYf9Di0Ysqqzj+w4mSK/TyyhGcv5ppv SVCyRae5tgUsyfuTxvyirD9Qw1Vdvdp3CSkLjomWDuvPxwGKZl+kdwgyeiyi9ZA2oL4ulX EeXZ5duUygX7lZ5s/UOPwdvJvv8E0Lw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684171679; a=rsa-sha256; cv=none; b=whmZ/O3c11flPcqId7OoKa7rM7tBhpXIg6CmEqGihjicYSdmNKRz90gycm5ALIcqhBuXzL Cl4SbORUZtnzcDEGfMKWXFX/K/v5fvmqK8P62KIDA6U0KSLMo5VK8ifyuaaZS69NGSy5cE cQpuYE7lKc1/NSP+itv+Q5PvBhhZylM= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YAFxSR24; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OdG7f6znMQkKbie7LhqyJT2EpCYQ4RcchTRRUpChjcY=; b=YAFxSR24Z/WdxaDJBseB7qP0Bb qcUNWWbQUOVv7aEyq8FMZr4C246H8u+9gTBNkEuCV4hhkYIOCWl2SChHhyLRKYBEfFoXEdMD8PDE2 PFcRSrWCKMDSvit2N1KwzmSIBXpbU7OEFsfPc8IbHmH0qME1dkYahPH90jZTQ0ygaBTvf7GdbVLun QMUvhGjLrfi1uAcVFFr+AYlEU4YWMeeoiRqZaymPSzCaUKLlhHAcaxhn9NWpjl4dPFd3JySgJUH5P SzTiW+m0GmzO0WPEYOSZywrdmMnexRhw88ivu3pU+OGEAc0Vf3C7dmeK4B3cBAvBSrjMShO6xjANT e/B1e4ig==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pybz7-003cMU-Qh; Mon, 15 May 2023 17:27:45 +0000 Date: Mon, 15 May 2023 18:27:45 +0100 From: Matthew Wilcox To: Peng Zhang Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org Subject: Re: [PATCH 02/10] maple_tree: Drop mtree_alloc_{range,rrange}() and related functions. Message-ID: References: <20230515131757.60035-1-zhangpeng.00@bytedance.com> <20230515131757.60035-3-zhangpeng.00@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230515131757.60035-3-zhangpeng.00@bytedance.com> X-Rspamd-Queue-Id: B177CC000E X-Stat-Signature: jhcan8w4iusfes3fmmfap193fp9e83ss X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1684171678-843695 X-HE-Meta: U2FsdGVkX18D+IdwxiS+LPtvrmg3z0cwOkVh22fFGI8Vne46lEi5jUaNH9HFE1Wrv8WqtHTly4i/+yb0z3XFtd4IeEjEitCrkcqJl1zrm7s+DF8+vgB4QUPeMdb++QXWPQ0J7RnJP/ph9XKyVFhAhpasgWbLP7lG+q1DiF/eUA47iX/ZC32Vfx9CStA4gjdOGWZ2MotYWqI8b+r9pmfhcmRWkXTHnAlKKClRwMknVwJlb9xU4d7kO7cNf3F3sozDUBbHg+b4y85hCYTnWr9lam9Ib/NUcEIHOMdtZOZp8JnTgk7hmgWVkOk/AA7epgWyzrWVyGYe7Ya58KVxeIamKeI7J14XIcM1R6P/4bJrR4j/XQnPfRuGlgan29OOiae+DX46q/1jOBN7o1TUT1U0SuAYv3EhLlILABuDM5WlMV4NGy4nPgTLsEPe0kG0vehlHxCW9np/ifF2B0c/LG1NLFVy78ixwyUm9CaTSyibHEbNZyxNBb9qOpeAlJy6HtEfCEjbIpAze/+SzGo/DM/HQa2vr0BL5XSa3XyhStwzWPALwlKU9HIeoxW+mCoPZLqYmScArwL3kHGYU7u2jv9ySIJY63uVcsqRs7UMrKcjyfsvIQN/7zm65xtFcG+ct8UFugOHCcAfmkTPlvt+9ggxwmjb6MHWN5ZZx8R4zvELt75ACGUXiRONCIC5LZI+Kk+ncXE9NRJPo8Pm4jySnBXIqFefEKlfJnQzTE4vyr7t/IUiGM8l4AJlbCgeM4bZAI3vUmVwg/YUGw4stmCAXRn5Gn/4XmU3Aqgd3x/zqqac9gYO3FAPPXY5HIh4GkXe0dO6o51QCgbkrePurejJk0+EWnHUgPhe8GoCvSQ8HidAdxPE8ZMJgJoWZis6m60o+B/JnGVHDPcknUNvNNRQ6NCH5bqaAyCKPfMsjEJUbEKOKjg6UsS/ywaovmTrph81+iEj8MXPallZFjVgj9wq+Fj AUVyUn5A TGFZkM/dhY+451Z0Q8GasPU4GB0gcjU87cgYD51VfmDV2hrkjHqaHEQqu4aiRQEEkA8Ibd2x8AQpoPt8cDWHA3wHMWo8P6SEa6ghIjWpHJEbVvE33WsysRoJoKXcYaW+EQF67JEpZYETAwv10AaX9evM3XdxXi7Pxv+Zu2MhMEH8SfqF/DnC/SNXt0A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 15, 2023 at 09:17:49PM +0800, Peng Zhang wrote: > Drop mtree_alloc_{range,rrange}(), mas_{rev_}alloc() and mas_fill_gap(). > mtree_alloc_{range,rrange}() currently have no users and can be easily > implemented with mas_empty_area{_rev}(). mas_{rev_}alloc() and > mas_fill_gap() are just their internal functions, drop them together. No, I think this is the wrong way to go. Most users should not be using the mas_* API. These are the advanced APIs. Most users will want to use mtree_alloc_range(). Just like most users of the XArray use the xa_insert() API rather than open-coding the xa_state and calling the xas_* APIs. Please read Documentation/core-api/xarray.rst and maple_tree.rst for more details on Normal vs Advanced API. The real problem is that we have so few users today, so you haven't seen that most people don't want to use the advanced APIs.