From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1F1BC7EE23 for ; Mon, 15 May 2023 14:55:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F89E900004; Mon, 15 May 2023 10:55:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 48018900002; Mon, 15 May 2023 10:55:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 320CE900004; Mon, 15 May 2023 10:55:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1D9E3900002 for ; Mon, 15 May 2023 10:55:50 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7FAC48133D for ; Mon, 15 May 2023 14:55:49 +0000 (UTC) X-FDA: 80792788818.26.C27C412 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf25.hostedemail.com (Postfix) with ESMTP id D05D7A000F for ; Mon, 15 May 2023 14:55:44 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=TvLK7Qrp; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684162547; a=rsa-sha256; cv=none; b=jGB4mkQvaQiubLjpaw0Q3+XboaMBg6bXTWbtd+OuvlY9R0nO1I4lcs4NUPAAcMH3xIaOrv GCsMSO8O/q16HbPbuc8mfNuhLPSG965c18Br+QPwO7v3MXjd+jDOIFLRQAisQeDbbVEalb 0RrmHBfh4nXkdd/6NjJ13a52bm3bY2k= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=TvLK7Qrp; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684162547; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=20UohLkV19ucCZXCTqMhEaDtKzRxSTgptOxs6SuddJ8=; b=OnuISgsEury9P3NKp29la2N/1UcWCZ/iRwuVhMMlvhveUMo/slFLcRen5/IXi3A9GgCb7B aDEVYuOcU1LaKOMiabg8kqx/jY95Jbq8DPUQ64AJQ98YYPqCREQO6lhmTZVB2LMXtmQXLe 1gDDq9PMzOv4Qzlwi2S/asZhcGLj1Po= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=20UohLkV19ucCZXCTqMhEaDtKzRxSTgptOxs6SuddJ8=; b=TvLK7QrpUgrOAuYtKntrSUzJab hmfGsJRcMg6YslBLl0Pb/5bx9O05DwIvYN6v57mbtxZ5Xep0HHcNztWnc0TQ/CrsDUqtNPsP/khIB yeP0bQMDXEDY8aEC3K4mJcmjPlwsEx9vyABrU26IWNlq3tc5k8Fg9jHMNoJBBPSBLCN1NCaEp5QB3 FlhlGWk6ecx3gjzF4ss8u48ws6xK8xTK3kyzUSWvRBXgp/sm1b5OtCVWJDV8WAjA2LU95fE7RXpKV 9PlTVxK9fkmrVglqco1T9LVQwHhfi3I4NHfGwxrterlUeNaVPy5YROGEyJuUCwrYuSCyXPffgB6MF /2d70qiw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pyZbi-003XVz-QE; Mon, 15 May 2023 14:55:26 +0000 Date: Mon, 15 May 2023 15:55:26 +0100 From: Matthew Wilcox To: Peng Zhang Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org Subject: Re: [PATCH 03/10] maple_tree: Remove __must_hold() which does not work Message-ID: References: <20230515131757.60035-1-zhangpeng.00@bytedance.com> <20230515131757.60035-4-zhangpeng.00@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230515131757.60035-4-zhangpeng.00@bytedance.com> X-Rspam-User: X-Stat-Signature: xuwnh87xmxs1e8wkxhgfq4x7ospoc8qz X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D05D7A000F X-HE-Tag: 1684162544-898833 X-HE-Meta: U2FsdGVkX18SyOd7+WUejlv57iS/v9hd5NZtwnOf3U3AB0GSYro4DCA6SNSuvos7bdnD0/MaF/GI4exaoW5SxobWdx0qsBmBkNl3440vZtNXTPvBAVoTYjN0Jtcbc6pugqS3t3mYT5ae5GnLroaGieqnBoAQ8VftdIadNpf9jj7LiH1L9lLaSphPTaGyqEN9i4hvDCLg+QAGlZoeX1ns/6x7GACYJJwFEmk/U01d939+yOrlOf62KfWkBBdndTlkYWT1WbNEwCi76YR/tV0uypHHZkLtAya9NNxgeccvvSavzCfk5lrZ/W/F/ybpBLBTM3EmoI2MOvtbH8ceXtBTw9063LfLDYY5NaRR7HDQWlEfUDcrZj18Eey/Ngpi/n3bcJ6z7cfg9xYgvZqVJFXscQ1BThGFQ23bjUREsLk6tw0awH0PfSbg+a05kaNjSYpH7MOh1hGwS7IkpzrJ/d/E0/NQZPXl+nefCI6As8eSpOugfYEmmMHopCjfTdHNhxNPuEwvdT5zazkSPbVzr26RZ+Mva7AZMtKLQ+vBIDcatnOcmqgfaxGl4tLxlWQ8/rI2m540ZkjXDF/hIi1ynW8wC2TlJ/xvQieqXQaiWUcN4rH4c8Bh+E0BnohqdZg2Iggn7Ar088o/dezYruFPl4zk5tVJ3CBaS/7pr+lLzCV65Ucsv6KimL987vSL6rvBZW3fUUgmTKp4gyeHbuMghFEIQiLGINYIK/Ao56VkDjGZT4IaGNAbtY3BSzd7ji6cNGYJRw6LthbmWBDMStPS8H2iOgINFyDANhejQ9E9hmdWoOk7CkJ4XIBa7kUow8GbU0I9HskIeuBLyXx1AZYuzPKc6zBRMFxLcviM6/jsl+g1PGAbppA2JVN6P+Bx3J1I0g7PP74vRIYiSHq/J+MWHM7TxIxb7/HIaXiFbclhgr9ubFIafdwJVLdyaSSx7TIuh2Rp9hh2XLpfWyrjO3RxXyc YhkJbYDn KBwJtzitUF68TTqJuX4pXce3qBy1kNQZsJFviJc0EOgm4abGrR44e4nARaGxtpB6mCOtNpY5JJkN4KrP6p4KBRkVYs5r8bCleAPubX6ByySHzVKN/EhuXjP/9gqzwU3hVsyLKkzR9ryOsSir9K6BuARnbre19F9f0UN/kFCqKwbEJzYt/i6fIjrIuObicAiivGP9LREqO51a+RUo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 15, 2023 at 09:17:50PM +0800, Peng Zhang wrote: > The arguments to __must_hold() seem to be wrong so they should not work, > remove them. Why not fix them?