From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1790C77B75 for ; Mon, 15 May 2023 11:50:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E98E280001; Mon, 15 May 2023 07:50:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BF75900002; Mon, 15 May 2023 07:50:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78784280001; Mon, 15 May 2023 07:50:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 645BE900002 for ; Mon, 15 May 2023 07:50:46 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0AE7B1A143C for ; Mon, 15 May 2023 11:50:46 +0000 (UTC) X-FDA: 80792322492.08.2670532 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf07.hostedemail.com (Postfix) with ESMTP id 54A734000A for ; Mon, 15 May 2023 11:50:42 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=IkBBAEfM; dmarc=none; spf=none (imf07.hostedemail.com: domain of BATV+d8048cf69d99de8d0741+7204+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+d8048cf69d99de8d0741+7204+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684151443; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PuPfI1ULNn6nKdgBOgNMBtEbGf2urZOQinv9le4S0tg=; b=T51lFIb2Bk6ZdRf/Ve/VZvJEH75v8Gvo+Bw/HLPcjfCMY0mLqzmprnwer6XCnvGGutcVNt 1HXlKv1MzhYgzuzReOY28QQtkK9+PFtXz5p+nYhjuBEj5yLybAUtLgjgH6/y2F946HbUJY yBF1xrb20LZxl7O3h+/zLFM35A3XVSU= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=IkBBAEfM; dmarc=none; spf=none (imf07.hostedemail.com: domain of BATV+d8048cf69d99de8d0741+7204+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+d8048cf69d99de8d0741+7204+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684151443; a=rsa-sha256; cv=none; b=rfxeGJZ7T6elS66DIuqCOqM9m4M58yEaa9yVKriZCaEW7dwpePVsAL15SbJzznNoi6i/5D F4zekfIW+ROHyaKJfrzG+dM77UVfzup99YD/5hdKDH+UY5krnJAeoee5Oo80yCcFanVt0h qPqGrEcJagOYWu2kvb9XwAz+f8gpiJg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PuPfI1ULNn6nKdgBOgNMBtEbGf2urZOQinv9le4S0tg=; b=IkBBAEfMBi3BnwkUH9a+d6WFrp IAP6BVB6s9Sl8NqTDNcoPch40oFg+Og/x7m6XkOUE72+xSzl5ZlI98459I4E/du347IDxCTnReoyr 2oONv2hE1I3etOOnCSY2vH9ouRwvUXHVKKVE+lKyCxDJ7gkQCHtKzqlDKNWUmE1Pr4uvdovJE5O8U aFKw5WRtbNE+EPp9q4TeTUEoP0voDGcBEZNG9WfWZqArILRyyFm3+03au5ftDUPZXH3r+YWAxP/6I F2qrkp8eHjEgXrfMbulzU3v+q/5Tn/XUKFTFaEw9mWhCAMnwjbBu1x/P/5q4Wok0/BQJDjF1eLR8M Iv7zwhgA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pyWis-0022I3-1r; Mon, 15 May 2023 11:50:38 +0000 Date: Mon, 15 May 2023 04:50:38 -0700 From: Christoph Hellwig To: Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Matthew Wilcox , David Hildenbrand , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Dennis Dalessandro , Jason Gunthorpe , Leon Romanovsky , Christian Benvenuti , Nelson Escobar , Bernard Metzler , Mauro Carvalho Chehab , "Michael S . Tsirkin" , Jason Wang , Jens Axboe , Pavel Begunkov , Bjorn Topel , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , linuxppc-dev@lists.ozlabs.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, netdev@vger.kernel.org, io-uring@vger.kernel.org, bpf@vger.kernel.org, John Hubbard Subject: Re: [PATCH v5 5/6] mm/gup: remove vmas parameter from pin_user_pages() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: gc6npome6gzantepb9sdy159qy31tae7 X-Rspam-User: X-Rspamd-Queue-Id: 54A734000A X-Rspamd-Server: rspam07 X-HE-Tag: 1684151442-178839 X-HE-Meta: U2FsdGVkX18J75Y56Mjw86zSeShw8tyfjfDGn/VYGiwEOtenMb3EAlx/QaGEW3QxcAw+nU16fJ6IvWMbPyHLbAsjoRHtEYarKO44iUSraY2kRJEsJrJUflcu6DLA1KKKUieQnMeijrFV5CRJa5GEVlB1iJPpEltiuOybrmHCH8VmJl4rMt0T1BrIfm05/xe01LCmMIRWd76RdIEB3ZZDpUAUHoVkRfSMtq5dtks+BOgM2sS/L86BirtneHMV5NkTxCTv6BfAAW/Nhdr8CNCFnWHx4vuEZVzJ8Ubk2GL8Ww0D9svSuvF+NMy7A+QpRZy5RE+Kf1LWQCxOvzO6Pd3SldYLzl3SNGNb+MH0kLr8nr2fCgDSa7c8l960QSP2XBDmsTiyMskGUZDlSsPFwJfQ9lcRFhkrLL8rqmFOtvOvEk1w2o7QIINkja3+WI9wnS8S8wf+6ARvCnkqe7ffd4zM8V3Weg0vEWWI7Qmryi4g9Zfh2Bu5c+UZEtU4EGWXQdKXWtl8Hqt3XilN91Fok8a+5UNB/NePfNNPSvIt5LX7pvWmTnqKw7M/Nzi4W5kfZZLBNSYOD/Q5XV/csRIMi604146l8fV0V0q9+EAtTYFZNKD+o1/BnmWv5qwh2tuBlFXshNcP34r263imhb2gGrCNSF2a8OpZu3px1jHGIWKxdtmLoZI+QU6RGrdc7IF9NHE/xbXO67rzxG7n/oWlHBERPUZYdsQCWfRic9jbIg4F23A5yu78PMGFciTT6f4ieZWV0M5Kv69sfDSKxcwNzSKVZ4MsIBYnP8MwTXH1ParIvMVZnsqxU1gx0cIJlxDAUbovjlyXE724mmiy3hIYbLw6OsWYzgKVI9jpMGGdmSV2S6DwLopaTxKBxeZTKDDmFGNb2WQAupQu+RtPX1sFFmaphHYCqrKEYEwUCiY59qDICM4kIRd8waK+I8vEiYhRYiEz3X4xbBoLOmbcoX1DbCS 2jXvXf0v hgMpIGJ/R0kDLhaz1ys/G829K7PHj1PeeW8ImQjfjxOsxGAApQIXkEu2P98dG7wn8oCO6FkvqQX1pN03M1AqzwRTO/XrRPhNZzOnybLeMs7QszWsz//s3qzwOMtDibxsMuxM/PKuWdm5kfpJOP2do+eOpperI/KBcJ5RM6bs5c+KDWkLW2L25hrnv+jxMO/Xjx6gh+MHSVmrYXDyNWuueJSWwx8y9TEuielXcjR3pByBMsrHXKuAwwpEcxTJdvTGVeR6svymn4fuXYbvk4nBRyF5kQY4sot1L1n4lvf58RpTnAZPIabaZvaTU0jTqG7HUKNJ7yTikV8UzqWVpQkAGE0vKG1iPBaRbchW9F6/ocI5/Q/Nim551VBi1OCUfyBs0Kx7EskxgutIuffI9nXja5yIWucCby0pvZj3ECdSm3jydvQpf9Ss21UMsYN3y1+Q9Sj1KXcUaeuwzpgxLqkDWt6PJE8TLcOz6wBtgqNgQeEKpaD8eXrwgkO7vZKyJnyU5CYVas9CRJP8cGQTgZRFgoCLa/kkQpEtpfFRPtGhH7jR4VnCDB+PbqFEwf4JV7rdWH5ggBBOH2iLTP7lE6Sjn93SdnxUr48DS+P4rJ4Uk2+RwaPM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, May 14, 2023 at 10:26:58PM +0100, Lorenzo Stoakes wrote: > We are now in a position where no caller of pin_user_pages() requires the > vmas parameter at all, so eliminate this parameter from the function and > all callers. > > This clears the way to removing the vmas parameter from GUP altogether. > > Acked-by: David Hildenbrand > Acked-by: Dennis Dalessandro (for qib) > Signed-off-by: Lorenzo Stoakes Looks good: Reviewed-by: Christoph Hellwig