From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D46DCC77B7D for ; Mon, 15 May 2023 11:48:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 40790280001; Mon, 15 May 2023 07:48:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B786900002; Mon, 15 May 2023 07:48:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A645280001; Mon, 15 May 2023 07:48:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1971B900002 for ; Mon, 15 May 2023 07:48:24 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DF84C14142F for ; Mon, 15 May 2023 11:48:23 +0000 (UTC) X-FDA: 80792316486.09.6806924 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf02.hostedemail.com (Postfix) with ESMTP id 3CB1E8000F for ; Mon, 15 May 2023 11:48:21 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=XQzam2wx; spf=none (imf02.hostedemail.com: domain of BATV+d8048cf69d99de8d0741+7204+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+d8048cf69d99de8d0741+7204+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684151302; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pWvIuFmnhm9tAkw2SiaTeb6OI+NVYwgnGWSr09ytrtQ=; b=2o+ChWGtW2A+lPAXH/a1QUTfOo3sD4n3x5VuMQ97trpUSaHy5icsDYwKikvjxhrXM6CWGw 8V0IuIHFc+GmF6gisSXq3K5gLoEAFqr0uC04pm3tV0npPRI3b0dKenEApHSUPn1rTiiiKg tdMqXFN9nQpJPlvl2GO5QR8Q8OgQVHg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684151302; a=rsa-sha256; cv=none; b=VHaEZZ2vGyvORUpgLPiADaJ7W2lqZgDqZOcRQVBJOVIBy8lxqaG/vec82aOQjjolDn9ly9 9PWkM4Zq61f2DRKEBw4UXH7uJSqQu17D/RKaLBPXOtLXPmqvZQ3HISgMX52vkpjVhhaTXa wV7m0w1Ysj1oROJwkkXIQFsufwjhhtE= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=XQzam2wx; spf=none (imf02.hostedemail.com: domain of BATV+d8048cf69d99de8d0741+7204+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+d8048cf69d99de8d0741+7204+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=pWvIuFmnhm9tAkw2SiaTeb6OI+NVYwgnGWSr09ytrtQ=; b=XQzam2wx7hHP7RKcZRsHHTh+jH fOcWTjjLz9sOejyH0FqoW80WIs0jMVUG77AOOWswDPnFfUVa3UjFbrAr1Aw5zGeKx35WPKGV5u8Gl kIePfBPRxizMWacykL+5vtb5kgaK4nrKj2r72XFapTzCoa35QvEX9yXe/bvTMNW6DGVTJ0DhGpfbY GqnAYl994cV1eBFrSQHZTZrWKZdvNWaqtPE+EDq/oRP8hAe9fcdG7tF8ORsU1eBc7yOfS/RYXW8Ju M3yarnHLcJCEiXEtMhmrq3L6cuCo34W8D4SFZYSPcAdU2xrGXSZtow+XKlSu6G2j+zh6bCqQBAsht SCghbpJA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pyWgd-0021nL-1J; Mon, 15 May 2023 11:48:19 +0000 Date: Mon, 15 May 2023 04:48:19 -0700 From: Christoph Hellwig To: Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , iommu@lists.linux.dev, Matthew Wilcox , David Hildenbrand , kvm@vger.kernel.org, Jason Gunthorpe , Kevin Tian , Joerg Roedel , Will Deacon , Robin Murphy , Alex Williamson , Jens Axboe , Pavel Begunkov , John Hubbard , Jason Gunthorpe Subject: Re: [PATCH v5 2/6] mm/gup: remove unused vmas parameter from pin_user_pages_remote() Message-ID: References: <61f0d12058825a14feee6a3292e5a257662e719c.1684097002.git.lstoakes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <61f0d12058825a14feee6a3292e5a257662e719c.1684097002.git.lstoakes@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 3CB1E8000F X-Stat-Signature: qmninsgr5sn6rgs5yr3174d9bgmqsygx X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1684151301-12137 X-HE-Meta: U2FsdGVkX19V8y9MdGCThsghQ9DMEzMhE/2lOj+WM7QWbTWgYClZYo113ce8P3rakFyeLGVrOs3hRHX9iBkQIjOQCwiO8mWtOSoWeBUvrg4mKtDGAO3XUgdmg3R18RTEYZIILf+zjeH1ApK69Jm0fz6iDHjYNK6DtCd8bHvRtopzJ7NuJoVIy6FZ0VO0X7ja42tWk4HP3IwgU9VS2McatFnQBg8xKJkIsqnpKb+d+QXXcd3WAd5BATLwteU1AxWREMzIzVSXjgc6f75svH1mxfoqvYfdKJJXbI6V5/Gu2lVIQGX5CJrUVhd3CCuYJLERrbTn0TpiL2vqzmqjB6j0fEDpx5rmZipZIXP/GDZ4J+Ttj/nJ4lULxO5TnWpemqwaCLPzvBA1fzHD2zFcDitAGVLEuPKKHmZG/e4lQvrAOyMU/wQd9pcIaN9LKRyBaYaMWUB8te4faZrXVmTmJKgeE6vZmeZ4auuYNhW95ifjPo1oTQpqLEw+1kq1ocysZq+RIEuyvyVFLF+5X9lqWB8RToQ9EnvPAOwFfnFNZK9UoXTRxuZAirVp9/eecdVsuZNmYnOLzYzaBTniIw/GeQbVEWT6EkpZ8RmQ0ugin5xK49ZtT9GEp4z0V0/8lD8tMLwbH7HAi9hqWPeP8vnk6q7DH/YVov7nqvYNgLrhnZCXxpnayIKKpZ9YqKYhpvjbtTMBButBxGrBwlAhqVIRMP0ovkiTaMWDZk/Ahc1hTYUzhwPEQsnS8s6axkbHdM8fUj10aXz8SxCUYbzROXJCSyEr2mNQrx+oPFxhXdBekB27GO/roX32YibcVDTMJHik0zO+ko523TyrwIBdCBuqKEVX5DnXQ5QpGbRNZoZs5mNuOw3bGWyvBjJ9vPmqHNHAD7QGrKwUVpm6wMF0q4qwJb9G1DFI+x5gWKzNA0meL3WEBqjl7VLNDFqqwr7zBwvcQqUFCIoPGMum0+pDpyRM9va z+bQmg+l zCitmWu0goo0+/jwf4KxLNRg/ZTU5heouD2v8o4Hx/Qn4JpLQsRUJoPII12wyZ/ITURIJNJcMpBt4Nz1anQ4Stx+tuxCgBn+HOmFEHmbwQ1JBD13TZXvZH8ANv4/GWpf9wx1S96g4Wocv7bXBPWxXgqtlvjRnmSB6wm25vWqDUBAIIAS9iVTQQDLdHq+wfZmbJz1bxemKQXNkdsYgRUIP5HZOGnbyUL/FghHVNF4JVBeQcF/4nXVU/GUr9++t9HTgaCdgWbznx8jsybeZEBR3m6D7oa+lsLT7gshdSpzYdUR+BTVnY4M+TyjY8iTtfnvkde1DvpaS+LXlRGKNIJ5D9Jv+Z/modp6Qxg2oF04IP54dV3u2PoNOwOmk0K3A1GJU2rct6Cgl5MQJNVxbLwpSvXVvhQWZXe1tkA/lxSPyrZi7sZYpRg1/o3i54PObhT104bfSTjR8J76VvWPDGJE2isvtEDM+aMDVS4isQTNPwZwyn1xjxNcHHaf5A5IW4g2LdihG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, May 14, 2023 at 10:26:47PM +0100, Lorenzo Stoakes wrote: > No invocation of pin_user_pages_remote() uses the vmas parameter, so remove > it. This forms part of a larger patch set eliminating the use of the vmas > parameters altogether. Looks good: Reviewed-by: Christoph Hellwig