From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADA9FC7EE23 for ; Sun, 14 May 2023 09:46:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 194136B0071; Sun, 14 May 2023 05:46:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 147CD6B0072; Sun, 14 May 2023 05:46:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 032BC6B0074; Sun, 14 May 2023 05:46:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E4C956B0071 for ; Sun, 14 May 2023 05:46:37 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B418881188 for ; Sun, 14 May 2023 09:46:37 +0000 (UTC) X-FDA: 80788380834.03.FBC2363 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id 0C87640006 for ; Sun, 14 May 2023 09:46:34 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Mp3GBAf3; spf=pass (imf07.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684057595; a=rsa-sha256; cv=none; b=qFLUksk1J2mZZs7uAET3TEqdVjgGZ8cHoprSObnuL29PAxXHD+upb6pM9WvTYK6MNZbIVF BQhTqeNqBpqgTjydzwpuQO2N5dfAcOLTQmItsshUQvrFbuR7JPzTgLCSpkaIvbLD/0Q3f0 /3p7l0bzp6dgadS/DtA+9x0JUqFNMGs= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Mp3GBAf3; spf=pass (imf07.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684057595; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WpU5u1IYy960T8Ocos3ADdjyflEH2x7R2sDGVedcwRc=; b=BoachiR6xG+aH2VCprEv/4bl0mgLTPo6CBVKJL8OKVYiayGFvSMF5U+6I4e0HKX1z4SpK0 Z1ILLJ26QeLC9GbgwciQTeU1rdIJGQ9Gc8bd9pKs1xwZpcUPq+Zhs4q2j4q4VwwhSy7kyG 8M51BWaEqpAB2Z2s4IFv34VBW8gV2vA= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0F76660F70; Sun, 14 May 2023 09:46:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2889C433EF; Sun, 14 May 2023 09:46:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684057593; bh=wGeoCKdWcLNGSz8WoWm3Y/aAAFpiDlIXI/v9WFuO9SE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Mp3GBAf3LzDUamiCidb3P3OlJifz+RcW8MqMVQ51d9JaEDeOIWVYR+xh7/f4e7S+y mEKhgR//b9STacoLXO56B975kgZv1Wr1K26aOpCOUuK20RHnQPkMlPl6wKg09N4s4l N5BbgmyFn2/aLOfArJnewwsr/GR3BnGpRJ7vd3aALF3dGmIEpC5MKz58G384oTJTVr /4EdaN3bCb0ogSPKozZ5h2rm6D9MtNBffpLLc1oi8JDU9nJaJ0DOPW1yCJvHrGtf/L XQ3zpXodU+inOapslWV0Je4cZGTHEiHJo5ogeDnNnobYeYiqTo4xO0hJuSJuQv6Ze+ 25PFIiRN/Go4Q== Date: Sun, 14 May 2023 12:46:22 +0300 From: Mike Rapoport To: Claudio Migliorelli Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fix some coding style errors in memblock.c Message-ID: References: <87r0sa7mm8.fsf@mail.polimi.it> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r0sa7mm8.fsf@mail.polimi.it> X-Rspam-User: X-Stat-Signature: gh1t6nidpqn98phymz6py4bdm8g1pzdq X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 0C87640006 X-HE-Tag: 1684057594-300592 X-HE-Meta: U2FsdGVkX1+Sb0M9ByaAM3ycocOi+RIoovWl3WZA9MizqR4RsB7ZmlvmtjEVO6DDwUdccu/KLN7ZZn5D7mdCQjLxxvxvuTD7ndIx912/7SJm5/QGtnW+hwKm+brqdfkfcTfJT4Fmh9b40WSweQbPshg8LEu6ADI4NYAKKeHA3cOk5WB5eZakchihYWrzs9RvSNoPyJ/1SH3uNbcA2JryMLObnEwMgWXA/7kJH6WCUEfV9hYGyofBBHVnLEZrsB1TT/5DcRk6yNF9wwQIDtY2C3yIo81JVLDHVwpYKR3yGckJnG+0H+VAqHVBYAE/AHo6MxEbNzqDIRV/RP7rc5ryiyOQkjNb7EF2430rBhLtZ/9YvAIA9ibwti+agmC4yVtJ/J+9TdujMUqasldjYMsDfgkXYfFpt5vdODpuUC4SnXlO2Gpcu+idlo43y3embLa3T2Ba0xfNwBsByeMe+BzXlpMY8MFKMUUuM/P5kx1Y2mBYmcG7zDXi66NL1F2o/OtEGrWPINcBAlCr4aOkv0HqFwoO8whXHv+tEy4Z1J9LIAywo0SPer0GLARZGuuvL1yOh+kzm2MzRYuXsJiWuTAq8MBESB8b4JWI2ALcwShxbv9vm9vHxcusatMVovJg+GtmmrEIKt/ACAIfaoYHzqybJZgfVc23IfbfjsjETwB2ezkIcAAOq0UOjRfs0nE7Mwu1prOSE6Nirz0Rtmggx+s33wBco1HVi+UcXIKfT414FGLrkLVnuIK/WEQI4NuUrbDaWDAXzETteFsKD+7tGcYvhaStsRzfON/6jhOOj00EFK/+NrUMnXhVT5M4pQwKqGltrzhSKgMr+ip6lbZpxph+TH8VFJpbkHHybghC5fNS7xvgCPMsA66xPGOF3tBOWDU6AraKkAdrLhBCLUCenrjFB0Ty+ql/tkhY3gEAa6e/Xovf7reVmQedNWi+yXxE7jV11FeATcbl38GAk+e5bZ4 CCyOUIH8 Z64Ym4ItndkRSqa5udHhCjygZeDFHRu0GvJ1NmJHzIAieuOAQHC7hpH4u+BiHL+IKxISfC6Dn3PKHyO9eIs/rWIphEW3HKlV/Nqx0HrGPp/ASfwTN3FiYNXLn0bpmUKfpz2z2T2KMSrS2LjLAZFAM94ZZf8o0UO5Xje7fNSz9HmWuoSNOOka9NmYEwzRcS3prbrMyQYIBnHWWOUDzV8ZhzzXhinH8x+4vzybbTT38cQff3wy3puMGF/u2CPIEHawi+0RrA0IEOJajwjUDTy7g8P9TRhWIOICPlVWx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Apr 23, 2023 at 03:29:35PM +0200, Claudio Migliorelli wrote: > This patch removes the initialization of some static variables to 0 and > `false` in the memblock source file, according to the coding style > guidelines. > > Signed-off-by: Claudio Migliorelli Sorry for the delay. Applied, thanks! > mm/memblock.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index 25fd0626a9e7..6f0a2eda427c 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -156,10 +156,10 @@ static __refdata struct memblock_type *memblock_memory = &memblock.memory; > } while (0) > > static int memblock_debug __initdata_memblock; > -static bool system_has_some_mirror __initdata_memblock = false; > +static bool system_has_some_mirror __initdata_memblock; > static int memblock_can_resize __initdata_memblock; > -static int memblock_memory_in_slab __initdata_memblock = 0; > -static int memblock_reserved_in_slab __initdata_memblock = 0; > +static int memblock_memory_in_slab __initdata_memblock; > +static int memblock_reserved_in_slab __initdata_memblock; > > static enum memblock_flags __init_memblock choose_memblock_flags(void) > { > -- > 2.38.4 > > -- Sincerely yours, Mike.