From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D1C9C7EE2F for ; Thu, 25 May 2023 15:22:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 422226B0074; Thu, 25 May 2023 11:22:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D29D6B0075; Thu, 25 May 2023 11:22:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29A6B6B0078; Thu, 25 May 2023 11:22:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 19A626B0074 for ; Thu, 25 May 2023 11:22:14 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E79A01A0A79 for ; Thu, 25 May 2023 15:22:13 +0000 (UTC) X-FDA: 80829143346.21.4A4868B Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id CF0981C0014 for ; Thu, 25 May 2023 15:22:08 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=nt4MAsSs; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685028130; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3ssmfPPhjZLZynXP//sBx5vsYc+zLAKwJikGSWYPm+0=; b=8VJpAIZlA+eQK3QJ1glSyIFPKpNUEEqIkAvYBe2cS5sX63xalxXTckUJvJuB+z4EV0D8DF gX96SfxJu7d0qgPrXkegjlP8w72zKjGRsLCQTSQy2ycnQ1InLsjJXENgYz2Rhq52ALV66t 4I4ZMDYkNd7weVw6o7SUDaT5G2AYmXM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685028130; a=rsa-sha256; cv=none; b=DvyPKpuKHzV+8T+N1c5jyiFzGnFIoP+06iVxrDcGcNVEVdXqYxmcINanvcBrNDNkuG60Ly Zl99H/8taZhR7IMvNrLU14cgE3Sw4cjfMkpl7dpIhZpufVonlh6VxHAtGzS17VDjMGeZ4N 1WAOM74i+HsfLY9BbOCGKTUl0Xd9rPE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=nt4MAsSs; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3ssmfPPhjZLZynXP//sBx5vsYc+zLAKwJikGSWYPm+0=; b=nt4MAsSsht78IxSABs4xkmDWo0 EKxsw0prVbpYYsQAXeH4XMJ0x63qyDHrACDKjGmUWwQwFw95baWxLTbqrhZPi7KXXAH+6wP6XucMa nq+KefxK7MOXhK99ds49yXhZdWH2wJ6xjoin5d3g2rn7NWMViLGMYfJXwn46iT9GO4a5VRFSPaiNd KBPdPhrlWLULcchf2eZnhyQeC64cbQPOMFlWuwmQ9ClzicvdnSxdeMy+1Z0hxiR4JMndbMt6aRWcb H1/+oA57h6cZFx5kqK8oO3X3OGH4xwwUWHs8ru/wF7t/gy1/UGVmRjdzZzSg9i1OIOAzquLQnycIX zffd+X0g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1q2Cmj-00CI4P-3g; Thu, 25 May 2023 15:21:49 +0000 Date: Thu, 25 May 2023 16:21:49 +0100 From: Matthew Wilcox To: David Howells Cc: Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Christoph Hellwig , Al Viro , Jens Axboe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-kernel@kvack.org Subject: Re: [PATCH] zonefs: Call zonefs_io_error() on any error from filemap_splice_read() Message-ID: References: <3788353.1685003937@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3788353.1685003937@warthog.procyon.org.uk> X-Rspamd-Queue-Id: CF0981C0014 X-Rspam-User: X-Stat-Signature: ffxo8hzfyqn14uee4wofyrx1bgaygyxx X-Rspamd-Server: rspam03 X-HE-Tag: 1685028128-757045 X-HE-Meta: U2FsdGVkX19wNnXl7LQ4tnBxjBInR1EJSR+lU60HFp3G1WIt3ZwF/yrT6WFvWwi3gmCRZlARZ22E216PnFGYS+macAvu3ghV2Iw38yssyWudQuZvKI5+V0HsIzo5riCfB9b9X66sxAoub1ipFMXvyifJIt6CgljitODx+k3bv0BzaybPOtFvCly9hjsGlCPL4b+/mv7CTdzSITMcXaiZMWsVvRfGOQfDcBncKnwjLgNTa6FLmLn9SjBOReJSn0fppq0JlmiRPqqXSeCOFXSmxHwsia7JrKLNyvgvEloI9XtT62AIICmcCgW5vGz6G+Jx26lu7qTWxIsKAHzFksKlwTsQssKv3lfqDxuXLQ7cMteg3jcTTH9DsR/4qR/LPT7SurIOycKJ3Zp3hONin+4Dqw57rt8ho4DR/sgrTj2dtDf3PZromt/RlMAgK6yGY/8T5jmlgBeXOX1IZ59BfPpkGqm4XHIyRmmGLzRYg/00pQ6rusZBLs1rqy1NAt5MX7prqXafj5FJynNeizyy7rr+XJ/pGc2SQWUzJBQMo6XGzyYozgYFDg130G0gdW1rznrOvM7QHyiQoSc8HrjE+2qmnD5/oa73bU9E5oaAY996XKm85G6sAfVePaU5QL+ifjlNCDQtva77YKQks9vB+PJ/IuGgIFHj8rinMHhD45kKQkwTCMjvABKFLX8yDiScqRV9gdQyThlYtcTveiJtJWbqAc130bs7tPmOJGYSSrRCqeYwlHzUxrrXrstPzBAKLcrR+0iHchztBQTKytJr54yamEe0bySmRGP54Azyrf/mCuOPRQW1paliEf14nG4COM2HqMZ8acPTzEMQPnbNQrbDgD8sHKf2f945lvN1dRIU+ACzqp6lOhV5qx5AFkKjUqpU30LZ80G+qJlMEN9yKNjdgOCcPqsl3saopW1SsO1qlBmKuVxw5fPfCmoz/CUMtLN5peIPdZtaKYGJJd53MjT xHQGqDXR g3Jvumq+glpHBfQ8aq98TVPaEuy2JpoLRnfOvRUHacCbqEEJmVn1M3HMh3/x40XnoNPXw93gDh4z3UV8XhZRr+JaZgTENbcsuYmXfmbXc8+1IN7ojVPeJjNrH+lOr6UPGapyYZ0YHcZBdPUqAvTbsnmzemMIb2liNq2Dva70BVjNKj4jeJapffAWD9CJR6+sMzYHzczY/AN0xYsfuFG7VbprhULC6nykEMGWnD5rbiVAV+dCY+nbAV/z2TA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 25, 2023 at 09:38:57AM +0100, David Howells wrote: > > Call zonefs_io_error() after getting any error from filemap_splice_read() > in zonefs_file_splice_read(), including non-fatal errors such as ENOMEM, > EINTR and EAGAIN. > > Suggested-by: Damien Le Moal > Link: https://lore.kernel.org/r/5d327bed-b532-ad3b-a211-52ad0a3e276a@kernel.org/ This seems like a bizarre thing to do. Let's suppose you got an -ENOMEM. blkdev_report_zones() is also likely to report -ENOMEM in that case, which will cause a zonefs_err() to be called. Surely that can't be the desired outcome from getting -ENOMEM!